Skip to content

[NEW] Registered Loom oEmbed#28339

Merged
kodiakhq[bot] merged 2 commits into
RocketChat:developfrom
Nabhag8848:feat/register-loom-oembed
Mar 10, 2023
Merged

[NEW] Registered Loom oEmbed#28339
kodiakhq[bot] merged 2 commits into
RocketChat:developfrom
Nabhag8848:feat/register-loom-oembed

Conversation

@Nabhag8848

@Nabhag8848 Nabhag8848 commented Mar 9, 2023

Copy link
Copy Markdown
Contributor

Proposed changes (including videos or screenshots)

  • Registered Loom OEmbed, Now Loom video links will show the embedded representation of URL shared like youtube and will have the better user experience for the teams using loom.

LoomEmbedAfter

Issue(s)

Closes #28338

Steps to test or reproduce

Further comments

@Nabhag8848 Nabhag8848 changed the title [IMPROVE]: Registered Loom oEmbed [FEAT]: Registered Loom oEmbed Mar 9, 2023
@Nabhag8848 Nabhag8848 changed the title [FEAT]: Registered Loom oEmbed [NEW]: Registered Loom oEmbed Mar 9, 2023
@Nabhag8848 Nabhag8848 changed the title [NEW]: Registered Loom oEmbed [NEW] Registered Loom oEmbed Mar 9, 2023
@codecov

codecov Bot commented Mar 9, 2023

Copy link
Copy Markdown

Codecov Report

Merging #28339 (220085f) into develop (29d67d4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #28339   +/-   ##
========================================
  Coverage    45.20%   45.20%           
========================================
  Files          759      759           
  Lines        14784    14784           
  Branches      2085     2085           
========================================
  Hits          6683     6683           
- Misses        7805     7807    +2     
+ Partials       296      294    -2     
Flag Coverage Δ
e2e 45.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Nabhag8848 Nabhag8848 marked this pull request as ready for review March 9, 2023 07:41
@dionisio-bot dionisio-bot Bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 10, 2023
@hugocostadev

Copy link
Copy Markdown
Contributor

Well done @Nabhag8848 thanks for your contribution! 🚀

@hugocostadev hugocostadev added this to the 6.1.0 milestone Mar 10, 2023
@kodiakhq kodiakhq Bot merged commit 35fadd0 into RocketChat:develop Mar 10, 2023
@Nabhag8848

Nabhag8848 commented Mar 10, 2023

Copy link
Copy Markdown
Contributor Author

Well done @Nabhag8848 thanks for your contribution!
Thanks @hugocostadev for initial glimpse on oEmbed. I learnt about oEmbed and now would able to solve any similar issue and queries related to oEmbed in future. 🚀

gabriellsh added a commit that referenced this pull request Mar 13, 2023
…ketChat/Rocket.Chat into matrixSearchTestBranch

* 'feat/federation-public-room-search-2' of github.com:RocketChat/Rocket.Chat: (42 commits)
  refactor: Replace `_.isObject` with `isObject` (#28376)
  fix: small tweaks
  chore: Remove old css (#28140)
  fix: Thread list not scrolling to bottom when sending a message. (#28346)
  refactor: Federation refactor towards services + file names improvement + E2E tests fixes (#28326)
  i18n: Language update from LingoHub 🤖 on 2023-03-10Z (#28365)
  refactor: Improve sidebar search list hook (#28328)
  Chore: Change the PR title check to use conventional commits (#28358)
  [IMPROVE] Galician onboarding translation (#27908)
  [IMPROVE] Adding input type=password to AWS secrets fields (#28159)
  [FIX] Normal and multiline messages adding extra spaces upon copying/pasting (#28187)
  Chore: remove unused prop in register workspace modal (#28317)
  [FIX] App crashing when switching to Hindi (hi-In) language (#28285)
  [NEW] Registered Loom oEmbed (#28339)
  fix: create dm users before join the room
  tests: add unit tests + small tweaks
  fix: fix invite links button logic
  chore: fix lint
  Chore: Remove/replace some Meteor packages (#28189)
  Chore: Unused/dead code removal (#28155)
  ...
@casalsgh casalsgh modified the milestones: 6.1.0, 6.2.0 Apr 12, 2023
@sampaiodiego sampaiodiego mentioned this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[NEW] Loom video URL doesn't show the Embedded Representation

4 participants