Skip to content

Sync: Add rssap-feedand wp_automatic to the post type black list#6711

Merged
enejb merged 2 commits intomasterfrom
add/more-blacklist-post-types
Mar 24, 2017
Merged

Sync: Add rssap-feedand wp_automatic to the post type black list#6711
enejb merged 2 commits intomasterfrom
add/more-blacklist-post-types

Conversation

@enejb
Copy link
Copy Markdown
Member

@enejb enejb commented Mar 21, 2017

Adds 2 post types that are generated by auto post plugins. (rssap-feed and wp_automatic)

https://codecanyon.net/item/wordpress-automatic-plugin/1904470
and
https://codecanyon.net/item/rss-autopilot-unique-content-extractor/12041946

Proposed changelog entry for your changes:

Stop syncing more post types by blacklisting them

@enejb enejb added [Package] Sync [Status] Needs Review This PR is ready for review. labels Mar 21, 2017
@enejb enejb requested a review from lezama March 21, 2017 18:48
'postman_sent_mail',
'rssmi_feed_item',
'rssap-feed',
'wp_automatic'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a trailing comma to avoid issues later on when adding new items, if one were to forget to add that comma? This will also make WPCS happy :)

Thanks!

@jeherve jeherve added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Team] Poseidon and removed [Status] Needs Review This PR is ready for review. labels Mar 22, 2017
@enejb enejb added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Mar 23, 2017
@enejb
Copy link
Copy Markdown
Member Author

enejb commented Mar 23, 2017

Good catch @jeherve fixed now.

Copy link
Copy Markdown
Contributor

@dereksmart dereksmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dereksmart dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Mar 24, 2017
@enejb enejb dismissed jeherve’s stale review March 24, 2017 17:24

Take care of

@enejb enejb merged commit 1b91414 into master Mar 24, 2017
@enejb enejb deleted the add/more-blacklist-post-types branch March 24, 2017 17:25
@matticbot matticbot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 24, 2017
jeherve added a commit that referenced this pull request Mar 28, 2017
samhotchkiss pushed a commit that referenced this pull request Mar 29, 2017
* Readme: remove old release and add skeleton for 4.8.

* Changelog: add #6572

* Changelog: add #6567

* Changelog: add #6542

* Changelog: add #6527

* Changelog: add #6508

* Changelog: add #6478

* Changelog: add #6477

* Changelog: add #6249

* Update stable version and remove old version from readme.

* Changelog: add 4.7.1 to changelog.

* Readme: add new contributor.

* Sync: update docblock @SInCE version.

Related: #6053

* Changelog: add release post.

* changelog: add #6053

* Changelog: add #6413

* Changelog: add #6482

* Changelog: add #6584

* Changelog add #6603

* Changelog: add #6606

* Changelog: add #6611

* Changelog: add #6635

* Changelog: add #6639

* Changelog: add #6684

* Changelog: add #6710

* Changelog: add #6711

* Changelog: add #5461

* Testing list: update Settings UI feedback prompt.

Props @MichaelArestad

* Changelog: add #6789

* Changelog: add #6778

* Changelog: add #6777

* Changelog: add #6775

* Changelog: add #6755

* Changelog: add #6731

* Changelog: add #6721

* Changelog: add #6705

* Changelog: add #6702

* Changelog: add #6671

* Changelog: add #6637

* Changelog: add #6582

* Changelog: add #6566

* Changelog: add #6555

* Changelog: add #6529

* Changelog: add #6344

* Changelog: add #5763

* Changelog: add #5503

* Changelog: update #6637 changelog.

@see 40e115c#commitcomment-21523982

* Changelog: add #6699

* Changelog: add #6632

* Changelog: add #6769

* Changelog: add #6707

* Changelog: add #6590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants