Merged
Conversation
Since we are using jetpack_published_post instead instead. - deprecate the action. - remove listeners - update tests
| * @param int The post ID | ||
| */ | ||
| do_action( 'jetpack_publicize_post', $post->ID ); | ||
| do_action_deprecated( 'jetpack_publicize_post', $post->ID, '4.8.0', 'jetpack_published_post_flags' ); |
Contributor
There was a problem hiding this comment.
For anyone else reviewing this, do_action_deprecated() merged in to Core at 4.6.0 and as we support current and current - 1 (currently 4.7 and 4.6) we're fine to use this. 👍
Member
There was a problem hiding this comment.
Maybe we should add the hook to our own list of deprecated hooks as well?
https://github.com/Automattic/jetpack/blob/master/class.jetpack.php#L5821
Contributor
|
🚢 |
jeherve
previously requested changes
Mar 7, 2017
| * @param int The post ID | ||
| */ | ||
| do_action( 'jetpack_publicize_post', $post->ID ); | ||
| do_action_deprecated( 'jetpack_publicize_post', $post->ID, '4.8.0', 'jetpack_published_post_flags' ); |
Member
There was a problem hiding this comment.
Maybe we should add the hook to our own list of deprecated hooks as well?
https://github.com/Automattic/jetpack/blob/master/class.jetpack.php#L5821
Member
Author
|
@jeherve the function you linked to is more intended for functions and methods that we deprecated. Which is a bit different from deprecating an action hook. I think it is fine not to included it there. |
samhotchkiss
pushed a commit
that referenced
this pull request
Mar 29, 2017
* Readme: remove old release and add skeleton for 4.8. * Changelog: add #6572 * Changelog: add #6567 * Changelog: add #6542 * Changelog: add #6527 * Changelog: add #6508 * Changelog: add #6478 * Changelog: add #6477 * Changelog: add #6249 * Update stable version and remove old version from readme. * Changelog: add 4.7.1 to changelog. * Readme: add new contributor. * Sync: update docblock @SInCE version. Related: #6053 * Changelog: add release post. * changelog: add #6053 * Changelog: add #6413 * Changelog: add #6482 * Changelog: add #6584 * Changelog add #6603 * Changelog: add #6606 * Changelog: add #6611 * Changelog: add #6635 * Changelog: add #6639 * Changelog: add #6684 * Changelog: add #6710 * Changelog: add #6711 * Changelog: add #5461 * Testing list: update Settings UI feedback prompt. Props @MichaelArestad * Changelog: add #6789 * Changelog: add #6778 * Changelog: add #6777 * Changelog: add #6775 * Changelog: add #6755 * Changelog: add #6731 * Changelog: add #6721 * Changelog: add #6705 * Changelog: add #6702 * Changelog: add #6671 * Changelog: add #6637 * Changelog: add #6582 * Changelog: add #6566 * Changelog: add #6555 * Changelog: add #6529 * Changelog: add #6344 * Changelog: add #5763 * Changelog: add #5503 * Changelog: update #6637 changelog. @see 40e115c#commitcomment-21523982 * Changelog: add #6699 * Changelog: add #6632 * Changelog: add #6769 * Changelog: add #6707 * Changelog: add #6590
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we are using jetpack_published_post instead instead.
This PR is mostly clean up.
Testing instructions: