Jetpack Debug: add category dropdown to contact form.#6705
Merged
dereksmart merged 3 commits intomasterfrom Mar 28, 2017
Merged
Jetpack Debug: add category dropdown to contact form.#6705dereksmart merged 3 commits intomasterfrom
dereksmart merged 3 commits intomasterfrom
Conversation
It allows users to specify why they're contacting us. Related: p7pQDF-1gx-p2
Member
Author
|
Switching to "In Progress" as we may go with radio buttons instead of a dropdown after all. I'll come back to this. |
kraftbj
reviewed
Mar 21, 2017
class.jetpack-debugger.php
Outdated
| 'Backups' => esc_html__( 'I need help with backing up or restoring my site', 'jetpack' ), | ||
| 'Security' => esc_html__( 'I have security concerns / my site is hacked', 'jetpack' ), | ||
| 'Priority' => esc_html__( "My site is down / I can't access my site", 'jetpack' ), | ||
| 'Other' => esc_html__( 'Something Else' ), |
Contributor
There was a problem hiding this comment.
Needs text domain. For "Something Else", would it make sense to use _x and provide a translator note?
Member
Author
There was a problem hiding this comment.
Good call. Fixed in ab831c5
I'll keep editing this PR tomorrow, I want to switch from a dropdown to radio buttons, like on the contact form on WordPress.com.
Contributor
|
Tested, looks good, works well, code is 👍 |
briancolinger
approved these changes
Mar 27, 2017
Contributor
briancolinger
left a comment
There was a problem hiding this comment.
I followed the testing instructions and saw the list of reasons. I chose Backups and Restores then submitted the ticket.
I saw that the support ticket came through with the [Backups] tag.
Ship it!
samhotchkiss
pushed a commit
that referenced
this pull request
Mar 29, 2017
* Readme: remove old release and add skeleton for 4.8. * Changelog: add #6572 * Changelog: add #6567 * Changelog: add #6542 * Changelog: add #6527 * Changelog: add #6508 * Changelog: add #6478 * Changelog: add #6477 * Changelog: add #6249 * Update stable version and remove old version from readme. * Changelog: add 4.7.1 to changelog. * Readme: add new contributor. * Sync: update docblock @SInCE version. Related: #6053 * Changelog: add release post. * changelog: add #6053 * Changelog: add #6413 * Changelog: add #6482 * Changelog: add #6584 * Changelog add #6603 * Changelog: add #6606 * Changelog: add #6611 * Changelog: add #6635 * Changelog: add #6639 * Changelog: add #6684 * Changelog: add #6710 * Changelog: add #6711 * Changelog: add #5461 * Testing list: update Settings UI feedback prompt. Props @MichaelArestad * Changelog: add #6789 * Changelog: add #6778 * Changelog: add #6777 * Changelog: add #6775 * Changelog: add #6755 * Changelog: add #6731 * Changelog: add #6721 * Changelog: add #6705 * Changelog: add #6702 * Changelog: add #6671 * Changelog: add #6637 * Changelog: add #6582 * Changelog: add #6566 * Changelog: add #6555 * Changelog: add #6529 * Changelog: add #6344 * Changelog: add #5763 * Changelog: add #5503 * Changelog: update #6637 changelog. @see 40e115c#commitcomment-21523982 * Changelog: add #6699 * Changelog: add #6632 * Changelog: add #6769 * Changelog: add #6707 * Changelog: add #6590
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
It allows users to specify why they're contacting us. The form was modified on WordPress.com to support the new field. See more information in p7pQDF-1gx-p2
Testing instructions:
Proposed changelog entry for your changes: