Skip to content

Enable using full URLs in social widget services.#6508

Merged
singerb merged 3 commits intomasterfrom
add/social-widget-urls
Mar 8, 2017
Merged

Enable using full URLs in social widget services.#6508
singerb merged 3 commits intomasterfrom
add/social-widget-urls

Conversation

@zinigor
Copy link
Copy Markdown
Contributor

@zinigor zinigor commented Feb 27, 2017

Replay of #6016 by @howtoaddict with several additions.

Changes proposed in this Pull Request:

  • Allows pasting the complete URL into a service to use it instead of composing, props @howtoaddict.
  • Uses parse_url to detect URLs.
  • Constructs screen reader text differently in case a full URL is supplied.
  • Escapes URLs as late as possible.

howtoaddict and others added 3 commits December 29, 2016 17:12
Previously user could only specify username on Social media. This caused
problems with some sites like Youtube... on which you can have both User
(http://youtube.com/u/Username) and Channel
(http://youtube.com/c/Channel).
@zinigor zinigor added [Feature] Extra Sidebar Widgets [Status] Needs Review This PR is ready for review. Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Feb 27, 2017
Copy link
Copy Markdown
Contributor

@briancolinger briancolinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.
I tested on my site and it works as expected.

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Mar 1, 2017
@singerb
Copy link
Copy Markdown
Contributor

singerb commented Mar 8, 2017

Looks good, merging.

@singerb singerb merged commit 48fe703 into master Mar 8, 2017
@singerb singerb deleted the add/social-widget-urls branch March 8, 2017 11:47
@matticbot matticbot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 8, 2017
@jeherve jeherve added [Status] Needs Testing We need to add this change to the testing call for this month's release [Status] Has Changelog and removed [Status] Needs Changelog labels Mar 8, 2017
jeherve added a commit that referenced this pull request Mar 9, 2017
jeherve added a commit that referenced this pull request Mar 28, 2017
samhotchkiss pushed a commit that referenced this pull request Mar 29, 2017
* Readme: remove old release and add skeleton for 4.8.

* Changelog: add #6572

* Changelog: add #6567

* Changelog: add #6542

* Changelog: add #6527

* Changelog: add #6508

* Changelog: add #6478

* Changelog: add #6477

* Changelog: add #6249

* Update stable version and remove old version from readme.

* Changelog: add 4.7.1 to changelog.

* Readme: add new contributor.

* Sync: update docblock @SInCE version.

Related: #6053

* Changelog: add release post.

* changelog: add #6053

* Changelog: add #6413

* Changelog: add #6482

* Changelog: add #6584

* Changelog add #6603

* Changelog: add #6606

* Changelog: add #6611

* Changelog: add #6635

* Changelog: add #6639

* Changelog: add #6684

* Changelog: add #6710

* Changelog: add #6711

* Changelog: add #5461

* Testing list: update Settings UI feedback prompt.

Props @MichaelArestad

* Changelog: add #6789

* Changelog: add #6778

* Changelog: add #6777

* Changelog: add #6775

* Changelog: add #6755

* Changelog: add #6731

* Changelog: add #6721

* Changelog: add #6705

* Changelog: add #6702

* Changelog: add #6671

* Changelog: add #6637

* Changelog: add #6582

* Changelog: add #6566

* Changelog: add #6555

* Changelog: add #6529

* Changelog: add #6344

* Changelog: add #5763

* Changelog: add #5503

* Changelog: update #6637 changelog.

@see 40e115c#commitcomment-21523982

* Changelog: add #6699

* Changelog: add #6632

* Changelog: add #6769

* Changelog: add #6707

* Changelog: add #6590
@jeherve jeherve removed the [Status] Needs Testing We need to add this change to the testing call for this month's release label May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Extra Sidebar Widgets Touches WP.com Files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants