Skip to content

Featured Content: Reword checkboxes for clarity#6684

Merged
thingalon merged 2 commits intomasterfrom
update/featured-content-wording
Mar 21, 2017
Merged

Featured Content: Reword checkboxes for clarity#6684
thingalon merged 2 commits intomasterfrom
update/featured-content-wording

Conversation

@jeherve
Copy link
Copy Markdown
Member

@jeherve jeherve commented Mar 16, 2017

Fixes #6670

@kathrynwp I implemented the changes you suggested; I liked both of your suggestions. :) If I had to make one more change, I'd add "too" at the end of "Display tagged posts outside the Featured Content area", but I don't know if that would read well.

What do you think?

Proposed changelog entry for your changes:

  • Featured Content: Reword checkboxes for clarity

@jeherve jeherve added [Feature] Theme Tools [Pri] Low [Status] Needs Review This PR is ready for review. [Status] Requires String Changes Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Mar 16, 2017
@jeherve jeherve self-assigned this Mar 16, 2017
@jeherve jeherve requested a review from kathrynwp March 16, 2017 12:41
@kathrynwp
Copy link
Copy Markdown
Member

kathrynwp commented Mar 16, 2017

Thanks, Jeremy! I'd love an @Automattic/editorial set of eyes on this, as I'm also not sure about "too," but I like the idea of making it clearer that we mean "in addition to" the Featured Content area.

georgestephanis
georgestephanis reviewed Mar 16, 2017
View reviewed changes
modules/theme-tools/featured-content.php Outdated
) );
$wp_customize->add_control( 'featured-content[show-all]', array(
'label' => __( 'Display tag content in all listings.', 'jetpack' ),
'label' => __( 'Display tagged posts outside the Featured Content area.', 'jetpack' ),
Copy link
Copy Markdown
Contributor

@georgestephanis georgestephanis Mar 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe have this include an "as well" or an "also" at the end? To indicate that it is both?

moana-clip
(Maui is a hero to all!)

Copy link
Copy Markdown
Member Author

@jeherve jeherve Mar 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Changed in 9e09e7d

Thanks Maui too :)

moana-review-maui-youre-welcome-song-gif

@clucasrowlands
Copy link
Copy Markdown

clucasrowlands commented Mar 16, 2017 •
edited
Loading

Chiming in to suggest a few edits to the copy.

  • Display tagged posts outside the Featured Content area as well.
  • Also display tagged posts outside the Featured Content area.

For the "Hide tag from displaying..." line, we're currently using two verbs that kind of oppose each other (hide vs. display). Maybe try to simplify, eg:

  • Do not display tag in post details and tag clouds.
  • Hide tag in post details and tag clouds.

@kathrynwp
Copy link
Copy Markdown
Member

kathrynwp commented Mar 16, 2017

Thanks @clucasrowlands !

I really like:

Also display tagged posts outside the Featured Content area.

And I would vote for:

Do not display tag in post details and tag clouds.

This brings up a side point that I was recently discussing with @melchoyce - which is that it would be ideal to keep checkbox behaviour consistent everywhere, where checking = displays, and unchecking = hides. (This is how we implemented the checkboxes in Content Options.) In this case, the first box does the opposite: checking = hides. Probably not something we can change now, but something to be mindful of for the future.

@jeherve
Copy link
Copy Markdown
Member Author

jeherve commented Mar 17, 2017

Thank you all! I changed the wording accordingly.

@kathrynwp kathrynwp mentioned this pull request Mar 18, 2017
Closed
kathrynwp
kathrynwp reviewed Mar 18, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@kathrynwp kathrynwp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Mar 20, 2017
thingalon
thingalon approved these changes Mar 21, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@thingalon thingalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@thingalon thingalon merged commit afe0f51 into master Mar 21, 2017
@thingalon thingalon deleted the update/featured-content-wording branch March 21, 2017 05:20
@matticbot matticbot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 21, 2017
jeherve added a commit that referenced this pull request Mar 28, 2017
@jeherve
Changelog: add #6684
6905a06
samhotchkiss pushed a commit that referenced this pull request Mar 29, 2017
@jeherve @samhotchkiss
Jetpack 4.8: changelog. (#6613)
0d49aa5 
* Readme: remove old release and add skeleton for 4.8.

* Changelog: add #6572

* Changelog: add #6567

* Changelog: add #6542

* Changelog: add #6527

* Changelog: add #6508

* Changelog: add #6478

* Changelog: add #6477

* Changelog: add #6249

* Update stable version and remove old version from readme.

* Changelog: add 4.7.1 to changelog.

* Readme: add new contributor.

* Sync: update docblock @SInCE version.

Related: #6053

* Changelog: add release post.

* changelog: add #6053

* Changelog: add #6413

* Changelog: add #6482

* Changelog: add #6584

* Changelog add #6603

* Changelog: add #6606

* Changelog: add #6611

* Changelog: add #6635

* Changelog: add #6639

* Changelog: add #6684

* Changelog: add #6710

* Changelog: add #6711

* Changelog: add #5461

* Testing list: update Settings UI feedback prompt.

Props @MichaelArestad

* Changelog: add #6789

* Changelog: add #6778

* Changelog: add #6777

* Changelog: add #6775

* Changelog: add #6755

* Changelog: add #6731

* Changelog: add #6721

* Changelog: add #6705

* Changelog: add #6702

* Changelog: add #6671

* Changelog: add #6637

* Changelog: add #6582

* Changelog: add #6566

* Changelog: add #6555

* Changelog: add #6529

* Changelog: add #6344

* Changelog: add #5763

* Changelog: add #5503

* Changelog: update #6637 changelog.

@see 40e115c#commitcomment-21523982

* Changelog: add #6699

* Changelog: add #6632

* Changelog: add #6769

* Changelog: add #6707

* Changelog: add #6590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kathrynwp kathrynwp kathrynwp left review comments

@thingalon thingalon thingalon approved these changes

+1 more reviewer

@georgestephanis georgestephanis georgestephanis left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jeherve jeherve

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Theme Tools [Pri] Low [Status] Requires String Changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jeherve @kathrynwp @clucasrowlands @georgestephanis @thingalon @matticbot