Skip to content

Infinite Scroll: Change button text on taxonomy page#6584

Merged
thingalon merged 1 commit intoAutomattic:masterfrom
stoyan0v:fix/infinite-scroll/button-text-on-taxonomy-pages
Mar 16, 2017
Merged

Infinite Scroll: Change button text on taxonomy page#6584
thingalon merged 1 commit intoAutomattic:masterfrom
stoyan0v:fix/infinite-scroll/button-text-on-taxonomy-pages

Conversation

@stoyan0v
Copy link
Copy Markdown
Contributor

@stoyan0v stoyan0v commented Mar 7, 2017

Fixes #6568

Changes proposed in this Pull Request:

  • Change "Older Posts" button text, when we are on taxonomy page.
  • If a taxonomy is attached to more that one post type, leave the text "Older Posts", without confusing the users.

Testing instructions:

  • Enable Portfolio post type
  • Change posts per page to 1 ( Settings -> Reading )
  • Create at least two projects
  • Create sample Project type ( Portfolio -> Project Types -> Add New )
  • Assign the projects to that type
  • Open that Project type archive
  • Make sure that the button text is "Older Projects"

@jeherve jeherve added [Feature] Infinite Scroll [Pri] Low [Status] Needs Review This PR is ready for review. [Team] tdiv Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Mar 8, 2017
Copy link
Copy Markdown
Contributor

@singerb singerb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@singerb singerb added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Mar 8, 2017
@thingalon
Copy link
Copy Markdown
Member

Works for me. Thanks for the patch! :)

@thingalon thingalon merged commit 4b274f6 into Automattic:master Mar 16, 2017
@matticbot matticbot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 16, 2017
jeherve added a commit that referenced this pull request Mar 28, 2017
samhotchkiss pushed a commit that referenced this pull request Mar 29, 2017
* Readme: remove old release and add skeleton for 4.8.

* Changelog: add #6572

* Changelog: add #6567

* Changelog: add #6542

* Changelog: add #6527

* Changelog: add #6508

* Changelog: add #6478

* Changelog: add #6477

* Changelog: add #6249

* Update stable version and remove old version from readme.

* Changelog: add 4.7.1 to changelog.

* Readme: add new contributor.

* Sync: update docblock @SInCE version.

Related: #6053

* Changelog: add release post.

* changelog: add #6053

* Changelog: add #6413

* Changelog: add #6482

* Changelog: add #6584

* Changelog add #6603

* Changelog: add #6606

* Changelog: add #6611

* Changelog: add #6635

* Changelog: add #6639

* Changelog: add #6684

* Changelog: add #6710

* Changelog: add #6711

* Changelog: add #5461

* Testing list: update Settings UI feedback prompt.

Props @MichaelArestad

* Changelog: add #6789

* Changelog: add #6778

* Changelog: add #6777

* Changelog: add #6775

* Changelog: add #6755

* Changelog: add #6731

* Changelog: add #6721

* Changelog: add #6705

* Changelog: add #6702

* Changelog: add #6671

* Changelog: add #6637

* Changelog: add #6582

* Changelog: add #6566

* Changelog: add #6555

* Changelog: add #6529

* Changelog: add #6344

* Changelog: add #5763

* Changelog: add #5503

* Changelog: update #6637 changelog.

@see 40e115c#commitcomment-21523982

* Changelog: add #6699

* Changelog: add #6632

* Changelog: add #6769

* Changelog: add #6707

* Changelog: add #6590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Infinite Scroll [Pri] Low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants