Skip to content

Sync: Settings Endpoint: whitelist sync_via_cron setting#6477

Merged
lezama merged 2 commits intomasterfrom
update/sync-settings-endpoint
Mar 2, 2017
Merged

Sync: Settings Endpoint: whitelist sync_via_cron setting#6477
lezama merged 2 commits intomasterfrom
update/sync-settings-endpoint

Conversation

@lezama
Copy link
Copy Markdown
Contributor

@lezama lezama commented Feb 22, 2017

Testing instructions:

Make sure you can do a request to POST /sites/%s/sync/settings and change the sync_via_cron value

@lezama lezama self-assigned this Feb 22, 2017
@lezama lezama requested review from ebinnion and enejb February 22, 2017 18:20
'render_filtered_content' => '(int|bool=true) Set to 1 or true to render filtered content.',
'max_enqueue_full_sync' => '(int|bool=false) Maximum number of rows to enqueue during each full sync process',
'max_queue_size_full_sync'=> '(int|bool=false) Maximum queue size that full sync is allowed to use',
'sync_via_cron' => '(int|bool=false) Set to 1 or true to avoid using cron for sync.',
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you have some indentation issues here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's using the same indentation as other items with "short" keys in the array

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in a77aa15

@jeherve jeherve added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Feb 27, 2017
@lezama lezama added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Mar 1, 2017
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Mar 2, 2017
@lezama lezama merged commit b35498a into master Mar 2, 2017
@lezama lezama deleted the update/sync-settings-endpoint branch March 2, 2017 14:22
@matticbot matticbot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 2, 2017
jeherve added a commit that referenced this pull request Mar 9, 2017
jeherve added a commit that referenced this pull request Mar 28, 2017
samhotchkiss pushed a commit that referenced this pull request Mar 29, 2017
* Readme: remove old release and add skeleton for 4.8.

* Changelog: add #6572

* Changelog: add #6567

* Changelog: add #6542

* Changelog: add #6527

* Changelog: add #6508

* Changelog: add #6478

* Changelog: add #6477

* Changelog: add #6249

* Update stable version and remove old version from readme.

* Changelog: add 4.7.1 to changelog.

* Readme: add new contributor.

* Sync: update docblock @SInCE version.

Related: #6053

* Changelog: add release post.

* changelog: add #6053

* Changelog: add #6413

* Changelog: add #6482

* Changelog: add #6584

* Changelog add #6603

* Changelog: add #6606

* Changelog: add #6611

* Changelog: add #6635

* Changelog: add #6639

* Changelog: add #6684

* Changelog: add #6710

* Changelog: add #6711

* Changelog: add #5461

* Testing list: update Settings UI feedback prompt.

Props @MichaelArestad

* Changelog: add #6789

* Changelog: add #6778

* Changelog: add #6777

* Changelog: add #6775

* Changelog: add #6755

* Changelog: add #6731

* Changelog: add #6721

* Changelog: add #6705

* Changelog: add #6702

* Changelog: add #6671

* Changelog: add #6637

* Changelog: add #6582

* Changelog: add #6566

* Changelog: add #6555

* Changelog: add #6529

* Changelog: add #6344

* Changelog: add #5763

* Changelog: add #5503

* Changelog: update #6637 changelog.

@see 40e115c#commitcomment-21523982

* Changelog: add #6699

* Changelog: add #6632

* Changelog: add #6769

* Changelog: add #6707

* Changelog: add #6590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants