Skip to content

Subscriptions - Fix already subscribed email notification#6603

Merged
dereksmart merged 1 commit intoAutomattic:masterfrom
stoyan0v:fix/subscriptions/active-subscription-notification
Mar 20, 2017
Merged

Subscriptions - Fix already subscribed email notification#6603
dereksmart merged 1 commit intoAutomattic:masterfrom
stoyan0v:fix/subscriptions/active-subscription-notification

Conversation

@stoyan0v
Copy link
Copy Markdown
Contributor

@stoyan0v stoyan0v commented Mar 8, 2017

Fixes #3110

Changes proposed in this Pull Request:

  • Show the correct notification, when the email is already subscribed.

Testing instructions:

  • Activate "Subscription" module.
  • Add "Blog Subscription" widget to any sidebar.
  • Subscribe to the blog.
  • Refresh the page and make sure that $_GET params are removed from URL ( ?subscribe= )
  • Subscribe again.
  • You should see the following message:
    "You have already subscribed to this site. Please check your inbox."

@jeherve jeherve added [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Pri] Normal [Status] Needs Review This PR is ready for review. Bug When a feature is broken and / or not performing as intended labels Mar 8, 2017
Copy link
Copy Markdown
Member

@thingalon thingalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! Thanks for the patch.

Note: When testing, you need to click the link in the confirmation email after entering your email address the first time. Otherwise it will continue to give the "success; check your inbox" message.

@thingalon thingalon added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Mar 9, 2017
@dereksmart dereksmart merged commit 0623b1d into Automattic:master Mar 20, 2017
@dereksmart dereksmart removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 20, 2017
jeherve added a commit that referenced this pull request Mar 28, 2017
samhotchkiss pushed a commit that referenced this pull request Mar 29, 2017
* Readme: remove old release and add skeleton for 4.8.

* Changelog: add #6572

* Changelog: add #6567

* Changelog: add #6542

* Changelog: add #6527

* Changelog: add #6508

* Changelog: add #6478

* Changelog: add #6477

* Changelog: add #6249

* Update stable version and remove old version from readme.

* Changelog: add 4.7.1 to changelog.

* Readme: add new contributor.

* Sync: update docblock @SInCE version.

Related: #6053

* Changelog: add release post.

* changelog: add #6053

* Changelog: add #6413

* Changelog: add #6482

* Changelog: add #6584

* Changelog add #6603

* Changelog: add #6606

* Changelog: add #6611

* Changelog: add #6635

* Changelog: add #6639

* Changelog: add #6684

* Changelog: add #6710

* Changelog: add #6711

* Changelog: add #5461

* Testing list: update Settings UI feedback prompt.

Props @MichaelArestad

* Changelog: add #6789

* Changelog: add #6778

* Changelog: add #6777

* Changelog: add #6775

* Changelog: add #6755

* Changelog: add #6731

* Changelog: add #6721

* Changelog: add #6705

* Changelog: add #6702

* Changelog: add #6671

* Changelog: add #6637

* Changelog: add #6582

* Changelog: add #6566

* Changelog: add #6555

* Changelog: add #6529

* Changelog: add #6344

* Changelog: add #5763

* Changelog: add #5503

* Changelog: update #6637 changelog.

@see 40e115c#commitcomment-21523982

* Changelog: add #6699

* Changelog: add #6632

* Changelog: add #6769

* Changelog: add #6707

* Changelog: add #6590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug When a feature is broken and / or not performing as intended [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Pri] Normal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants