Skip to content

Admin Page: Make sure Gravatar is always displayed in Settings.#6555

Merged
briancolinger merged 1 commit intomasterfrom
fix/gravatar-admin
Mar 27, 2017
Merged

Admin Page: Make sure Gravatar is always displayed in Settings.#6555
briancolinger merged 1 commit intomasterfrom
fix/gravatar-admin

Conversation

@jeherve
Copy link
Copy Markdown
Member

@jeherve jeherve commented Mar 3, 2017

Fixes #6545

Changes proposed in this Pull Request:

  • Always display the Gravatar on Jetpack's Connection settings page, even when avatars are deactivated under Settings > Discussion.

Testing instructions:

  1. Visit wp-admin > Settings > Discussion
  2. Disable the Show Avatars setting
  3. Connect Jetpack
  4. Visit Jetpack > Settings > Connection Settings

cc @alexjgustafson @danjjohnson

Make sure the Gravatar is properly displayed.

Proposed changelog entry for your changes:

  • Admin Page: Make sure Gravatar is always displayed in Settings.

@jeherve jeherve added Admin Page React-powered dashboard under the Jetpack menu [Pri] Low [Status] Needs Review This PR is ready for review. Bug When a feature is broken and / or not performing as intended labels Mar 3, 2017
@jeherve jeherve self-assigned this Mar 3, 2017
Copy link
Copy Markdown
Member

@rcoll rcoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. LGTM!

@rcoll rcoll added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Mar 27, 2017
@briancolinger briancolinger merged commit 2b149e7 into master Mar 27, 2017
@briancolinger briancolinger deleted the fix/gravatar-admin branch March 27, 2017 17:26
@matticbot matticbot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 27, 2017
jeherve added a commit that referenced this pull request Mar 28, 2017
samhotchkiss pushed a commit that referenced this pull request Mar 29, 2017
* Readme: remove old release and add skeleton for 4.8.

* Changelog: add #6572

* Changelog: add #6567

* Changelog: add #6542

* Changelog: add #6527

* Changelog: add #6508

* Changelog: add #6478

* Changelog: add #6477

* Changelog: add #6249

* Update stable version and remove old version from readme.

* Changelog: add 4.7.1 to changelog.

* Readme: add new contributor.

* Sync: update docblock @SInCE version.

Related: #6053

* Changelog: add release post.

* changelog: add #6053

* Changelog: add #6413

* Changelog: add #6482

* Changelog: add #6584

* Changelog add #6603

* Changelog: add #6606

* Changelog: add #6611

* Changelog: add #6635

* Changelog: add #6639

* Changelog: add #6684

* Changelog: add #6710

* Changelog: add #6711

* Changelog: add #5461

* Testing list: update Settings UI feedback prompt.

Props @MichaelArestad

* Changelog: add #6789

* Changelog: add #6778

* Changelog: add #6777

* Changelog: add #6775

* Changelog: add #6755

* Changelog: add #6731

* Changelog: add #6721

* Changelog: add #6705

* Changelog: add #6702

* Changelog: add #6671

* Changelog: add #6637

* Changelog: add #6582

* Changelog: add #6566

* Changelog: add #6555

* Changelog: add #6529

* Changelog: add #6344

* Changelog: add #5763

* Changelog: add #5503

* Changelog: update #6637 changelog.

@see 40e115c#commitcomment-21523982

* Changelog: add #6699

* Changelog: add #6632

* Changelog: add #6769

* Changelog: add #6707

* Changelog: add #6590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Admin Page React-powered dashboard under the Jetpack menu Bug When a feature is broken and / or not performing as intended [Pri] Low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants