Skip to content

Carousel: add support for the new Tiled Gallery block.#11060

Merged
jeherve merged 1 commit intomasterfrom
add/carousel-tiled-block-support
Jan 3, 2019
Merged

Carousel: add support for the new Tiled Gallery block.#11060
jeherve merged 1 commit intomasterfrom
add/carousel-tiled-block-support

Conversation

@jeherve
Copy link
Copy Markdown
Member

@jeherve jeherve commented Jan 2, 2019

Fixes Automattic/wp-calypso#28614
Fixes Automattic/wp-calypso#29774

Changes proposed in this Pull Request:

  • Add a new filter to the output of the tiled gallery block, to allow us to inject the data needed by
    Carousel.
  • Add data to gallery container when using the Tiled Gallery block.
  • Trigger Carousel modal on clicks on Tiled Gallery blocks

Testing instructions:

  • Create 4 posts on your site:
    • one with a classic block and a classic gallery in it
    • one with a core gallery block
    • one with a new tiled gallery block
    • one with a classic block and a tiled gallery in it.
  • Make sure Carousel works for all 4 posts; you should be able to open the Carousel modal when clicking on an image, and the image that pops up should be the one you clicked on.

Proposed changelog entry for your changes:

  • Carousel: add support for the new Tiled Gallery block.

@jeherve jeherve added Bug When a feature is broken and / or not performing as intended [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Feature] Tiled Gallery A different way to display image galleries on your site, in different organizations and shapes. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Jan 2, 2019
@jeherve jeherve added this to the 6.9 milestone Jan 2, 2019
@jeherve jeherve self-assigned this Jan 2, 2019
@jeherve jeherve requested review from a team, simison and sirreal January 2, 2019 12:43
@matticbot
Copy link
Copy Markdown
Contributor

matticbot commented Jan 2, 2019

D22743-code. (newly created revision)

@jeherve jeherve added the [Status] Needs Review This PR is ready for review. label Jan 2, 2019
@jetpackbot
Copy link
Copy Markdown
Collaborator

jetpackbot commented Jan 2, 2019 •
edited
Loading

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

This is automated check which relies on PULL_REQUEST_TEMPLATE.We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 0dcd44e

@simison simison requested review from a team January 2, 2019 15:34
brbrr
brbrr previously approved these changes Jan 3, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@brbrr brbrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 🚢

@brbrr brbrr added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Jan 3, 2019
@jeherve @ockham
Carousel: add support for the new Tiled Gallery block.
0dcd44e 
- Add a new filter to the output of the tiled gallery block, to allow us to inject the data needed by
Carousel.
- Add data to gallery container when using the Tiled Gallery block.
- Trigger Carousel modal on clicks on Tiled Gallery blocks
@ockham ockham force-pushed the add/carousel-tiled-block-support branch from a0f857a to 0dcd44e Compare January 3, 2019 12:42
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jan 3, 2019
lezama
lezama approved these changes Jan 3, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@lezama lezama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 IT

@ockham
Copy link
Copy Markdown
Contributor

ockham commented Jan 3, 2019

Carousel images currently show up broken in my local JP docker instance

image

but maybe that's somehow due to my local setup, if it works for everyone else.

@ockham
Copy link
Copy Markdown
Contributor

ockham commented Jan 3, 2019

(Looks like Photon doesn't like my ngrok URL, which I guess isn't too worrying.)

@jeherve
Copy link
Copy Markdown
Member Author

jeherve commented Jan 3, 2019

Looks like Photon doesn't like my ngrok URL, which I guess isn't too worrying.

That could be it indeed, although Photon does work on my ngrok instance. Do you have this issue with all images on your site?

brbrr
brbrr approved these changes Jan 3, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@brbrr brbrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For good count 🐑

@brbrr brbrr added the [Status] Ready to Merge Go ahead, you can push that green button! label Jan 3, 2019
@jeherve jeherve merged commit 6189a00 into master Jan 3, 2019
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jan 3, 2019
@jeherve jeherve deleted the add/carousel-tiled-block-support branch January 3, 2019 15:39
jeherve added a commit that referenced this pull request Jan 3, 2019
@jeherve
Changelog: add #11060
5a229e6
jeherve added a commit that referenced this pull request Jan 3, 2019
@jeherve
Jetpack 6.9: Changelog and testing list (#10722)
8d91603 
* Add first version of the Changelog and testing list for 6.9

* Changelog: add #10710

* changelog: add #10538

* changelog: add #10741

* changelog: add #10749

* changelog: add #10664

* changelog: add #10224

* changelog: add #10788

* Changelog: add #10560

* Chanegelog: add #10812

* changelog: add #10556

* Changelog: add #10668

* Changelog: add #10846

* Changelog: add #10947

* Changelog: add #10962

* Changelog: add #10956

* Changelog: add #10940

* Changelog: add #10934

* Changelog: add #10912

* changelog: add #10866

* changelog: add #10924

* Changelog: add #10936

* Changelog: add #10833

* changelog: add #10867

* Changelog: add #10960

* Changelog: add #10888

* changelog: add #10840

* changelog: add #10972

* Changelog: add #10979

* changelog: add #10909

* Changelog: add #10958

* Changelog: add #10981

* Changelog: add #10564

* Changelog: add #10809

* Changelog: add #10982

* Changelog: add #10706

* Changelog: add #10978

* Changelog: add #10132

* Changelog: add #11022

* Changelog: add #11024

* Changelog: add #10875

* Changelog: add #11030

* Changelog: add #11053

* Changelog: add #10880

* Changelog: add #9359

* Changelog: add #11037

* Update block list

* Changelog: add #11060

* Changelog: add #10755

* changelog: add #11000

* Changelog: add #10786

* Changelog: add #10945

* Changelog: add #10597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lezama lezama lezama approved these changes

@simison simison Awaiting requested review from simison

@sirreal sirreal Awaiting requested review from sirreal

+1 more reviewer

@brbrr brbrr brbrr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jeherve jeherve

Labels

Bug When a feature is broken and / or not performing as intended [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Feature] Tiled Gallery A different way to display image galleries on your site, in different organizations and shapes. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files

Projects

None yet

Milestone

6.9

Development

Successfully merging this pull request may close these issues.

6 participants

@jeherve @matticbot @jetpackbot @ockham @lezama @brbrr