Skip to content

Sharing: update Tumblr official sharing button.#10755

Merged
oskosk merged 1 commit intomasterfrom
update/tumblr-sharing
Jan 3, 2019
Merged

Sharing: update Tumblr official sharing button.#10755
oskosk merged 1 commit intomasterfrom
update/tumblr-sharing

Conversation

@jeherve
Copy link
Copy Markdown
Member

@jeherve jeherve commented Nov 30, 2018

Fixes #10754

Changes proposed in this Pull Request:

  • The Tumblr js file we used for Tumblr's official sharing button does not exist anymore, it returns a
    404
  • This PR updates the button to use the method now recommended here:
    https://www.tumblr.com/docs/en/share_button
  • The new button method gives you the option to define a post type when sharing. If you don't define
    any, Tumblr parses the page to try to figure it out on its own. Let's not allow it to do that when the
    button appears on the home page or archive pages, where tumblr could find other elements that do not
    belong to our post.

Testing instructions:

  • Log in to your Tumblr account.
  • Go to settings > sharing
  • Add a tumblr button to your sharing buttons, choose the official button type, and display the buttons on the home page as well as single posts.
  • Visit a post with a video and click the sharing button: it should open a pop up with the video post type auto picked.
  • Visit your home page, and make sure that home page displays the video from your video post.
  • Click the sharing button for a post other than the video post.
  • Make sure the pop up shows info about the post you intent to share, not any other.

Proposed changelog entry for your changes:

  • Sharing: update Tumblr official sharing button.

Fixes #10754

- The Tumblr js file we used for Tumblr's official sharing button does not exist anymore, it returns a
404
- This PR updates the button to use the method now recommended here:
https://www.tumblr.com/docs/en/share_button
- The new button method gives you the option to define a post type when sharing. If you don't define
any, Tumblr parses the page to try to figure it out on its own. Let's not allow it to do that when the
button appears on the home page or archive pages, where tumblr could find other elements that do not
belong to our post.
@jeherve jeherve added Bug When a feature is broken and / or not performing as intended [Feature] Sharing Post sharing, sharing buttons [Status] Needs Review This PR is ready for review. labels Nov 30, 2018
@jeherve jeherve self-assigned this Nov 30, 2018
@jeherve jeherve requested a review from a team November 30, 2018 13:45
@matticbot
Copy link
Copy Markdown
Contributor

D21605-code. (newly created revision)

@jetpackbot
Copy link
Copy Markdown
Collaborator

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: January 10, 2019.
Scheduled code freeze: January 3, 2019

Generated by 🚫 dangerJS

Copy link
Copy Markdown
Contributor

@brbrr brbrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tests well. 🚢

@brbrr brbrr added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Dec 18, 2018
@jeherve jeherve added this to the 6.9 milestone Jan 3, 2019
Copy link
Copy Markdown
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oskosk oskosk merged commit 0da5e5d into master Jan 3, 2019
@ghost ghost removed [Status] Needs Changelog [Status] Ready to Merge Go ahead, you can push that green button! labels Jan 3, 2019
@oskosk oskosk deleted the update/tumblr-sharing branch January 3, 2019 14:32
jeherve added a commit that referenced this pull request Jan 3, 2019
jeherve added a commit that referenced this pull request Jan 3, 2019
* Add first version of the Changelog and testing list for 6.9

* Changelog: add #10710

* changelog: add #10538

* changelog: add #10741

* changelog: add #10749

* changelog: add #10664

* changelog: add #10224

* changelog: add #10788

* Changelog: add #10560

* Chanegelog: add #10812

* changelog: add #10556

* Changelog: add #10668

* Changelog: add #10846

* Changelog: add #10947

* Changelog: add #10962

* Changelog: add #10956

* Changelog: add #10940

* Changelog: add #10934

* Changelog: add #10912

* changelog: add #10866

* changelog: add #10924

* Changelog: add #10936

* Changelog: add #10833

* changelog: add #10867

* Changelog: add #10960

* Changelog: add #10888

* changelog: add #10840

* changelog: add #10972

* Changelog: add #10979

* changelog: add #10909

* Changelog: add #10958

* Changelog: add #10981

* Changelog: add #10564

* Changelog: add #10809

* Changelog: add #10982

* Changelog: add #10706

* Changelog: add #10978

* Changelog: add #10132

* Changelog: add #11022

* Changelog: add #11024

* Changelog: add #10875

* Changelog: add #11030

* Changelog: add #11053

* Changelog: add #10880

* Changelog: add #9359

* Changelog: add #11037

* Update block list

* Changelog: add #11060

* Changelog: add #10755

* changelog: add #11000

* Changelog: add #10786

* Changelog: add #10945

* Changelog: add #10597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug When a feature is broken and / or not performing as intended [Feature] Sharing Post sharing, sharing buttons Touches WP.com Files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants