Skip to content

WooCommerce Analytics: a fix to check if the WC session is a valid object#10538

Merged
jeherve merged 1 commit intomasterfrom
fix/wc-session-is-null
Nov 27, 2018
Merged

WooCommerce Analytics: a fix to check if the WC session is a valid object#10538
jeherve merged 1 commit intomasterfrom
fix/wc-session-is-null

Conversation

@greenafrican
Copy link
Copy Markdown
Contributor

@greenafrican greenafrican commented Nov 5, 2018

Fixes #10533

Changes proposed in this Pull Request:

  • Two checks to ensure WC()->session exists before calling get

Testing instructions:

Proposed changelog entry for your changes:

  • WooCommerce Analytics: ensure WC()->session exists before calling get method

@greenafrican greenafrican requested review from a team, jeherve and psealock November 5, 2018 15:21
@greenafrican greenafrican self-assigned this Nov 5, 2018
@greenafrican greenafrican added Bug When a feature is broken and / or not performing as intended [Feature] WooCommerce Analytics [Pri] Normal [Status] Needs Review This PR is ready for review. labels Nov 5, 2018
@jetpackbot
Copy link
Copy Markdown
Collaborator

jetpackbot commented Nov 5, 2018

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: December 4, 2018.
Scheduled code freeze: November 27, 2018

Generated by 🚫 dangerJS

@kraftbj kraftbj added this to the 6.8 milestone Nov 5, 2018
kraftbj
kraftbj approved these changes Nov 5, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@kraftbj kraftbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good and worked for me, but unable to repo the original issue either.

@hr-automation -- Would you be able to test this on the site where you originally reported the issue? You can download the Jetpack Beta Plugin and then click the Jetpack Beta button on the admin bar once activated. On that page, you can search for the fix/wc-session-is-null branch to grab a copy of this version of Jetpack to test.

@kraftbj kraftbj added [Status] Needs Testing We need to add this change to the testing call for this month's release and removed [Status] Needs Review This PR is ready for review. labels Nov 5, 2018
@jeherve
Copy link
Copy Markdown
Member

jeherve commented Nov 16, 2018

@hr-automation Did you have the chance to give that patch a try yet?

@jeherve jeherve removed this from the 6.8 milestone Nov 20, 2018
@hr-automation
Copy link
Copy Markdown

hr-automation commented Nov 27, 2018

@hr-automation Did you have the chance to give that patch a try yet?

Sry for late response - the fix worked like a charm! Thanks for that!

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Testing We need to add this change to the testing call for this month's release labels Nov 27, 2018
@jeherve jeherve merged commit 62e6883 into master Nov 27, 2018
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Nov 27, 2018
@jeherve jeherve deleted the fix/wc-session-is-null branch November 27, 2018 14:09
jeherve added a commit that referenced this pull request Dec 19, 2018
@jeherve
changelog: add #10538
82745da
jeherve added a commit that referenced this pull request Jan 3, 2019
@jeherve
changelog: add #10538
da4470b
jeherve added a commit that referenced this pull request Jan 3, 2019
@jeherve
Jetpack 6.9: Changelog and testing list (#10722)
8d91603 
* Add first version of the Changelog and testing list for 6.9

* Changelog: add #10710

* changelog: add #10538

* changelog: add #10741

* changelog: add #10749

* changelog: add #10664

* changelog: add #10224

* changelog: add #10788

* Changelog: add #10560

* Chanegelog: add #10812

* changelog: add #10556

* Changelog: add #10668

* Changelog: add #10846

* Changelog: add #10947

* Changelog: add #10962

* Changelog: add #10956

* Changelog: add #10940

* Changelog: add #10934

* Changelog: add #10912

* changelog: add #10866

* changelog: add #10924

* Changelog: add #10936

* Changelog: add #10833

* changelog: add #10867

* Changelog: add #10960

* Changelog: add #10888

* changelog: add #10840

* changelog: add #10972

* Changelog: add #10979

* changelog: add #10909

* Changelog: add #10958

* Changelog: add #10981

* Changelog: add #10564

* Changelog: add #10809

* Changelog: add #10982

* Changelog: add #10706

* Changelog: add #10978

* Changelog: add #10132

* Changelog: add #11022

* Changelog: add #11024

* Changelog: add #10875

* Changelog: add #11030

* Changelog: add #11053

* Changelog: add #10880

* Changelog: add #9359

* Changelog: add #11037

* Update block list

* Changelog: add #11060

* Changelog: add #10755

* changelog: add #11000

* Changelog: add #10786

* Changelog: add #10945

* Changelog: add #10597
@jeherve jeherve mentioned this pull request Mar 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kraftbj kraftbj kraftbj approved these changes

@psealock psealock Awaiting requested review from psealock

@jeherve jeherve Awaiting requested review from jeherve

Assignees

@greenafrican greenafrican

Labels

Bug When a feature is broken and / or not performing as intended [Feature] WooCommerce Analytics [Pri] Normal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@greenafrican @jetpackbot @jeherve @hr-automation @kraftbj @matticbot