Skip to content

Admin Page: hide Related Posts preview when not active.#10956

Merged
jeherve merged 1 commit intomasterfrom
update/related-posts-hide-preview
Dec 13, 2018
Merged

Admin Page: hide Related Posts preview when not active.#10956
jeherve merged 1 commit intomasterfrom
update/related-posts-hide-preview

Conversation

@jeherve
Copy link
Copy Markdown
Member

@jeherve jeherve commented Dec 12, 2018

Fixes #10691

Changes proposed in this Pull Request:

  • We now hide the Related Posts preview when the module is not active.

screen recording 2018-12-12 at 12 01 pm

Testing instructions:

  • Go to Settings > Traffic
  • Activate and deactivate the Related Posts module, and make sure the preview appearing below the toggles is updated accordingly.

Proposed changelog entry for your changes:

  • Admin Page: hide Related Posts preview when not active.

@jeherve jeherve added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Related Posts [Status] Needs Review This PR is ready for review. [Status] Needs Design Review Design has been added. Needs a review! Admin Page React-powered dashboard under the Jetpack menu labels Dec 12, 2018
@jeherve jeherve added this to the 6.9 milestone Dec 12, 2018
@jeherve jeherve self-assigned this Dec 12, 2018
@jeherve jeherve requested review from a team and oskosk December 12, 2018 11:06
@jetpackbot
Copy link
Copy Markdown
Collaborator

jetpackbot commented Dec 12, 2018

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: January 10, 2019.
Scheduled code freeze: January 3, 2019

Generated by 🚫 dangerJS against 9ffde11

keoshi
keoshi reviewed Dec 12, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@keoshi keoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

Though I have to say that in the context of “early value” this leaves me a bit conflicted. Isn't showing a preview providing more value than hiding it behind a toggle? In that sense, shouldn't Highlight related content with a heading and Show a thumbnail image where available also be hidden? I can see the argument for simplifying the UI, but IMO this shows less value early on. cc @rickybanister @joanrho

@rickybanister
Copy link
Copy Markdown

rickybanister commented Dec 12, 2018

I see that point @keoshi, but this is the only feature that did that. Nothing else hints at what will happen after it's turned on. I guess I'd rather consistency here and we work on systematically making it easier for customers to understand.

Perhaps we consider making the info bubbles much less useless and putting a case study inside them instead of a silly link to documentation. By 'case study' I mean a screenshot of the feature in use on the front-end where applicable and a pitch of the value proposition of the feature.

Or something similar.

oskosk
oskosk approved these changes Dec 13, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected!

@oskosk oskosk added [Status] Ready to Merge Go ahead, you can push that green button! [Status] Design Review Complete and removed [Status] Needs Design Review Design has been added. Needs a review! [Status] Needs Review This PR is ready for review. labels Dec 13, 2018
@jeherve jeherve merged commit ba4d5e8 into master Dec 13, 2018
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Dec 13, 2018
@jeherve jeherve deleted the update/related-posts-hide-preview branch December 13, 2018 18:34
jeherve added a commit that referenced this pull request Dec 19, 2018
@jeherve
Changelog: add #10956
66375e5
jeherve added a commit that referenced this pull request Jan 3, 2019
@jeherve
Changelog: add #10956
a61fecc
jeherve added a commit that referenced this pull request Jan 3, 2019
@jeherve
Jetpack 6.9: Changelog and testing list (#10722)
8d91603 
* Add first version of the Changelog and testing list for 6.9

* Changelog: add #10710

* changelog: add #10538

* changelog: add #10741

* changelog: add #10749

* changelog: add #10664

* changelog: add #10224

* changelog: add #10788

* Changelog: add #10560

* Chanegelog: add #10812

* changelog: add #10556

* Changelog: add #10668

* Changelog: add #10846

* Changelog: add #10947

* Changelog: add #10962

* Changelog: add #10956

* Changelog: add #10940

* Changelog: add #10934

* Changelog: add #10912

* changelog: add #10866

* changelog: add #10924

* Changelog: add #10936

* Changelog: add #10833

* changelog: add #10867

* Changelog: add #10960

* Changelog: add #10888

* changelog: add #10840

* changelog: add #10972

* Changelog: add #10979

* changelog: add #10909

* Changelog: add #10958

* Changelog: add #10981

* Changelog: add #10564

* Changelog: add #10809

* Changelog: add #10982

* Changelog: add #10706

* Changelog: add #10978

* Changelog: add #10132

* Changelog: add #11022

* Changelog: add #11024

* Changelog: add #10875

* Changelog: add #11030

* Changelog: add #11053

* Changelog: add #10880

* Changelog: add #9359

* Changelog: add #11037

* Update block list

* Changelog: add #11060

* Changelog: add #10755

* changelog: add #11000

* Changelog: add #10786

* Changelog: add #10945

* Changelog: add #10597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keoshi keoshi keoshi left review comments

+1 more reviewer

@oskosk oskosk oskosk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jeherve jeherve

Labels

Admin Page React-powered dashboard under the Jetpack menu Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Related Posts [Status] Design Review Complete

Projects

None yet

Milestone

6.9

Development

Successfully merging this pull request may close these issues.

6 participants

@jeherve @jetpackbot @rickybanister @keoshi @oskosk @matticbot