Carousel: do not open modal when clicking on a link in a caption#11024
Merged
Carousel: do not open modal when clicking on a link in a caption#11024
Conversation
Fixes #10997 The new Core gallery block introduces a different markup for captions. This PR makes sure that when clicking on a link in a caption inside a core gallery, you get redirected to that link, instead of having the Carousel modal open.
Contributor
|
D22601-code. (newly created revision) |
Collaborator
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: January 10, 2019. |
brbrr
approved these changes
Dec 21, 2018
Contributor
brbrr
left a comment
There was a problem hiding this comment.
Works well! 
One thing I noticed, which probably not related to this PR - when closing carousel modal via 'X' button - I get redirected back to wp-admin (which is my previous page)
zinigor
approved these changes
Dec 21, 2018
Contributor
zinigor
left a comment
There was a problem hiding this comment.
Code looks good, works as expected!
Member
Author
|
Thanks for the reviews. Merging.
Yep, that's #6244 |
jeherve
added a commit
that referenced
this pull request
Jan 3, 2019
* Add first version of the Changelog and testing list for 6.9 * Changelog: add #10710 * changelog: add #10538 * changelog: add #10741 * changelog: add #10749 * changelog: add #10664 * changelog: add #10224 * changelog: add #10788 * Changelog: add #10560 * Chanegelog: add #10812 * changelog: add #10556 * Changelog: add #10668 * Changelog: add #10846 * Changelog: add #10947 * Changelog: add #10962 * Changelog: add #10956 * Changelog: add #10940 * Changelog: add #10934 * Changelog: add #10912 * changelog: add #10866 * changelog: add #10924 * Changelog: add #10936 * Changelog: add #10833 * changelog: add #10867 * Changelog: add #10960 * Changelog: add #10888 * changelog: add #10840 * changelog: add #10972 * Changelog: add #10979 * changelog: add #10909 * Changelog: add #10958 * Changelog: add #10981 * Changelog: add #10564 * Changelog: add #10809 * Changelog: add #10982 * Changelog: add #10706 * Changelog: add #10978 * Changelog: add #10132 * Changelog: add #11022 * Changelog: add #11024 * Changelog: add #10875 * Changelog: add #11030 * Changelog: add #11053 * Changelog: add #10880 * Changelog: add #9359 * Changelog: add #11037 * Update block list * Changelog: add #11060 * Changelog: add #10755 * changelog: add #11000 * Changelog: add #10786 * Changelog: add #10945 * Changelog: add #10597
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10997
Changes proposed in this Pull Request:
The new Core gallery block introduces a different markup for captions.
This PR makes sure that when clicking on a link in a caption inside a core gallery, you get redirected
to that link, instead of having the Carousel modal open.
Testing instructions:
Start from a site with the Carousel module active, and running WP 5.0+
Create a new gallery using the Gallery block.
Add a caption to one of your images, with a link like so:
Publish your post
View post.
Click on the link in the caption.
Make sure you are redirected to the link location, instead of having the Carousel modal open.
Check that clicking on the image itself works.
Proposed changelog entry for your changes: