Skip to content

Simple Payments Block: Fix availability#10833

Merged
dereksmart merged 1 commit intomasterfrom
fix/simple-payments-availability
Dec 11, 2018
Merged

Simple Payments Block: Fix availability#10833
dereksmart merged 1 commit intomasterfrom
fix/simple-payments-availability

Conversation

@ockham
Copy link
Copy Markdown
Contributor

@ockham ockham commented Dec 5, 2018

Untested Counterpart to @enejb's D21761-code, to get files back in sync. Copying that diff's description:

Previously when we called the load blocks methods the call is being done too early in the rest api context. Which resulted in the api returnig the wrong data because we haven't switched to the correct blog contexts. We were always returning the availability as if we from the public-api.wordpress.com domain.

Changes proposed in this Pull Request:

This PR fixes this by making sure we load/register the blocks in the right context. And by allowing the blocks to pass a callback that gets called once in the right context ensuring that the data is as expected.

Testing instructions:

  • Start with a Jetpack test site with a free plan
  • Install either the REST API Console plugin or the Basic Authentication plugin.
  • Use either plugin to run a GET request to /wp-json/wpcom/v2/gutenberg/available-extensions
  • the simple payments block should be unavailable
  • Now buy a Jetpack Premium plan
  • Run the same GET request again
  • the simple payments block should be available

@ockham ockham self-assigned this Dec 5, 2018
@ockham ockham requested review from a team, enejb and roccotripaldi December 5, 2018 10:06
@matticbot
Copy link
Copy Markdown
Contributor

matticbot commented Dec 5, 2018

D21832-code. (newly created revision)

@jetpackbot
Copy link
Copy Markdown
Collaborator

jetpackbot commented Dec 5, 2018

Warnings
⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is automated check which relies on PULL_REQUEST_TEMPLATE.We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS

@dereksmart
Copy link
Copy Markdown
Contributor

dereksmart commented Dec 6, 2018

@ockham this changeset was already deployed to wpcom, why still labeled in progress here?

@ockham
Copy link
Copy Markdown
Contributor Author

ockham commented Dec 6, 2018

@ockham this changeset was already deployed to wpcom, why still labeled in progress here?

Uh, good point. Mostly to signal that I hadn't tested this (and that it might require fixing to make it actually work). Should I set it to 'Needs Review' regardless?

(Not sure I'll get to it by EOW, I mostly filed it so it wouldn't fall through the cracks and so I could come back to it later.)

@dereksmart dereksmart merged commit 0625cf5 into master Dec 11, 2018
@dereksmart dereksmart deleted the fix/simple-payments-availability branch December 11, 2018 20:57
@dereksmart
Copy link
Copy Markdown
Contributor

dereksmart commented Dec 11, 2018

Worked like a charm!

jeherve added a commit that referenced this pull request Dec 19, 2018
@jeherve
Changelog: add #10833
72d68d9
jeherve added a commit that referenced this pull request Jan 3, 2019
@jeherve
Changelog: add #10833
1e9dc87
jeherve added a commit that referenced this pull request Jan 3, 2019
@jeherve
Jetpack 6.9: Changelog and testing list (#10722)
8d91603 
* Add first version of the Changelog and testing list for 6.9

* Changelog: add #10710

* changelog: add #10538

* changelog: add #10741

* changelog: add #10749

* changelog: add #10664

* changelog: add #10224

* changelog: add #10788

* Changelog: add #10560

* Chanegelog: add #10812

* changelog: add #10556

* Changelog: add #10668

* Changelog: add #10846

* Changelog: add #10947

* Changelog: add #10962

* Changelog: add #10956

* Changelog: add #10940

* Changelog: add #10934

* Changelog: add #10912

* changelog: add #10866

* changelog: add #10924

* Changelog: add #10936

* Changelog: add #10833

* changelog: add #10867

* Changelog: add #10960

* Changelog: add #10888

* changelog: add #10840

* changelog: add #10972

* Changelog: add #10979

* changelog: add #10909

* Changelog: add #10958

* Changelog: add #10981

* Changelog: add #10564

* Changelog: add #10809

* Changelog: add #10982

* Changelog: add #10706

* Changelog: add #10978

* Changelog: add #10132

* Changelog: add #11022

* Changelog: add #11024

* Changelog: add #10875

* Changelog: add #11030

* Changelog: add #11053

* Changelog: add #10880

* Changelog: add #9359

* Changelog: add #11037

* Update block list

* Changelog: add #11060

* Changelog: add #10755

* changelog: add #11000

* Changelog: add #10786

* Changelog: add #10945

* Changelog: add #10597
@kraftbj kraftbj removed the [Status] Needs Review This PR is ready for review. label May 13, 2019
@jeherve jeherve added the [Feature] Pay with PayPal aka Simple Payments label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dereksmart dereksmart dereksmart approved these changes

@enejb enejb Awaiting requested review from enejb

@roccotripaldi roccotripaldi Awaiting requested review from roccotripaldi

Assignees

@ockham ockham

Labels

[Feature] Pay with PayPal aka Simple Payments [Status] Tested on WP.com Touches WP.com Files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ockham @matticbot @jetpackbot @dereksmart @kraftbj @jeherve @roccotripaldi