Unlaunched sites: Set a blog option of "unlaunched" to sites that are created private#10560
Merged
dereksmart merged 2 commits intomasterfrom Dec 4, 2018
Merged
Conversation
… created private. This will enable us to distinguish sites that are created private from sites that are deliberately private, so that we can show a coming soon page on them and a pre-launch banner. This diff does several things: It sets a blog option of launch-status to unlaunched when users create a site which is private. It enables users to publish posts and pages to sites which have the launch-status blog option, even if their email address is unverified (this is OK because sites which are unlaunched aren't public, so there's no spam concerns, and they can't update the status to be launched without verifying their email address) It returns the launch-status of a site in the API Moves the functionality into a lib so we can use it in multiple places Differential Revision: D19586 This commit syncs r182320-wpcom.
Collaborator
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: January 10, 2019. Generated by 🚫 dangerJS |
jeherve
reviewed
Nov 7, 2018
Member
jeherve
left a comment
There was a problem hiding this comment.
Just a quick question about the merge.
| $response[ $key ] = $this->site->get_quota(); | ||
| break; | ||
| case 'launch_status' : | ||
| $response[ $key ] = $this->site->get_launch_status(); |
Member
There was a problem hiding this comment.
I believe you may have to add get_launch_status() here as well:
https://github.com/Automattic/jetpack/blob/e9c0e0c1a02c07afed00e2c9d47d9b70184e6360/sal/class.json-api-site-base.php
Contributor
|
D21104-code. (newly created revision) |
Contributor
|
D21770-code. (newly created revision) |
jeherve
added a commit
that referenced
this pull request
Jan 3, 2019
* Add first version of the Changelog and testing list for 6.9 * Changelog: add #10710 * changelog: add #10538 * changelog: add #10741 * changelog: add #10749 * changelog: add #10664 * changelog: add #10224 * changelog: add #10788 * Changelog: add #10560 * Chanegelog: add #10812 * changelog: add #10556 * Changelog: add #10668 * Changelog: add #10846 * Changelog: add #10947 * Changelog: add #10962 * Changelog: add #10956 * Changelog: add #10940 * Changelog: add #10934 * Changelog: add #10912 * changelog: add #10866 * changelog: add #10924 * Changelog: add #10936 * Changelog: add #10833 * changelog: add #10867 * Changelog: add #10960 * Changelog: add #10888 * changelog: add #10840 * changelog: add #10972 * Changelog: add #10979 * changelog: add #10909 * Changelog: add #10958 * Changelog: add #10981 * Changelog: add #10564 * Changelog: add #10809 * Changelog: add #10982 * Changelog: add #10706 * Changelog: add #10978 * Changelog: add #10132 * Changelog: add #11022 * Changelog: add #11024 * Changelog: add #10875 * Changelog: add #11030 * Changelog: add #11053 * Changelog: add #10880 * Changelog: add #9359 * Changelog: add #11037 * Update block list * Changelog: add #11060 * Changelog: add #10755 * changelog: add #11000 * Changelog: add #10786 * Changelog: add #10945 * Changelog: add #10597
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will enable us to distinguish sites that are created private from sites that are deliberately private, so that we can show a coming soon page on them and a pre-launch banner.
This diff does several things:
It sets a blog option of launch-status to unlaunched when users create a site which is private.
It enables users to publish posts and pages to sites which have the launch-status blog option, even if their email address is unverified (this is OK because sites which are unlaunched aren't public, so there's no spam concerns, and they can't update the status to be launched without verifying their email address)
It returns the launch-status of a site in the API
Moves the functionality into a lib so we can use it in multiple places
Differential Revision: D19586-code
This commit syncs r182320-wpcom.
Fixes #
Changes proposed in this Pull Request:
Testing instructions:
Proposed changelog entry for your changes: