Skip to content

Connection Banner style enhancements#11053

Merged
oskosk merged 7 commits intomasterfrom
enhance/connection-banner-color
Dec 31, 2018
Merged

Connection Banner style enhancements#11053
oskosk merged 7 commits intomasterfrom
enhance/connection-banner-color

Conversation

@jeffgolenski
Copy link
Copy Markdown
Member

@jeffgolenski jeffgolenski commented Dec 29, 2018 •
edited
Loading

Quick visual enhancements to the connection banner to make it catch people's attention and communicate that it's a step that they need to take to get Jetpack started.

  • Added new alert hot red border to grab people's attention (new color for 2019 branding). Included a header with language to let them know they aren't done yet.
  • Made the banner a little taller so its not missed
  • Added new illustration on first slide (swapped with the image on the last slide)
  • Changed the verbiage a little on first slide. Including "Over 5 million installations" language for credibility

Before:
screen shot 2018-12-29 at 5 31 56 pm

Proposed:

Large screen:
screen shot 2018-12-30 at 12 47 03 pm

Video: https://cloudup.com/cb7miIGguD7

Mobile:
jetpack-connection-banner-after-mobile

Testing instructions:

  • Install + activate jetpack. Do NOT connection to wpcom
  • Navigate to /wp-admin/index/php
  • check out the connection banner

Proposed changelog entry:
none.

@jeffgolenski
First commit: new connection banner style
94c9b1a 
First commit: new connection banner style
@jeffgolenski jeffgolenski added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress labels Dec 29, 2018
@jeffgolenski jeffgolenski self-assigned this Dec 29, 2018
@jeffgolenski jeffgolenski requested review from a team and ebinnion December 29, 2018 22:32
@jeffgolenski jeffgolenski changed the title Connection Banner style enhancements for Connection Banner style enhancements Dec 29, 2018
@jetpackbot
Copy link
Copy Markdown
Collaborator

jetpackbot commented Dec 29, 2018 •
edited
Loading

Fails
🚫

Danger failed to run dangerfile.js.

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Error TypeError

github.api.issues.getMilestones is not a function
TypeError: github.api.issues.getMilestones is not a function
    at _callee$ (dangerfile.js:65:32)
    at tryCatch (/home/travis/build/Automattic/jetpack/node_modules/babel-runtime/node_modules/regenerator-runtime/runtime.js:62:40)
    at Generator.invoke [as _invoke] (/home/travis/build/Automattic/jetpack/node_modules/babel-runtime/node_modules/regenerator-runtime/runtime.js:296:22)
    at Generator.prototype.(anonymous function) [as next] (/home/travis/build/Automattic/jetpack/node_modules/babel-runtime/node_modules/regenerator-runtime/runtime.js:114:21)
    at step (/home/travis/build/Automattic/jetpack/node_modules/babel-runtime/helpers/asyncToGenerator.js:17:30)
    at /home/travis/build/Automattic/jetpack/node_modules/babel-runtime/helpers/asyncToGenerator.js:35:14
    at new Promise (<anonymous>)
    at new F (/home/travis/build/Automattic/jetpack/node_modules/core-js/library/modules/_export.js:36:28)
    at /home/travis/build/Automattic/jetpack/node_modules/babel-runtime/helpers/asyncToGenerator.js:14:12
    at /home/travis/build/Automattic/jetpack/node_modules/danger/distribution/runner/runners/inline.js:84:32

Dangerfile

60|             const firstTuesdayOfMonth = moment().add( 1, 'months' ).startOf( 'month' );
61|             while ( firstTuesdayOfMonth.day() !== 2 ) {
62|                 firstTuesdayOfMonth.add( 1, 'day' );
63|             }
64|             jetpackReleaseDate = firstTuesdayOfMonth.format( 'LL' );
-------------------------------------------^
65|             // Calculate next code freeze date
66|             codeFreezeDate = firstTuesdayOfMonth.subtract( 7, 'd' ).format( 'LL' );
67|         }
68|

Generated by 🚫 dangerJS against f4885f1

@jeffgolenski
Connection banner: adding text to the top of the container
5329c70 
Connection banner: adding text to the top of the container
@jeffgolenski
Connection banner: adding gridiron svg to connection banner
7ee36d9 
Connection banner: adding gridiron svg to connection banner
@jeffgolenski
connection banner: adding new colors, text, and styling
f11576f 
connection banner: adding new colors, text, and styling
@jeffgolenski
connection banner: modding some visual styles
668d2a4 
connection banner: modding some visual styles
@jeffgolenski
Connection banner: content changes to first slide
e8136de 
Connection banner: content changes to first slide
@jeffgolenski jeffgolenski added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Dec 30, 2018
@jeffgolenski jeffgolenski added this to the 6.9 milestone Dec 30, 2018
oskosk
oskosk approved these changes Dec 31, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pushed a few whitespace fixes in f4885f1

@oskosk oskosk added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Dec 31, 2018
@oskosk oskosk merged commit 1ea40f8 into master Dec 31, 2018
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Dec 31, 2018
@oskosk oskosk deleted the enhance/connection-banner-color branch December 31, 2018 14:05
@jeffgolenski
Copy link
Copy Markdown
Member Author

jeffgolenski commented Dec 31, 2018

Thanks @oskosk !

jeherve added a commit that referenced this pull request Jan 3, 2019
@jeherve
Changelog: add #11053
bffbca3
@jeffgolenski jeffgolenski mentioned this pull request Jan 3, 2019
Merged
jeherve added a commit that referenced this pull request Jan 3, 2019
@jeherve
Jetpack 6.9: Changelog and testing list (#10722)
8d91603 
* Add first version of the Changelog and testing list for 6.9

* Changelog: add #10710

* changelog: add #10538

* changelog: add #10741

* changelog: add #10749

* changelog: add #10664

* changelog: add #10224

* changelog: add #10788

* Changelog: add #10560

* Chanegelog: add #10812

* changelog: add #10556

* Changelog: add #10668

* Changelog: add #10846

* Changelog: add #10947

* Changelog: add #10962

* Changelog: add #10956

* Changelog: add #10940

* Changelog: add #10934

* Changelog: add #10912

* changelog: add #10866

* changelog: add #10924

* Changelog: add #10936

* Changelog: add #10833

* changelog: add #10867

* Changelog: add #10960

* Changelog: add #10888

* changelog: add #10840

* changelog: add #10972

* Changelog: add #10979

* changelog: add #10909

* Changelog: add #10958

* Changelog: add #10981

* Changelog: add #10564

* Changelog: add #10809

* Changelog: add #10982

* Changelog: add #10706

* Changelog: add #10978

* Changelog: add #10132

* Changelog: add #11022

* Changelog: add #11024

* Changelog: add #10875

* Changelog: add #11030

* Changelog: add #11053

* Changelog: add #10880

* Changelog: add #9359

* Changelog: add #11037

* Update block list

* Changelog: add #11060

* Changelog: add #10755

* changelog: add #11000

* Changelog: add #10786

* Changelog: add #10945

* Changelog: add #10597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebinnion ebinnion Awaiting requested review from ebinnion

1 more reviewer

@oskosk oskosk oskosk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jeffgolenski jeffgolenski

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Milestone

6.9

Development

Successfully merging this pull request may close these issues.

5 participants

@jeffgolenski @jetpackbot @oskosk @jeherve @matticbot