Widen dash container: changing mast head and content area max widths#10866
Widen dash container: changing mast head and content area max widths#10866
Conversation
Widen dash container: changing mast head and content area max widths to match those of calypso.
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: January 10, 2019. Generated by 🚫 dangerJS |
jeherve
left a comment
There was a problem hiding this comment.
It seems we lost some of the extra space in the header on smaller widths:
vs. in the latest stable:
The problem is the same with the old modules' list (wp-admin/admin.php?page=jetpack_modules);
max-width of container: adjusting for medium screens
|
@jeherve Great find! I've made an adjustment and now the container has plenty of padding no matter the screen size. Video attached: https://cloudup.com/cp3Q8rGuzJy |
keoshi
left a comment
There was a problem hiding this comment.
Looks good in my testing!
One nitpick is with the illustrations in the promo cards that have .jp-apps-card__top img { max-width: 40%; padding-top: 10px; }. That max-width paired with the wider wrapper makes these images take a lot of vertical space.
|
@jeffgolenski One more thing: can we use the default breakpoints instead of fixed values here? jetpack/scss/_utilities/mixins/_breakpoint.scss Lines 18 to 25 in f8078c2 |
|
@keoshi I opted to create a specific breakpoint here because that's where it was needed. With the wp-admin sidebar, the 1250px was needed. I didn't think it warranted creating a new breakpoint in the scss though, since its only used once. 1147px was too small to fix the issue. |
* Add first version of the Changelog and testing list for 6.9 * Changelog: add #10710 * changelog: add #10538 * changelog: add #10741 * changelog: add #10749 * changelog: add #10664 * changelog: add #10224 * changelog: add #10788 * Changelog: add #10560 * Chanegelog: add #10812 * changelog: add #10556 * Changelog: add #10668 * Changelog: add #10846 * Changelog: add #10947 * Changelog: add #10962 * Changelog: add #10956 * Changelog: add #10940 * Changelog: add #10934 * Changelog: add #10912 * changelog: add #10866 * changelog: add #10924 * Changelog: add #10936 * Changelog: add #10833 * changelog: add #10867 * Changelog: add #10960 * Changelog: add #10888 * changelog: add #10840 * changelog: add #10972 * Changelog: add #10979 * changelog: add #10909 * Changelog: add #10958 * Changelog: add #10981 * Changelog: add #10564 * Changelog: add #10809 * Changelog: add #10982 * Changelog: add #10706 * Changelog: add #10978 * Changelog: add #10132 * Changelog: add #11022 * Changelog: add #11024 * Changelog: add #10875 * Changelog: add #11030 * Changelog: add #11053 * Changelog: add #10880 * Changelog: add #9359 * Changelog: add #11037 * Update block list * Changelog: add #11060 * Changelog: add #10755 * changelog: add #11000 * Changelog: add #10786 * Changelog: add #10945 * Changelog: add #10597
Widen dash container: changing mast head and content area max widths to
match those of calypso.
Fixes #9298
Before:
After:
Testing instructions:
Proposed changelog entry for your changes:
"We've made the Jetpack dashboard wider on large screens for a better experience"