Skip to content

4.0 dev#4

Merged
Arpit-24 merged 74 commits intoArpit-24:4.0-modal-savefrom
joomla:4.0-dev
Mar 30, 2019
Merged

4.0 dev#4
Arpit-24 merged 74 commits intoArpit-24:4.0-modal-savefrom
joomla:4.0-dev

Conversation

@Arpit-24
Copy link
Copy Markdown
Owner

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

laoneo and others added 30 commits June 28, 2018 20:43
* Deprecate editor form field save function

* Revert invalid change

* Blank
* Add link to edit categories and show parent category

* Check for ROOT category earlier

* Fix wrong variable

* Put the query into the model

* Check if category is the root or not

* Check Permissions to edit category or parent category

* Fix wrong article title

* Add suggested change for the queries

* Fix Code Style

* Fix Check for ROOT Category

* Add category level check

* Add Check for Parent Category Level

* Consider rtl languages

* Code Style

* Use html entities

* Fix Code Style

* Code Style
Add Feature to Featured Articles Manager

* Code Style

* Use another method
* initial commit

* Add back showlabel for the render options
Remove label class for render options

* Moved field to the right position
Language String changed

* Add back label output class (first commit)

* Fix Codestyle

* Add label render class in contact

* Change Field type to note
Remove strong tag from language string

* Add missing intent

* Alphabetize keys
Typo in Azure installation file
thanks @SharkyKZ
* Log failed login action

* Add login failed language item

* Fix typo
* Make links in action logs notification email clickable

* Fix $linkMode
* Fix IP filtering
Fix CSV export
Improve list layout

* Renaming addLogsToDb to addLog

* Fixing language string
Do not allow a different email address for an authenticated user
joomdonation and others added 28 commits July 12, 2018 20:03
* Log user registration action

* Add language item
* Changed icon of Privacy Dashboard

* Changed icon of Privacy Dashboard

* Changed icon of Privacy Dashboard

* Changed icon of Privacy Dashboard

* Changed icon of Privacy Dashboard
…as plugin (#185)

* make sure the language of com_privacy is loaded as it is not running as plugin

* Update helper.php

* Update actionlogs.php
…221)

* Changing order of calls to load translation files.

* Adding ActionlogsHelper::loadTranslationFiles and removing translateExtensionName
* Adding consent to terms & conditions to actionlog

* Language string style
* Adding Actionlog Privacy plugin

* Fixing SQL default timestamps
* Adding logging for global configuration

* Updating table name and adding onApplicationBeforeSave event
* Adding UTC timezone to filename for export

* Forceing FS friendly formatting
@Arpit-24 Arpit-24 merged commit 13e1e3f into Arpit-24:4.0-modal-save Mar 30, 2019
wilsonge pushed a commit that referenced this pull request Apr 12, 2019
* This is a combination of 8 commits.
This is the 1st commit message:

> First WIP version of supporting nested subforms.

This is the commit message #2:

> Fix nested subforms not getting correct name attribute on input fields.

This is the commit message #3:

> Fix subform rows having invalid index, fix small typo.

This is the commit message #4:

> Replace the unique subform id via random bytes by just an increasing integer in the fields type rendering process.

This is the commit message #5:

> Implement feedback from PR at Joomla;
> - Use a <template> HTML element for the template of the subform rows,
>   not a url encoded string inside of a <script> element.
> - Fix code style errors reported by phpcs.
> - Make the fixing of the unique attributes (name, id, etc) of input elements
>   of nested subform rows more errorprone, using the same method as the main
>   subform row.
> - Manually add a minified version of the javascript file.

This is the commit message #6:

> Fix failing javascript tests due to changed structure of subform repeatable template container.

This is the commit message #7:

> Change subform repeatable javascript test to correctly check on
> 0-indexed rows, previously they have been 1-indexed.

This is the commit message #8:

> Fix a problem where multi-level subforms on the same level doesnt trigger their template correctly.
> Additionally added a note why the fixScripts() method is broken and how it could get better.

* Commit code styling errors and add an aria label for the outermost 'add' button.

* Fix double group-add button on repeatable subform type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.