Skip to content

merge#6

Merged
Arpit-24 merged 13 commits intoArpit-24:4.0-modal-savefrom
joomla:4.0-dev
Apr 5, 2019
Merged

merge#6
Arpit-24 merged 13 commits intoArpit-24:4.0-modal-savefrom
joomla:4.0-dev

Conversation

@Arpit-24
Copy link
Copy Markdown
Owner

@Arpit-24 Arpit-24 commented Apr 5, 2019

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

SharkyKZ and others added 13 commits July 16, 2018 17:30
* [mod_articles_category] Grouping by tags

* CS, argument default value
* [NEW FEATURE] Adding Edit Associations Toolbar

* cs

* cs

* improving after comments

* Force saving before redirect to multilingual associations

* Save as first action.

* Changing toolbar as required

* cs

* select target when only 2 content languages

* cs trying to make drone happy...

* small simplification

* oops

* cs
* Allow custom group for showon

* Improve support custom group for showon

* Use  instead reuse
PR for #24468

The label existed but it was pointing to an id that didnt exist

This simple PR adds the ID
@Arpit-24 Arpit-24 merged commit 293c974 into Arpit-24:4.0-modal-save Apr 5, 2019
wilsonge pushed a commit that referenced this pull request Apr 12, 2019
* This is a combination of 8 commits.
This is the 1st commit message:

> First WIP version of supporting nested subforms.

This is the commit message #2:

> Fix nested subforms not getting correct name attribute on input fields.

This is the commit message #3:

> Fix subform rows having invalid index, fix small typo.

This is the commit message #4:

> Replace the unique subform id via random bytes by just an increasing integer in the fields type rendering process.

This is the commit message #5:

> Implement feedback from PR at Joomla;
> - Use a <template> HTML element for the template of the subform rows,
>   not a url encoded string inside of a <script> element.
> - Fix code style errors reported by phpcs.
> - Make the fixing of the unique attributes (name, id, etc) of input elements
>   of nested subform rows more errorprone, using the same method as the main
>   subform row.
> - Manually add a minified version of the javascript file.

This is the commit message #6:

> Fix failing javascript tests due to changed structure of subform repeatable template container.

This is the commit message #7:

> Change subform repeatable javascript test to correctly check on
> 0-indexed rows, previously they have been 1-indexed.

This is the commit message #8:

> Fix a problem where multi-level subforms on the same level doesnt trigger their template correctly.
> Additionally added a note why the fixScripts() method is broken and how it could get better.

* Commit code styling errors and add an aria label for the outermost 'add' button.

* Fix double group-add button on repeatable subform type.
infograf768 pushed a commit that referenced this pull request Apr 20, 2019
…or the joomla core Fixes #6 (joomla#12)

* inital port to the joomla core

* add com_mailto as supported form (requires joomla#20265)

* install & update SQL & mark as core extension

* bump version to trigger drone

* new line & drone

* implement consentbox text based on the work by @brianteeman thanks!

* thanks drone

* new line

* doc block

* rename plugin to ConfirmConsent

* fix inine comments

* typo thanks @sandewt

* implement LanguageAssociations thanks @infograf768

* fix check

* move the update sql's to its own files to avoid merge conflicts

* fix postgresql file

* thanks @infograf768

* fix problems fund by @infograf768

* extend description

* implement modal support thanks @infograf768

* new text thanks @brianteeman

* drone

* add missing period

* thanks @brianteeman

* thanks @Sandra97

* remove Scalar types

* fix association

* fix comments thanks @sandewt

* class var type

* fix language string and us another namesprace

* the 2nd field is package_id

* the 2nd field is package_id

* the 2nd field is package_id

* add com_privacy.request
infograf768 pushed a commit that referenced this pull request Apr 20, 2019
infograf768 pushed a commit that referenced this pull request May 14, 2019
…ngle query, reduce 20, 50, 100 queries (page limit) to 1 (joomla#22117)

* Categoy manager, get all counters via single query

* Replace countItems() and countTagItems() methods with a reusuable counterRelations() method in ContentHelper class

* CS

* Since deploy version

* Better ordering for states to property names array

* Coding style (#6)

* Removed unneeded  parameter from counting methods

* CS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants