Skip to content

[4.0] [Backend Template] Toolbar Dropdown made consistent#24447

Merged
wilsonge merged 3 commits intojoomla:4.0-devfrom
Harshil99:consistentDropdown
Apr 5, 2019
Merged

[4.0] [Backend Template] Toolbar Dropdown made consistent#24447
wilsonge merged 3 commits intojoomla:4.0-devfrom
Harshil99:consistentDropdown

Conversation

@Harshil99
Copy link
Copy Markdown
Contributor

Summary of Changes

Changed class of some dropdowns to toolbar-status-group as that in other toolbar dropdowns.

Testing Instructions

Make these changes, compile using npm ci.

Expected result

11

Actual result

22

Documentation Changes Required

No.

@Harshil99
Copy link
Copy Markdown
Contributor Author

@brianteeman Dropdowns are now consistent everywhere as you have asked in #24377 (comment) . Also no need of PR #24377 .

@Harshil99
Copy link
Copy Markdown
Contributor Author

Please review. @C-Lodder @infograf768

@ghost
Copy link
Copy Markdown

ghost commented Apr 4, 2019

@wilsonge which of the PR #24377 or this one should stay open?

@ghost ghost changed the title [4.0] Toolbar Dropdown made consistent [4.0] [Backend Template] Toolbar Dropdown made consistent Apr 5, 2019
@ghost ghost added J4 Issue and removed J4 Issue labels Apr 5, 2019
@wilsonge wilsonge merged commit d4e4768 into joomla:4.0-dev Apr 5, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Apr 5, 2019
@Harshil99 Harshil99 deleted the consistentDropdown branch April 8, 2019 14:10
@ghost ghost removed the J4 Issue label Apr 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants