Skip to content

[4.0] fix toolbar button#24377

Closed
hardik-codes wants to merge 1 commit intojoomla:4.0-devfrom
hardik-codes:toolbarButton2
Closed

[4.0] fix toolbar button#24377
hardik-codes wants to merge 1 commit intojoomla:4.0-devfrom
hardik-codes:toolbarButton2

Conversation

@hardik-codes
Copy link
Copy Markdown
Contributor

The drop-down items of change status button in com_users was not visible on hover. This PR fixes that.

Summary of Changes

Made the drop-down items visible on hover

Testing Instructions

After applying the patch, run npm run build:css then
Go to Users => Manage
Select any user
Click on the change status button

Before Patch

Screenshot from 2019-03-27 17-44-58

After patch

Screenshot from 2019-03-27 17-43-16

Documentation Changes Required

None

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Mar 27, 2019
@brianteeman
Copy link
Copy Markdown
Contributor

Is there a reason that the styling of the menu items here is different to com_content, fields, categories, menus etc

Also com_banners and contacts are styled the same as com_users (and maybe others)

All the change status dropdowns should be consistently designed

@Harshil99
Copy link
Copy Markdown
Contributor

Harshil99 commented Apr 1, 2019

@brianteeman I am working on making all status dropdown consistent in design. Right now i am designing all of them like that of fields. Is it ok ?

@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Apr 5, 2019

Closing in favour of #24447

@wilsonge wilsonge closed this Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

J4 Issue NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants