[mod_articles_category] Option to group by tags#21083
Merged
mbabker merged 2 commits intojoomla:3.9-devfrom Jul 16, 2018
SharkyKZ:modArticlesCategoryGroupTags
Merged
[mod_articles_category] Option to group by tags#21083mbabker merged 2 commits intojoomla:3.9-devfrom SharkyKZ:modArticlesCategoryGroupTags
mbabker merged 2 commits intojoomla:3.9-devfrom
SharkyKZ:modArticlesCategoryGroupTags
Conversation
|
I have tested this item ✅ successfully on d04ede4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21083. |
Quy
reviewed
Jul 12, 2018
| case 'category_title' : | ||
| $list = ModArticlesCategoryHelper::groupBy($list, $article_grouping, $article_grouping_direction); | ||
| break; | ||
| case 'tags': |
Quy
reviewed
Jul 13, 2018
| case 'tags' : | ||
| $list = ModArticlesCategoryHelper::groupByTags($list, $article_grouping_direction); | ||
| break; | ||
| default: |
Contributor
|
I have tested this item ✅ successfully on 1887d48 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21083. |
1 similar comment
|
I have tested this item ✅ successfully on 1887d48 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21083. |
|
Ready to Commit after two successful tests. |
This was referenced Aug 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #18458 .
Summary of Changes
This adds an option to group articles by tags.
Testing Instructions
Create
Articles - Categorymodule. SetArticle GroupingtoTags.Expected result
Articles grouped by tags. Articles without tags are placed in
Untaggedgroup.Documentation Changes Required
New option added.