New Feature: Allows custom group for showon by mvanvu · Pull Request #18937 · joomla/joomla-cms

mvanvu · 2017-12-01T15:53:57Z

Pull Request for Issue # .

Summary of Changes

By default the showon feature detects the group from base fields. This PR comes to build for developer can specify the field which from the other group.

Testing Instructions

Eg. I want to show the article title when the value of field jform[attribs][show_title] is show.

Before PR: no way to do (maybe, not sure)

After PR: Article title only show when the show title options is show.

Change the file /administrator/components/com_content/models/forms/article.xml line 21
From

<field 
			name="title" 
			type="text" 
			label="JGLOBAL_TITLE"
			description="JFIELD_TITLE_DESC"
			class="input-xxlarge input-large-text"
			size="40"
			required="true" 
		/>

To

<field 
			name="title" 
			type="text" 
			label="JGLOBAL_TITLE"
			description="JFIELD_TITLE_DESC"
			class="input-xxlarge input-large-text"
			size="40"
			required="true" 
                        showon="attribs.show_title:1"
		/>

The key changing here is showon="attribs.show_title:1".
The custom group should only apply for the first time, for Eg: we need to expand the condition to show_title is empty OR show_title = 1.

`showon="attribs.show_title:[OR]show_title:1"

`

GeraintEdwards · 2017-12-03T10:21:54Z

I have tested this item ✅ successfully on 66dcdb2

This works fine - a logical extension of showon. I have been grappling with an issue like this for subforms so the idea could be quite useful

By the way you could use

showon="attribs.show_title:1,"

Instead of the more confusing version you have. It basically allows blank or 1 values to match

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18937.}

…taging

mvanvu · 2017-12-05T01:48:59Z

Now the show on group is improved overall.
For eg: content title showon attribs.show_title:1[OR]images.float_intro:left

GeraintEdwards · 2017-12-05T10:50:58Z

libraries/src/Form/FormHelper.php

+				}
+				else
+				{
+					$showOnParts = explode('.', $showOnPartBlocks[0]);


You are setting $showOnParts but this is an array your are running through at line 472 so this is not a good idea.

You should use a different variable name here

Thanks for your review. This is my fault.

ghost · 2017-12-09T09:14:29Z

I have tested this item ✅ successfully on 5a5eb72

Test as decribed in first Comment.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18937.}

ghost · 2017-12-09T09:15:55Z

@GeraintEdwards can you please retest?

mvanvu · 2018-01-26T06:26:36Z

@franz-wohlkoenig If there is not any problem I think it should be RTC.

ghost · 2018-01-26T06:53:31Z

@mvanvu i can't decide as there is only one successfully Test, Release Lead can. So best is to get a second Test.

grhcj · 2018-01-26T16:28:03Z

I have not tested this item.

Du you expect the title field to be bigger than the alias field?

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18937.}

infograf768 · 2018-01-30T09:33:03Z

Changed PR title to New Feature

coolcat-creations · 2018-07-17T06:31:12Z

What is missing here for me is that this showon should also consider the global value. I have Global (Show) but the Alias is not shown.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18937.}

mvanvu · 2018-07-17T07:30:54Z

@coolcat-creations as suggested from @GeraintEdwards just like this showon="attribs.show_title:1,"

coolcat-creations · 2018-07-17T07:39:30Z

I have tested this item ✅ successfully on 5a5eb72

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18937.}

coolcat-creations · 2018-07-17T07:39:34Z

Right, sorry - was not obvious to me that it reffered to global :)

ghost · 2018-07-17T08:26:25Z

Ready to Commit after two successful tests.

Allow custom group for showon

66dcdb2

joomla-cms-bot added the PR-staging label Dec 1, 2017

Vu Mai added 2 commits December 5, 2017 08:14

Merge branch 'staging' of https://github.com/joomla/joomla-cms into s…

71f8a16

…taging

Improve support custom group for showon

907d568

GeraintEdwards reviewed Dec 5, 2017

View reviewed changes

Use instead reuse

5a5eb72

infograf768 changed the title ~~Allows custom group for showon~~ New Feature: Allows custom group for showon Jan 30, 2018

joomla-cms-bot added RTC This Pull Request is Ready To Commit and removed RTC This Pull Request is Ready To Commit labels Jul 17, 2018

Uh oh!

Conversation

mvanvu commented Dec 1, 2017 • edited by joomla-cms-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Testing Instructions

Uh oh!

GeraintEdwards commented Dec 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mvanvu commented Dec 5, 2017

Uh oh!

GeraintEdwards Dec 5, 2017

Choose a reason for hiding this comment

Uh oh!

mvanvu Dec 5, 2017

Choose a reason for hiding this comment

Uh oh!

ghost commented Dec 9, 2017 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Dec 9, 2017

Uh oh!

mvanvu commented Jan 26, 2018

Uh oh!

ghost commented Jan 26, 2018

Uh oh!

grhcj commented Jan 26, 2018

Uh oh!

infograf768 commented Jan 30, 2018

Uh oh!

coolcat-creations commented Jul 17, 2018

Uh oh!

mvanvu commented Jul 17, 2018

Uh oh!

coolcat-creations commented Jul 17, 2018

Uh oh!

coolcat-creations commented Jul 17, 2018

Uh oh!

ghost commented Jul 17, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mvanvu commented Dec 1, 2017 •

edited by joomla-cms-bot

Loading

GeraintEdwards commented Dec 3, 2017 •

edited

Loading

ghost commented Dec 9, 2017 •

edited by ghost

Loading