[NEW FEATURE] Adding Edit Associations Toolbar by infograf768 · Pull Request #21022 · joomla/joomla-cms

infograf768 · 2018-07-09T10:10:16Z

Pull Request for Issue #21003

Summary of Changes

Adding a new toolbar for items which can be associated.
The toolbar button redirects to the side by side Multilingual associations component.
Changes include new methods in FormController as in AdminModel.
And the new toolbar button for each view concerned.

Testing Instructions

Install a multilngual site. Make sure Associations are set.
Edit any

article
contact
menu item
newsfeed
category

Click on the new Edit Associations Toolbar button. Example:

You should be redirected to the side by side.

If the item is set to ALL languages, a Notice will display.

Documentation Changes Required

I guess so. Target is 3.9.x

@Bakual @rdeutz @alikon

infograf768 · 2018-07-09T10:15:55Z

Looks like this needs some cs corrections to make drone happy...
Trying now.

Quy · 2018-07-09T10:43:06Z

libraries/src/MVC/Model/AdminModel.php

+		}
+		else
+		{
+			if ($data['language'] === '*')


Minor suggestion. Lines 1579-1596 don’t need to be in the else statement.

Indeed, will correct.

brianteeman · 2018-07-09T10:41:38Z

administrator/language/en-GB/en-GB.ini

 JGLOBAL_ARTICLE_ORDER_LABEL="Article Order"
 JGLOBAL_ARTICLES="Articles"
 JGLOBAL_ASSOC_NOT_POSSIBLE="To define associations, please make sure the item language is not set to 'All'."
+JGLOBAL_ASSOCIATIONS_NEW_ITEM_WARNING="To edit associations, first save the item."


==> To create an association, first save the item.

But can this actually be displayed as the button isnt presnt until you have saved the item

This is just a security warning in case something goes wrong. Will change string as indeed when not saved one can't edit any assoc.

brianteeman · 2018-07-09T10:42:30Z

administrator/language/en-GB/en-GB.ini

 JTOOLBAR_DISABLE="Disable"
 JTOOLBAR_DUPLICATE="Duplicate"
 JTOOLBAR_EDIT="Edit"
+JTOOLBAR_EDIT_ASSOCIATIONS="Edit Associations"


It is both edit and create so let's just say "Associations"

I have been wondering about that. The issue is that we already have an Associations Tab.

brianteeman · 2018-07-09T10:43:44Z

Other than my language string comments - this works well

brianteeman · 2018-07-09T10:54:43Z

The check to ensure that the language is not "all" doesnt check that it has actually been saved with a set language.

infograf768 · 2018-07-09T10:57:33Z

hmm
this needs some thought. After siesta.

brianteeman · 2018-07-09T11:09:55Z

I have tested this item 🔴 unsuccessfully on f4e6698

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21022.}

infograf768 · 2018-07-09T12:33:50Z

The issue is interesting as we have the same behavior when using the associations Tab (through js).
In that last case though, after choosing one or multiple associations we DO save the item, preventing this problem.
Let's see what we can do here.

infograf768 · 2018-07-09T12:41:25Z

@brianteeman
Please test again. It works fine now here.

infograf768 · 2018-07-09T12:54:13Z

Note: the multilingual manager may not show the item once target is saved and Close button has been used. But the item IS saved with the selected language and correctly associated to the target. Just select the right type of item and language.
One way to see that is to look at the Associations column in the mulilingual manager or the item manager itself (whatever item concerned).

micker · 2018-07-09T14:09:44Z

same return, in fact that a great addition ! we win a lot of time thanks !

infograf768 · 2018-07-09T16:03:48Z

@micker
please mark your test ok on https://issues.joomla.org/tracker/joomla-cms/21022

infograf768 · 2018-07-10T04:30:37Z

@brianteeman
The issue you described in #21022 (comment) is now solved.
Please test again.

micker · 2018-07-10T07:49:28Z

Tested its ok for me

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21022.}

ghost · 2018-07-10T08:31:14Z

at Issue Tracker Test of @micker is shown as successfully. I altered it too but it isn't shown here.

infograf768 · 2018-07-10T08:34:15Z

at Issue Tracker Test of @micker is shown as successfully. I altered it too but it isn't shown here.

Yes, I had marked it as successful as he did not do it really, but we have an issue.
We also have an issue with Travis which was working Ok before.

brianteeman · 2018-07-10T08:44:07Z

The issue I reported has been resolved.

BUT I found another one when "editing" associations.

When I open an item that is already associated and then select "edit associations" I expected to be redirected to com_associations with the item AND its association open but it is not.

Thinking about solving this I can see that on a bilingual site what I described would be the expected behaviour but it wouldnt be possible on a site with more than two languages.

So it can only be resolved, imho, by changing the expectation of clicking on the button "edit associations". Perhaps just saying "associations" on the button will do that.

brianteeman · 2018-07-10T09:09:22Z

This can't be expected as the Target Language is not set yet.

I was referring to editing an item that already had an association created.

Quy · 2018-07-10T12:48:56Z

administrator/language/en-GB/en-GB.ini

 JTOOLBAR_DISABLE="Disable"
 JTOOLBAR_DUPLICATE="Duplicate"
 JTOOLBAR_EDIT="Edit"
+JTOOLBAR_ASSOCIATIONS="Associations"


Please sort key in alpha order.

doing it now. Thanks

Quy · 2018-07-10T12:51:09Z

libraries/src/MVC/Model/AdminModel.php

+		if ($this->text_prefix === 'COM_CATEGORIES')
+		{
+			$extension        = $app->input->get('extension', 'com_content');
+			$this->typeAlias  = $extension . '.category';


Remove extra space before =

micker · 2018-07-10T13:01:11Z

sorry i don't find how to set tested ok ... only in texte ... newbie lol

done

infograf768 · 2018-07-10T13:28:07Z

@brianteeman
I have improved this code IF we have only 2 Content Languages.
What will happen is the following:

It will load directly an eventual associated item in the side by side.
If no association it will already select the target language in the side by side.

It is obviously impossible to do the same if we have more than 2 content languages

@micker
This has to be tested again with this specific case.

brianteeman · 2018-07-10T13:34:35Z

@infograf768 awesome. If not already merged I will test tomorrow

Quy · 2018-07-10T23:15:34Z

libraries/src/MVC/Model/AdminModel.php

+				$lang_code[] = $language->lang_code;
+			}
+
+			$refLang       = array($data['language']);


Remove spaces before =

done. thanks.

jreys · 2018-07-11T19:50:50Z

I have tested this item ✅ successfully on 0db5e28

Works as expected now :)

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21022.}

infograf768 · 2018-07-12T05:41:46Z

@jreys Thanks for testing.

Needs one more test. @micker @brianteeman

micker · 2018-07-12T08:23:55Z

tested ✅ successfully on 0db5e28

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21022.}

ghost · 2018-07-12T09:35:52Z

Ready to Commit after two successful tests.

ghost · 2018-07-12T09:36:55Z

why was successfully Test of @micker not shown at Issue Tracker (have altered Test now)?

micker · 2018-07-12T10:22:14Z

@franz-wohlkoenig sorry i am a newbie on tracker how i can do this

ghost · 2018-07-12T12:19:00Z

@micker this was not to you, it was a Question on People knowing more than me how this could be (as similar happen a few Days ago).

On your Question as Example of this PR:

Please mark your Test as successfully:

open Issue Tracker
Login with your github-Account
Click on blue "Test this"-Button above Authors-Picture
mark your Test as successfully
hit "submit test result"

ghost · 2018-07-12T12:19:46Z

@micker before i forget: Thanks for your Work.

[NEW FEATURE] Adding Edit Associations Toolbar

1c463fa

infograf768 requested a review from brianteeman as a code owner July 9, 2018 10:10

joomla-cms-bot added Language Change This is for Translators PR-staging labels Jul 9, 2018

infograf768 mentioned this pull request Jul 9, 2018

Better translation workflow #21003

Closed

infograf768 added 2 commits July 9, 2018 12:24

cs

0feef18

cs

a91d0a2

infograf768 added this to the Joomla 3.9.0 milestone Jul 9, 2018

Quy reviewed Jul 9, 2018

View reviewed changes

brianteeman previously requested changes Jul 9, 2018

View reviewed changes

brianteeman added the Documentation Required label Jul 9, 2018

improving after comments

f4e6698

Force saving before redirect to multilingual associations

1ad159e

Save as first action.

53a6de1

Changing toolbar as required

06f767a

Quy reviewed Jul 10, 2018

View reviewed changes

infograf768 added 2 commits July 10, 2018 15:17

cs

81414f9

select target when only 2 content languages

854ef85

cs trying to make drone happy...

9422c3f

infograf768 added 2 commits July 10, 2018 16:31

small simplification

e1c751c

oops

5b7542c

Quy reviewed Jul 10, 2018

View reviewed changes

cs

0db5e28

joomla-cms-bot removed this from the Joomla 3.9.0 milestone Jul 12, 2018

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 12, 2018

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 16, 2018

infograf768 deleted the edit_assoc_toolbar branch July 17, 2018 05:24

zero-24 mentioned this pull request Aug 29, 2018

[3.9] [NEW FEATURE] Adding Edit Associations Toolbar joomlagerman/joomla#452

Closed

This was referenced Sep 13, 2018

[staging][fix] An admin menu item can't be associated #22175

Closed

Fix display of Associations toolbar when editing a custom admin menu item #22210

Merged

infograf768 mentioned this pull request Dec 14, 2019

[4.0] Associations UI #27256

Closed

Uh oh!

Conversation

infograf768 commented Jul 9, 2018 • edited by joomla-cms-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Testing Instructions

Documentation Changes Required

Uh oh!

infograf768 commented Jul 9, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brianteeman commented Jul 9, 2018

Uh oh!

brianteeman commented Jul 9, 2018

Uh oh!

infograf768 commented Jul 9, 2018

Uh oh!

brianteeman commented Jul 9, 2018

Uh oh!

infograf768 commented Jul 9, 2018

Uh oh!

infograf768 commented Jul 9, 2018

Uh oh!

infograf768 commented Jul 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

micker commented Jul 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

infograf768 commented Jul 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

infograf768 commented Jul 10, 2018

Uh oh!

micker commented Jul 10, 2018

Uh oh!

ghost commented Jul 10, 2018 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

infograf768 commented Jul 10, 2018

Uh oh!

brianteeman commented Jul 10, 2018

Uh oh!

brianteeman commented Jul 10, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

micker commented Jul 10, 2018

Uh oh!

infograf768 commented Jul 10, 2018

Uh oh!

brianteeman commented Jul 10, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jreys commented Jul 11, 2018

Uh oh!

infograf768 commented Jul 12, 2018

Uh oh!

micker commented Jul 12, 2018

Uh oh!

infograf768 commented Jul 9, 2018 •

edited by joomla-cms-bot

Loading

infograf768 commented Jul 9, 2018 •

edited

Loading

micker commented Jul 9, 2018 •

edited

Loading

infograf768 commented Jul 9, 2018 •

edited

Loading

ghost commented Jul 10, 2018 •

edited by ghost

Loading