Skip to content

[4.0] com_finder [a11y]#24477

Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom
brianteeman:com_finder
Apr 5, 2019
Merged

[4.0] com_finder [a11y]#24477
wilsonge merged 1 commit intojoomla:4.0-devfrom
brianteeman:com_finder

Conversation

@brianteeman
Copy link
Copy Markdown
Contributor

PR for #24468

The label existed but it was pointing to an id that didnt exist

This simple PR adds the ID

PR for joomla#24468

The label existed but it was pointing to an id that didnt exist

This simple PR adds the ID
@zwiastunsw
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on d0d226c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24477.

1 similar comment
@Hackwar
Copy link
Copy Markdown
Member

Hackwar commented Apr 4, 2019

I have tested this item ✅ successfully on d0d226c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24477.

@brianteeman
Copy link
Copy Markdown
Contributor Author

@zero-24 please fix rips

@ghost ghost removed the PR-4.0-dev label Apr 4, 2019
@ghost
Copy link
Copy Markdown

ghost commented Apr 4, 2019

Status "Ready To Commit".

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 4, 2019
@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented Apr 4, 2019

@brianteeman
Copy link
Copy Markdown
Contributor Author

@zero-24 still fails

@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented Apr 4, 2019

Finally rips is happy 👍

@brianteeman
Copy link
Copy Markdown
Contributor Author

Thanks

@ghost ghost added the J4 Issue label Apr 4, 2019
@wilsonge wilsonge merged commit 27371ee into joomla:4.0-dev Apr 5, 2019
@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Apr 5, 2019

Thanks!

@joomla-cms-bot joomla-cms-bot added PR-4.0-dev and removed RTC This Pull Request is Ready To Commit labels Apr 5, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Apr 5, 2019
@brianteeman
Copy link
Copy Markdown
Contributor Author

Thanks.

@brianteeman brianteeman deleted the com_finder branch April 5, 2019 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants