Skip to content

4.0 dev#7

Merged
Arpit-24 merged 19 commits intoArpit-24:4.0-modal-savefrom
joomla:4.0-dev
Apr 6, 2019
Merged

4.0 dev#7
Arpit-24 merged 19 commits intoArpit-24:4.0-modal-savefrom
joomla:4.0-dev

Conversation

@Arpit-24
Copy link
Copy Markdown
Owner

@Arpit-24 Arpit-24 commented Apr 6, 2019

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

infograf768 and others added 19 commits July 31, 2018 10:59
* modify installer to allow additional query params

`Joomla\CMS\Installer\Adapter\ComponentAdapter` should allow (at a minimum) the
same subset of query parameters for primary admin menu items that is allowed for
submenu items.

If desired, this can be expanded to allow full `link` override in the manifest
file like currently possible for submenu items.

* remove unnecessary parameters as requested
#19467)

* Add an option to pagination to not generate URL with limitstart=0

* Change variable name and add more views

* Fix pagination default behaviour and add unit tests

* Add pagination hideEmptyLimitstart option to com_tags/tag

* Change  to

* Fix unit tests for 3.9
* Add an option to defer writing logs.

* Fix some CS issues e.g. spaces to tabs :)

* Pass the tests

JLogEntry -> LogEntry
JFile -> \JFile

* Unit tests for JLogLoggerFormattedText defer option
@Arpit-24 Arpit-24 merged commit 0453d1a into Arpit-24:4.0-modal-save Apr 6, 2019
wilsonge pushed a commit that referenced this pull request Apr 12, 2019
* This is a combination of 8 commits.
This is the 1st commit message:

> First WIP version of supporting nested subforms.

This is the commit message #2:

> Fix nested subforms not getting correct name attribute on input fields.

This is the commit message #3:

> Fix subform rows having invalid index, fix small typo.

This is the commit message #4:

> Replace the unique subform id via random bytes by just an increasing integer in the fields type rendering process.

This is the commit message #5:

> Implement feedback from PR at Joomla;
> - Use a <template> HTML element for the template of the subform rows,
>   not a url encoded string inside of a <script> element.
> - Fix code style errors reported by phpcs.
> - Make the fixing of the unique attributes (name, id, etc) of input elements
>   of nested subform rows more errorprone, using the same method as the main
>   subform row.
> - Manually add a minified version of the javascript file.

This is the commit message #6:

> Fix failing javascript tests due to changed structure of subform repeatable template container.

This is the commit message #7:

> Change subform repeatable javascript test to correctly check on
> 0-indexed rows, previously they have been 1-indexed.

This is the commit message #8:

> Fix a problem where multi-level subforms on the same level doesnt trigger their template correctly.
> Additionally added a note why the fixScripts() method is broken and how it could get better.

* Commit code styling errors and add an aria label for the outermost 'add' button.

* Fix double group-add button on repeatable subform type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants