[3.9] modify installer to allow additional query params#21309
[3.9] modify installer to allow additional query params#21309mbabker merged 3 commits intojoomla:3.9-devfrom clayfreeman:3.9-dev
Conversation
`Joomla\CMS\Installer\Adapter\ComponentAdapter` should allow (at a minimum) the same subset of query parameters for primary admin menu items that is allowed for submenu items. If desired, this can be expanded to allow full `link` override in the manifest file like currently possible for submenu items.
|
I can see why you would want to allow task/view as you described in your issue (although don't feel strongly about it). However neither act nor sub are things used in core therefore I definitely am against them being magically whitelisted when they have no definition. |
|
@wilsonge I've stripped down the list of allowed parameters. Please see my revision. |
|
I'm not quite sure why the AppVeyor build failed; logically there was no difference from that merge commit. Regardless, is there an update on this? |
|
@clayfreeman next this PR needs two sucessfully Tests. |
|
By Joomla developers or community members?
I have been running this patch for days with no issue.
… On Jul 31, 2018, at 10:53 PM, Franz Wohlkönig ***@***.***> wrote:
@clayfreeman next this PR needs two sucessfully Tests.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Everyone can test (Test by PR-Creator doesn't count as its expected that he test before create Pull Request). Edit: Its helpful to give Instructions for Tester in the PR, a Link to an Issue without Instructions isn't helpful to know what to test. |
|
Changed Title to show its about 3.9. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21309. |
All patches must be tested/reviewed by at least two people other than the person who submitted the pull request. |
|
I have tested this item ✅ successfully on adf71c7. |
|
I have also tested this item ✅ successfully on adf71c7. |
|
Ready to Commit after two successful tests. |
|
Thankyou for your first contribution to the CMS! |
Is your feature request related to a problem? Please describe.
Components are unable to specify additional query parameters when defining primary admin menu items in the manifest file. Submenu items, however, are able to specify additional query parameters.
Describe the solution you'd like
Patch this file to allow additional query parameters as specified in the component manifest, similar to how it is done for submenu items. See the changes in this pull request to apply the patch and test it.
Additional context
It should be possible to build components without the use of a "generic" controller that defines a default view. Menu items should be able to specify the
taskandviewquery parameters so that there is no ambiguity as to which controller and view class should be used.Example
taskandviewcan now be set in the primary menu item so that the default administration controller doesn't have to be used for the primary menu item.For a component
com_blah, the above code example will create a menu item that points toindex.php?option=com_blah&task=test.display&view=test. This means thatBlahControllerTest,BlahModelTestandBlahViewTestwill be used to handle the request as opposed to the generic, component-wideBlahControllerand itsBlahView$default_viewclass.