Skip to content

Patch #207#208

Closed
amh-mw wants to merge 1 commit intojoomla:masterfrom
amh-mw:master
Closed

Patch #207#208
amh-mw wants to merge 1 commit intojoomla:masterfrom
amh-mw:master

Conversation

@amh-mw
Copy link
Copy Markdown

@amh-mw amh-mw commented May 14, 2012

Add imports necessary for joomla-cms #207

@realityking
Copy link
Copy Markdown
Contributor

Could you open an issue on the tracker for this? Thanks.

@amh-mw
Copy link
Copy Markdown
Author

amh-mw commented Jun 1, 2012

@elinw
Copy link
Copy Markdown
Contributor

elinw commented Jun 2, 2012

Wouldn't it be better to move these to the cms folder than to have a cms specific modification in the joomla folder?

@realityking
Copy link
Copy Markdown
Contributor

The fix isn't so much CMS specific than already fixed in the platform. Just in a different way we probably don't wanna do for 2.5.x (these classes are now autoloadable in the platform)

@elinw
Copy link
Copy Markdown
Contributor

elinw commented Jun 2, 2012

That's what I'm saying I think. Rather than modify the CMS version of the platform why don't we add to cms? I think we should try to keep thing as clean as possible.

@realityking
Copy link
Copy Markdown
Contributor

Define clean? If you mean 11.4 - well than I should probably not backport all that stuff from the platform ;)

Seriously there's no harm in adding this. Yes it will be overwritten by the next full platform sync, but that's fine because it's a better - and fully compatible - fix.

@amh-mw
Copy link
Copy Markdown
Author

amh-mw commented Jun 4, 2012

If it helps clarify this patch,

libraries/joomla/access/access.php
13 +jimport('joomla.application.component.helper');

fixes the JComponentHelper dependencies found in the same file at

288 $result = array(JComponentHelper::getParams('com_users')->get('guest_usergroup',
1));
301 $query->where('a.id = ' . (int)
JComponentHelper::getParams('com_users')->get('guest_usergroup', 1));

and

libraries/joomla/installer/installer.php
17 +jimport('joomla.event.dispatcher');

fixes the JDispatcher dependencies found in the same file at

466 $dispatcher = JDispatcher::getInstance();
544 $dispatcher = JDispatcher::getInstance();
658 $dispatcher = JDispatcher::getInstance();
710 $dispatcher = JDispatcher::getInstance();

@phproberto
Copy link
Copy Markdown
Contributor

I'm closing this as it's not mergeable and 1 year old. Feel free to open if you update it and are still interested in get it merged.

Thanks for contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants