Skip to content

SQL92 RDBMS Portability#185

Closed
wdaniels wants to merge 57 commits intojoomla:masterfrom
wdaniels:sql92
Closed

SQL92 RDBMS Portability#185
wdaniels wants to merge 57 commits intojoomla:masterfrom
wdaniels:sql92

Conversation

@wdaniels
Copy link
Copy Markdown

First set of patches to assist RDBMS portability as previously discussed on the general development list. This covers the following:

  • Identifier quoting of SQL reserved words:
    • LANGUAGE
    • MODULE
    • OPTION
    • TIME
  • Identifier quoting of Virtuoso reserved word:
    • PASSWORD
  • Quoting of string literals in some places
  • Correct use of non-standard != logic comparison operator to <>
  • Casting of some long types used in SQL functions that may not support long types

These changes are organised by front/admin then by component/module/plugin but squashed into single commits with respect to the categories of changes listed above. Given that none of the categories of changes are intended to alter any functional features, I hope that this is suitably divided and correct granularity for manual testing.

If preferred the commits are available unsquashed on separate branches under wdaniels/joomla-cms as indicated by the [branch-name] prefixes of the squashed commits messages where merged into this (sql92) branch.

These patches are relatively trivial and I do not believe to be contentious. Further patch sets I intend to raise for discussion on joomla platform/cms lists as appropriate.

wdaniels added 30 commits April 10, 2012 09:28
@infograf768
Copy link
Copy Markdown
Member

Please create a Tracker on joomlacode with test instructions and add references here

@wdaniels
Copy link
Copy Markdown
Author

Logged at joomlacode.org #28391

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can put the a.password inside the quoteName, it will be parsed correctly,

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really? I thought I had checked that and it didn't work. It would certainly be clearer that way!
So you want me to redo this lot? It may take a little time to get around to but I guess there is no rush.

@infograf768
Copy link
Copy Markdown
Member

Please let it know in the tracker when ready to test.

@wdaniels
Copy link
Copy Markdown
Author

Revised as #198

@wdaniels wdaniels closed this Apr 25, 2012
beat added a commit to beat/joomla-cms that referenced this pull request Sep 10, 2013
zero-24 pushed a commit to zero-24/joomla-cms that referenced this pull request Oct 28, 2018
bembelimen pushed a commit to bembelimen/joomla-cms that referenced this pull request Jul 15, 2019
Changing list filters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants