Skip to content

SQL Portability Patches#198

Closed
wdaniels wants to merge 39 commits intojoomla:masterfrom
wdaniels:rdbms
Closed

SQL Portability Patches#198
wdaniels wants to merge 39 commits intojoomla:masterfrom
wdaniels:rdbms

Conversation

@wdaniels
Copy link
Copy Markdown

First set of patches to assist RDBMS portability as previously discussed on the general development list. This covers the following:

  • Identifier quoting of SQL reserved words:
    • LANGUAGE
    • MODULE
    • OPTION
    • TIME
    • LEVEL
    • POSITION
  • Identifier quoting of Virtuoso (and Oracle) reserved word:
    • PASSWORD
  • Quoting of string literals in some places
  • Correct use of non-standard != logic comparison operator to <>
  • Casting of some long types used in SQL functions that may not support long types
  • Fixed conditional join to categories in weblinks model (mod_weblinks seems to assume the categories table (aliased "c") is always present)
  • Fixed duplication of column list in mod_articles_news helper

These changes are organised by front/admin then by component/module/plugin but squashed into single commits with respect to the categories of changes listed above. Given that none of the categories of changes are intended to alter any functional features, I hope that this is suitably divided and correct granularity for manual testing.

If preferred the commits are available unsquashed on separate branches under wdaniels/joomla-cms as indicated by the [branch-name] prefixes of the squashed commits messages where merged into this (sql92) branch.

These patches are relatively trivial and I do not believe to be contentious. Further patch sets I intend to raise for discussion on joomla platform/cms lists as appropriate.

NB: There remains RDBMS portability issues with the use of MySQL DATE_FORMAT function in mod_relateditems and mod_weblinks which require some further investigation. Also issues remain with quoting for the LIKE conditions in mod_relateditems. No doubt other issues also remain; this patch set is not intended to be exhaustive, even with respect to the identified issues.

[JoomlaCode #28391]

wdaniels added 30 commits April 23, 2012 18:44
@piotr-cz
Copy link
Copy Markdown
Contributor

cool, thanks!

@elinw
Copy link
Copy Markdown
Contributor

elinw commented Oct 5, 2012

This is so good but it would really be easier to get it in if we separated it out into components and modules. Otherwise the testing is too much for one person to do it all.

@nicksavov
Copy link
Copy Markdown
Contributor

Thanks for coding this, Will!

While we’re transitioning to a new integrated tracker, could you report the issue on our current main tracker at JoomlaCode and cross-reference each with a link to the other? Here’s the process for reporting on the other tracker:
http://docs.joomla.org/Filing_bugs_and_issues

Alternatively, let me know if you’d like me to create it for you and I can go ahead and do that.

Thanks in advance and thanks again for coding this, Will!

@nicksavov
Copy link
Copy Markdown
Contributor

Looks like the tracker item is at http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=28391

Thanks Will!

beat added a commit to beat/joomla-cms that referenced this pull request Sep 10, 2013
Moved ajax-loader.gif to client, loads css file after click on tab
@phproberto
Copy link
Copy Markdown
Contributor

I'm closing this as it's not mergeable and 1 year old. Feel free to open if you update it and are still interested in get it merged.

Thanks for contributing.

@phproberto phproberto closed this Oct 3, 2013
richard67 pushed a commit to richard67/joomla-cms that referenced this pull request Apr 3, 2020
Add 3.0.0 beta to the update server with beta update tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants