[4.0] Fix SQL error "Column 'checked_out_time' cannot be null" when updating the CMS#28391
Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom Mar 18, 2020
Merged
Conversation
Use old pseudo null date in 4.0.0-2019-07-02.sql for checked out time because the real null date value change is done with a later update script.
Contributor
|
Thanks! Nice work! |
Member
Author
|
Thanks, too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #28385 .
Summary of Changes
Use old pseudo null date in update script
4.0.0-2019-07-02.sqlfor checked out time, because the real null date value change is done with script4.0.0-2019-10-06.sql, which runs after the previously mentioned one.Testing Instructions
Has to be tested with MySQL (or MariaDB) and PostgreSQL.
Testers please report back which of these database types you have tested.
Expected result
Update succeeds (except of the missing template message at the first login to the backend, which is normal).
Actual result
Update fails with SQL error "Column 'checked_out_time' cannot be null", and the CMS is broken, see issue #28385 .
Additional information
The diff clearly shows a difference between the update script for MySQL and the one for PostgreSQL in the ordering value for the inserted record.
For fixing such differences I am already on the way to prepare a PR, but it might be weekend until it will be ready.
Documentation Changes Required
None.