Check array bounds in menu tree before checking whether menu item is in path#200
Closed
seanredmond wants to merge 2 commits intojoomla:masterfrom
Closed
Check array bounds in menu tree before checking whether menu item is in path#200seanredmond wants to merge 2 commits intojoomla:masterfrom
seanredmond wants to merge 2 commits intojoomla:masterfrom
Conversation
…in path Before checking whether an menu item is in the path, first check whether there is an item at that array index to avoid many non-fatal (but annoying) "Undefined offset" notices
Member
|
Please, if not done, open a bugtracker on joomlacode with precise test instructions and cross reference here. |
Contributor
|
I'm closing this as it's not mergeable and 1 year old. Feel free to open if you update it and are still interested in get it merged. Thanks for contributing. |
|
Same warning with Joomla 3.2.2. |
wilsonge
pushed a commit
that referenced
this pull request
Jun 4, 2017
Simplify logic in local adapter
roland-d
added a commit
to roland-d/joomla-cms
that referenced
this pull request
Jul 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code generates many non-fatal (but annoying) "Undefined offset" notices. Before checking whether a menu item is in the path, first check whether there is an item at that array index.