Deprecate editor form field save function#17944
Conversation
| { | ||
| return $this->getEditor()->save($this->id); | ||
| $editor = $this->getEditor(); | ||
| if (!method_exists($editor, 'save')) |
There was a problem hiding this comment.
Unless you're trying to use JEditor from both 3.x and 4.x simultaneously this will always be true on the 3.x branch and false on 4.x. So, no need to make a change.
There was a problem hiding this comment.
Would be nice to have both plugins from 4 supported on Joomla 3.
|
This needs testing to ensure the removed line does not have side effects. |
|
Removed the line removal, as it was an invalid code change from the pr against 4. |
|
@laoneo can this PR be tested? |
|
Yes. |
|
I have tested this item ✅ successfully on 0078d74 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17944. |
| { | ||
| return $this->getEditor()->save($this->id); | ||
| $editor = $this->getEditor(); | ||
| if (!method_exists($editor, 'save')) |
There was a problem hiding this comment.
Add a blank line before if statement.
|
I have tested this item ✅ successfully on 4c2aa03 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17944. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17944. |
Pull Request for Pr #17942.
Summary of Changes
As the editor save function is deprecated, the editor form fields needs to be deprecated too. This pr does that.
Testing Instructions
Edit article on the front end.
Expected result
It works.
Actual result
It works.