ACL getActions consistency improvements for all components#220
Closed
sanderpotjer wants to merge 1 commit intojoomla:masterfrom
sanderpotjer:acllevels
Closed
ACL getActions consistency improvements for all components#220sanderpotjer wants to merge 1 commit intojoomla:masterfrom sanderpotjer:acllevels
sanderpotjer wants to merge 1 commit intojoomla:masterfrom
sanderpotjer:acllevels
Conversation
Member
Author
Contributor
There was a problem hiding this comment.
From reading the code it looks like you're always getting the component actions. So this only works if there are no additional rights for items, correct? Certainly a reasonable assumption, just making sure I correctly understand this.
Member
Author
There was a problem hiding this comment.
Yes that is correct. But an additional right for an item should also be available in the component actions, otherwise you can't set an action item wide.
wilsonge
pushed a commit
that referenced
this pull request
Jan 23, 2017
Menu item - Module assign column alignment
richard67
pushed a commit
to richard67/joomla-cms
that referenced
this pull request
Apr 3, 2020
Add PostgreSQL (PDO) driver.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit will improve the consistent use of the ACL API across the Joomla components. It also removes the level part of the getActions check for certain components. You want to have all component actions and not just of the specific section, and the component should contain all actions of the other sections of access.xml. Otherwise you might not be able to check for core.manage action to show the permission settings fieldset in an different section for example.