move generated-autograd-headers to the shared build structure by dagitses · Pull Request #76183 · pytorch/pytorch

dagitses · 2022-04-21T17:37:16Z

Stack from ghstack (oldest at bottom):

This is a relatively simple target but we have to fix our header
expansion to understand generated files. Next step will be to use this
in Bazel.

Differential Revision: D35820541

NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!

This is a relatively simple target but we have to fix our header expansion to understand generated files. Next step will be to use this in Bazel. Differential Revision: [D35820541](https://our.internmc.facebook.com/intern/diff/D35820541/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35820541/)! [ghstack-poisoned]

facebook-github-bot · 2022-04-21T17:37:22Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/76183
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours
↩️ [fb-only] Re-run with SSH instructions

❌ 2 New Failures

As of commit bdab0b4 (more details on the Dr. CI page):

Expand to see more

2/2 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages

pull / linux-bionic-rocm5.1-py3.7 / test (default, 1, 2, linux.rocm.gpu) (1/2)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-05-18T19:33:09.7835216Z FAIL [0.126s]: test_Conv2d_groups_nobias_v2 (__main__.TestNN)

2022-05-18T19:33:09.6958181Z   test_xavier_normal_errors_on_inputs_smaller_than_2d (__main__.TestNNInit) ... ok (0.001s)
2022-05-18T19:33:09.7691238Z   test_xavier_uniform (__main__.TestNNInit) ... ok (0.073s)
2022-05-18T19:33:09.7699089Z   test_xavier_uniform_errors_on_inputs_smaller_than_2d (__main__.TestNNInit) ... ok (0.001s)
2022-05-18T19:33:09.7730910Z   test_load_state_dict_module_pre_hook (__main__.TestStateDictHooks) ... ok (0.003s)
2022-05-18T19:33:09.7763354Z   test_load_state_dict_post_hook (__main__.TestStateDictHooks) ... ok (0.003s)
2022-05-18T19:33:09.7800115Z   test_load_state_dict_post_hook_backward_compatibility (__main__.TestStateDictHooks) ... ok (0.004s)
2022-05-18T19:33:09.7826649Z   test_load_state_dict_pre_hook (__main__.TestStateDictHooks) ... ok (0.003s)
2022-05-18T19:33:09.7833418Z   test_no_extra_ref_to_module (__main__.TestStateDictHooks) ... ok (0.001s)
2022-05-18T19:33:09.7834047Z 
2022-05-18T19:33:09.7834379Z ======================================================================
2022-05-18T19:33:09.7835216Z FAIL [0.126s]: test_Conv2d_groups_nobias_v2 (__main__.TestNN)
2022-05-18T19:33:09.7839762Z ----------------------------------------------------------------------
2022-05-18T19:33:09.7840787Z Traceback (most recent call last):
2022-05-18T19:33:09.7841708Z   File "test_nn.py", line 6876, in test_Conv2d_groups_nobias_v2
2022-05-18T19:33:09.7842708Z     self.assertEqual(output, torch.cat([output1, output2], 1))
2022-05-18T19:33:09.7844329Z   File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py", line 2258, in assertEqual
2022-05-18T19:33:09.7845291Z     msg=msg,
2022-05-18T19:33:09.7846595Z   File "/opt/conda/lib/python3.7/site-packages/torch/testing/_comparison.py", line 1086, in assert_equal
2022-05-18T19:33:09.7847602Z     raise error_metas[0].to_error()
2022-05-18T19:33:09.7848601Z AssertionError: Tensor-likes are not close!
2022-05-18T19:33:09.7849108Z

pull / linux-xenial-py3.7-gcc5.4 / test (backwards_compat, 1, 1, linux.2xlarge) (2/2)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-05-18T18:43:45.8816196Z The PR is introduc...m to confirm whether this change is wanted or not.

2022-05-18T18:43:45.8801531Z processing existing schema:  text(__torch__.torch.classes.profiling.SourceRef _0) -> (str _0)
2022-05-18T18:43:45.8803084Z processing existing schema:  count(__torch__.torch.classes.profiling.InstructionStats _0) -> (int _0)
2022-05-18T18:43:45.8804420Z processing existing schema:  duration_ns(__torch__.torch.classes.profiling.InstructionStats _0) -> (int _0)
2022-05-18T18:43:45.8805980Z processing existing schema:  source(__torch__.torch.classes.profiling.SourceStats _0) -> (__torch__.torch.classes.profiling.SourceRef _0)
2022-05-18T18:43:45.8808011Z processing existing schema:  line_map(__torch__.torch.classes.profiling.SourceStats _0) -> (Dict(int, __torch__.torch.classes.profiling.InstructionStats) _0)
2022-05-18T18:43:45.8809363Z processing existing schema:  __init__(__torch__.torch.classes.profiling._ScriptProfile _0) -> (NoneType _0)
2022-05-18T18:43:45.8810714Z processing existing schema:  enable(__torch__.torch.classes.profiling._ScriptProfile _0) -> (NoneType _0)
2022-05-18T18:43:45.8812182Z processing existing schema:  disable(__torch__.torch.classes.profiling._ScriptProfile _0) -> (NoneType _0)
2022-05-18T18:43:45.8814166Z processing existing schema:  _dump_stats(__torch__.torch.classes.profiling._ScriptProfile _0) -> (__torch__.torch.classes.profiling.SourceStats[] _0)
2022-05-18T18:43:45.8815956Z processing existing schema:  __init__(__torch__.torch.classes.dist_rpc.WorkerInfo _0, str _1, int _2) -> (NoneType _0)
2022-05-18T18:43:45.8816196Z The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not. 
2022-05-18T18:43:45.8816217Z 
2022-05-18T18:43:45.8816276Z Broken ops: [
2022-05-18T18:43:45.8816486Z 	aten::bitwise_and.Scalar_Tensor(Scalar self, Tensor other) -> (Tensor)
2022-05-18T18:43:45.8816681Z 	aten::bitwise_or.Scalar_Tensor(Scalar self, Tensor other) -> (Tensor)
2022-05-18T18:43:45.8816874Z 	aten::bitwise_xor.Scalar_Tensor(Scalar self, Tensor other) -> (Tensor)
2022-05-18T18:43:45.8817136Z 	aten::glu_backward_jvp(Tensor grad_x, Tensor grad_glu, Tensor x, Tensor dgrad_glu, Tensor dx, int dim) -> (Tensor)
2022-05-18T18:43:45.8817198Z ]
2022-05-18T18:43:45.9737727Z + cleanup
2022-05-18T18:43:45.9737901Z + retcode=1
2022-05-18T18:43:45.9738021Z + set +x

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This is a relatively simple target but we have to fix our header expansion to understand generated files. Next step will be to use this in Bazel. Differential Revision: [D35820541](https://our.internmc.facebook.com/intern/diff/D35820541/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35820541/)! ghstack-source-id: 154474743 Pull Request resolved: #76183

…ure" This is a relatively simple target but we have to fix our header expansion to understand generated files. Next step will be to use this in Bazel. Differential Revision: [D35820541](https://our.internmc.facebook.com/intern/diff/D35820541/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35820541/)! [ghstack-poisoned]

Pull Request resolved: #76183 This is a relatively simple target but we have to fix our header expansion to understand generated files. Next step will be to use this in Bazel. ghstack-source-id: 154474743 Differential Revision: [D35820541](https://our.internmc.facebook.com/intern/diff/D35820541/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35820541/)!

…ure" This is a relatively simple target but we have to fix our header expansion to understand generated files. Next step will be to use this in Bazel. Differential Revision: [D35820541](https://our.internmc.facebook.com/intern/diff/D35820541/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35820541/)! [ghstack-poisoned]

Pull Request resolved: #76183 This is a relatively simple target but we have to fix our header expansion to understand generated files. Next step will be to use this in Bazel. ghstack-source-id: 154474743 Differential Revision: [D35820541](https://our.internmc.facebook.com/intern/diff/D35820541/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35820541/)!

…ure" This is a relatively simple target but we have to fix our header expansion to understand generated files. Next step will be to use this in Bazel. Differential Revision: [D35820541](https://our.internmc.facebook.com/intern/diff/D35820541/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35820541/)! [ghstack-poisoned]

Pull Request resolved: #76183 This is a relatively simple target but we have to fix our header expansion to understand generated files. Next step will be to use this in Bazel. ghstack-source-id: 154678047 Differential Revision: [D35820541](https://our.internmc.facebook.com/intern/diff/D35820541/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35820541/)!

…ure" This is a relatively simple target but we have to fix our header expansion to understand generated files. Next step will be to use this in Bazel. Differential Revision: [D35820541](https://our.internmc.facebook.com/intern/diff/D35820541/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35820541/)! [ghstack-poisoned]

Pull Request resolved: #76183 This is a relatively simple target but we have to fix our header expansion to understand generated files. Next step will be to use this in Bazel. ghstack-source-id: 154678047 Differential Revision: [D35820541](https://our.internmc.facebook.com/intern/diff/D35820541/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35820541/)!

…ure" This is a relatively simple target but we have to fix our header expansion to understand generated files. Next step will be to use this in Bazel. Differential Revision: [D35820541](https://our.internmc.facebook.com/intern/diff/D35820541/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35820541/)! [ghstack-poisoned]

facebook-github-bot · 2022-05-19T04:30:44Z

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

facebook-github-bot · 2022-05-19T04:31:03Z

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

github-actions · 2022-05-19T04:32:29Z

Hey @dagitses.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

pytorchmergebot · 2022-05-19T04:33:10Z

Can't merge closed PR #76183

Summary: Pull Request resolved: #76183 This is a relatively simple target but we have to fix our header expansion to understand generated files. Next step will be to use this in Bazel. ghstack-source-id: 156687841 Test Plan: Rely on CI. Reviewed By: dreiss, malfet Differential Revision: D35820541 fbshipit-source-id: 9108ccd0d13a0e1438c5f8d665eef43014e60599

Pull Request resolved: pytorch#76183 This is a relatively simple target but we have to fix our header expansion to understand generated files. Next step will be to use this in Bazel. Differential Revision: [D35820541](https://our.internmc.facebook.com/intern/diff/D35820541/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35820541/)! Approved by: https://github.com/dreiss, https://github.com/malfet

facebook-github-bot added the cla signed label Apr 21, 2022

dagitses mentioned this pull request Apr 26, 2022

remove unnecessary ATen/core/Macros.h #76376

Closed

Michael Andreas Dagitses added 5 commits May 16, 2022 12:37

dagitses mentioned this pull request May 17, 2022

move generated_srcs_list.bzl into caffe2/build.bzl #77680

Closed

malfet approved these changes May 17, 2022

View reviewed changes

Michael Andreas Dagitses added 2 commits May 18, 2022 03:43

This was referenced May 18, 2022

gen_aten output into aten/src/ATen/ #77773

Closed

switch Bazel to common aten codegen #77778

Closed

gen_aten uses full paths to aten files #77788

Closed

eliminate generated_cpu_cpp and generated_cuda_cpp from Bazel #77790

Closed

pytorchmergebot added the Merged label May 19, 2022

pytorchmergebot closed this in c2ff413 May 19, 2022

facebook-github-bot deleted the gh/dagitses/330/head branch May 22, 2022 14:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move generated-autograd-headers to the shared build structure#76183

move generated-autograd-headers to the shared build structure#76183
dagitses wants to merge 41 commits into
gh/dagitses/330/basefrom
gh/dagitses/330/head

dagitses commented Apr 21, 2022 •

edited

Loading

Uh oh!

facebook-github-bot commented Apr 21, 2022 •

edited

Loading

🕵️ 2 new failures recognized by patterns

pull / linux-bionic-rocm5.1-py3.7 / test (default, 1, 2, linux.rocm.gpu) (1/2)

pull / linux-xenial-py3.7-gcc5.4 / test (backwards_compat, 1, 1, linux.2xlarge) (2/2)

Uh oh!

facebook-github-bot commented May 19, 2022

Uh oh!

facebook-github-bot commented May 19, 2022

Uh oh!

github-actions Bot commented May 19, 2022

Uh oh!

pytorchmergebot commented May 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

dagitses commented Apr 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Apr 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

❌ 2 New Failures

🕵️ 2 new failures recognized by patterns

pull / linux-bionic-rocm5.1-py3.7 / test (default, 1, 2, linux.rocm.gpu) (1/2)

pull / linux-xenial-py3.7-gcc5.4 / test (backwards_compat, 1, 1, linux.2xlarge) (2/2)

Uh oh!

facebook-github-bot commented May 19, 2022

Uh oh!

facebook-github-bot commented May 19, 2022

Uh oh!

github-actions Bot commented May 19, 2022

Uh oh!

pytorchmergebot commented May 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dagitses commented Apr 21, 2022 •

edited

Loading

facebook-github-bot commented Apr 21, 2022 •

edited

Loading