move setup_helpers programs to shared build structure#74849
Closed
dagitses wants to merge 73 commits into
Closed
Conversation
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)! [ghstack-poisoned]
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 0bfff28 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Mar 28, 2022
dagitses
pushed a commit
that referenced
this pull request
Mar 28, 2022
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)! ghstack-source-id: 152377144 Pull Request resolved: #74849
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)! [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
Mar 28, 2022
Pull Request resolved: #74849 ghstack-source-id: 152377144 Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)!
malfet
approved these changes
Mar 28, 2022
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)! [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
Mar 29, 2022
Pull Request resolved: #74849 ghstack-source-id: 152377144 Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)!
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)! [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
Mar 30, 2022
Pull Request resolved: #74849 ghstack-source-id: 152377144 Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)!
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)! [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
Mar 31, 2022
Pull Request resolved: #74849 ghstack-source-id: 152377144 Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)!
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)! [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
Mar 31, 2022
Pull Request resolved: #74849 ghstack-source-id: 152722869 Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)!
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)! [ghstack-poisoned]
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)! [ghstack-poisoned]
added 2 commits
April 16, 2022 11:34
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)! [ghstack-poisoned]
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)! [ghstack-poisoned]
added 8 commits
April 16, 2022 14:03
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)! [ghstack-poisoned]
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)! [ghstack-poisoned]
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)! [ghstack-poisoned]
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)! [ghstack-poisoned]
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)! [ghstack-poisoned]
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)! [ghstack-poisoned]
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)! [ghstack-poisoned]
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)! [ghstack-poisoned]
added 4 commits
April 18, 2022 06:52
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)! [ghstack-poisoned]
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)! [ghstack-poisoned]
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)! [ghstack-poisoned]
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)! [ghstack-poisoned]
This was referenced Apr 21, 2022
added 3 commits
April 21, 2022 07:22
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)! [ghstack-poisoned]
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)! [ghstack-poisoned]
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)! [ghstack-poisoned]
This was referenced Apr 21, 2022
malfet
approved these changes
Apr 21, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 22, 2022
Summary: Pull Request resolved: #74849 ghstack-source-id: 154189187 Test Plan: Rely on CI. Reviewed By: malfet Differential Revision: D35191356 fbshipit-source-id: 406b5e95a5704b4b62d846a259839bf61f3e4aba
Contributor
|
Hey @dagitses. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
Summary: Pull Request resolved: pytorch#74849 ghstack-source-id: 154189187 Test Plan: Rely on CI. Reviewed By: malfet Differential Revision: D35191356 fbshipit-source-id: 406b5e95a5704b4b62d846a259839bf61f3e4aba (cherry picked from commit 46ec2b1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Differential Revision: D35191356
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!