add support for filtering out Bazel targets from common structure#76173
Closed
dagitses wants to merge 27 commits into
Closed
add support for filtering out Bazel targets from common structure#76173dagitses wants to merge 27 commits into
dagitses wants to merge 27 commits into
Conversation
We need this facility temporarily to sequence some changes without breakage. This is generally not a good idea since the main purpose of this effort is to replicate builds in OSS Bazel. Differential Revision: [D35815290](https://our.internmc.facebook.com/intern/diff/D35815290/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815290/)! [ghstack-poisoned]
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 0ab352a (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Apr 21, 2022
added 6 commits
April 21, 2022 07:22
…ructure" We need this facility temporarily to sequence some changes without breakage. This is generally not a good idea since the main purpose of this effort is to replicate builds in OSS Bazel. Differential Revision: [D35815290](https://our.internmc.facebook.com/intern/diff/D35815290/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815290/)! [ghstack-poisoned]
…ructure" We need this facility temporarily to sequence some changes without breakage. This is generally not a good idea since the main purpose of this effort is to replicate builds in OSS Bazel. Differential Revision: [D35815290](https://our.internmc.facebook.com/intern/diff/D35815290/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815290/)! [ghstack-poisoned]
…ructure" We need this facility temporarily to sequence some changes without breakage. This is generally not a good idea since the main purpose of this effort is to replicate builds in OSS Bazel. Differential Revision: [D35815290](https://our.internmc.facebook.com/intern/diff/D35815290/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815290/)! [ghstack-poisoned]
…ructure" We need this facility temporarily to sequence some changes without breakage. This is generally not a good idea since the main purpose of this effort is to replicate builds in OSS Bazel. Differential Revision: [D35815290](https://our.internmc.facebook.com/intern/diff/D35815290/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815290/)! [ghstack-poisoned]
…ructure" We need this facility temporarily to sequence some changes without breakage. This is generally not a good idea since the main purpose of this effort is to replicate builds in OSS Bazel. Differential Revision: [D35815290](https://our.internmc.facebook.com/intern/diff/D35815290/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815290/)! [ghstack-poisoned]
…ructure" We need this facility temporarily to sequence some changes without breakage. This is generally not a good idea since the main purpose of this effort is to replicate builds in OSS Bazel. Differential Revision: [D35815290](https://our.internmc.facebook.com/intern/diff/D35815290/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815290/)! [ghstack-poisoned]
added 2 commits
April 21, 2022 09:11
…ructure" We need this facility temporarily to sequence some changes without breakage. This is generally not a good idea since the main purpose of this effort is to replicate builds in OSS Bazel. Differential Revision: [D35815290](https://our.internmc.facebook.com/intern/diff/D35815290/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815290/)! [ghstack-poisoned]
…ructure" We need this facility temporarily to sequence some changes without breakage. This is generally not a good idea since the main purpose of this effort is to replicate builds in OSS Bazel. Differential Revision: [D35815290](https://our.internmc.facebook.com/intern/diff/D35815290/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815290/)! [ghstack-poisoned]
added 3 commits
April 21, 2022 09:37
…ructure" We need this facility temporarily to sequence some changes without breakage. This is generally not a good idea since the main purpose of this effort is to replicate builds in OSS Bazel. Differential Revision: [D35815290](https://our.internmc.facebook.com/intern/diff/D35815290/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815290/)! [ghstack-poisoned]
…ructure" We need this facility temporarily to sequence some changes without breakage. This is generally not a good idea since the main purpose of this effort is to replicate builds in OSS Bazel. Differential Revision: [D35815290](https://our.internmc.facebook.com/intern/diff/D35815290/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815290/)! [ghstack-poisoned]
…ructure" We need this facility temporarily to sequence some changes without breakage. This is generally not a good idea since the main purpose of this effort is to replicate builds in OSS Bazel. Differential Revision: [D35815290](https://our.internmc.facebook.com/intern/diff/D35815290/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815290/)! [ghstack-poisoned]
added 2 commits
April 22, 2022 10:00
…ructure" We need this facility temporarily to sequence some changes without breakage. This is generally not a good idea since the main purpose of this effort is to replicate builds in OSS Bazel. Differential Revision: [D35815290](https://our.internmc.facebook.com/intern/diff/D35815290/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815290/)! [ghstack-poisoned]
…ructure" We need this facility temporarily to sequence some changes without breakage. This is generally not a good idea since the main purpose of this effort is to replicate builds in OSS Bazel. Differential Revision: [D35815290](https://our.internmc.facebook.com/intern/diff/D35815290/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815290/)! [ghstack-poisoned]
dreiss
approved these changes
Apr 22, 2022
added 4 commits
April 24, 2022 19:25
…ructure" We need this facility temporarily to sequence some changes without breakage. This is generally not a good idea since the main purpose of this effort is to replicate builds in OSS Bazel. Differential Revision: [D35815290](https://our.internmc.facebook.com/intern/diff/D35815290/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815290/)! [ghstack-poisoned]
…ructure" We need this facility temporarily to sequence some changes without breakage. This is generally not a good idea since the main purpose of this effort is to replicate builds in OSS Bazel. Differential Revision: [D35815290](https://our.internmc.facebook.com/intern/diff/D35815290/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815290/)! [ghstack-poisoned]
…ructure" We need this facility temporarily to sequence some changes without breakage. This is generally not a good idea since the main purpose of this effort is to replicate builds in OSS Bazel. Differential Revision: [D35815290](https://our.internmc.facebook.com/intern/diff/D35815290/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815290/)! [ghstack-poisoned]
…ructure" We need this facility temporarily to sequence some changes without breakage. This is generally not a good idea since the main purpose of this effort is to replicate builds in OSS Bazel. Differential Revision: [D35815290](https://our.internmc.facebook.com/intern/diff/D35815290/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815290/)! [ghstack-poisoned]
…ructure" We need this facility temporarily to sequence some changes without breakage. This is generally not a good idea since the main purpose of this effort is to replicate builds in OSS Bazel. Differential Revision: [D35815290](https://our.internmc.facebook.com/intern/diff/D35815290/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815290/)! [ghstack-poisoned]
This was referenced Apr 27, 2022
Closed
Closed
added 8 commits
April 29, 2022 04:15
…ructure" We need this facility temporarily to sequence some changes without breakage. This is generally not a good idea since the main purpose of this effort is to replicate builds in OSS Bazel. Differential Revision: [D35815290](https://our.internmc.facebook.com/intern/diff/D35815290/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815290/)! [ghstack-poisoned]
…ructure" We need this facility temporarily to sequence some changes without breakage. This is generally not a good idea since the main purpose of this effort is to replicate builds in OSS Bazel. Differential Revision: [D35815290](https://our.internmc.facebook.com/intern/diff/D35815290/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815290/)! [ghstack-poisoned]
…ructure" We need this facility temporarily to sequence some changes without breakage. This is generally not a good idea since the main purpose of this effort is to replicate builds in OSS Bazel. Differential Revision: [D35815290](https://our.internmc.facebook.com/intern/diff/D35815290/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815290/)! [ghstack-poisoned]
…ructure" We need this facility temporarily to sequence some changes without breakage. This is generally not a good idea since the main purpose of this effort is to replicate builds in OSS Bazel. Differential Revision: [D35815290](https://our.internmc.facebook.com/intern/diff/D35815290/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815290/)! [ghstack-poisoned]
…ructure" We need this facility temporarily to sequence some changes without breakage. This is generally not a good idea since the main purpose of this effort is to replicate builds in OSS Bazel. Differential Revision: [D35815290](https://our.internmc.facebook.com/intern/diff/D35815290/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815290/)! [ghstack-poisoned]
…ructure" We need this facility temporarily to sequence some changes without breakage. This is generally not a good idea since the main purpose of this effort is to replicate builds in OSS Bazel. Differential Revision: [D35815290](https://our.internmc.facebook.com/intern/diff/D35815290/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815290/)! [ghstack-poisoned]
…ructure" We need this facility temporarily to sequence some changes without breakage. This is generally not a good idea since the main purpose of this effort is to replicate builds in OSS Bazel. Differential Revision: [D35815290](https://our.internmc.facebook.com/intern/diff/D35815290/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815290/)! [ghstack-poisoned]
…ructure" We need this facility temporarily to sequence some changes without breakage. This is generally not a good idea since the main purpose of this effort is to replicate builds in OSS Bazel. Differential Revision: [D35815290](https://our.internmc.facebook.com/intern/diff/D35815290/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815290/)! [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
May 3, 2022
…6173) Summary: Pull Request resolved: #76173 We need this facility temporarily to sequence some changes without breakage. This is generally not a good idea since the main purpose of this effort is to replicate builds in OSS Bazel. ghstack-source-id: 155215491 Test Plan: Manual test and rely on CI. Reviewed By: dreiss Differential Revision: D35815290 fbshipit-source-id: 89bacda373e7ba03d6a3fcbcaa5af42ae5eac154
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
…torch#76173) Summary: Pull Request resolved: pytorch#76173 We need this facility temporarily to sequence some changes without breakage. This is generally not a good idea since the main purpose of this effort is to replicate builds in OSS Bazel. ghstack-source-id: 155215491 Test Plan: Manual test and rely on CI. Reviewed By: dreiss Differential Revision: D35815290 fbshipit-source-id: 89bacda373e7ba03d6a3fcbcaa5af42ae5eac154 (cherry picked from commit 1b808bb)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
We need this facility temporarily to sequence some changes without
breakage. This is generally not a good idea since the main purpose of
this effort is to replicate builds in OSS Bazel.
Differential Revision: D35815290
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!