eliminate Bazel's libtorch_python_generated_sources by dagitses · Pull Request #76178 · pytorch/pytorch

dagitses · 2022-04-21T16:07:50Z

Stack from ghstack (oldest at bottom):

These contents are already identified in the shared build structure.

Differential Revision: D35817999

NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!

These contents are already identified in the shared build structure. Differential Revision: [D35817999](https://our.internmc.facebook.com/intern/diff/D35817999/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35817999/)! [ghstack-poisoned]

facebook-github-bot · 2022-04-21T16:07:55Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/76178
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours
↩️ [fb-only] Re-run with SSH instructions

❌ 1 New Failures

As of commit 418ed5b (more details on the Dr. CI page):

Expand to see more

1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

pull / linux-bionic-rocm5.1-py3.7 / test (default, 1, 2, linux.rocm.gpu) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-05-16T22:14:23.3537563Z FAIL [1.076s]: tes...ing_cuda_complex64 (__main__.TestNNDeviceTypeCUDA)

2022-05-16T22:14:23.2605823Z   test_xavier_normal_errors_on_inputs_smaller_than_2d (__main__.TestNNInit) ... ok (0.001s)
2022-05-16T22:14:23.3411901Z   test_xavier_uniform (__main__.TestNNInit) ... ok (0.080s)
2022-05-16T22:14:23.3417325Z   test_xavier_uniform_errors_on_inputs_smaller_than_2d (__main__.TestNNInit) ... ok (0.001s)
2022-05-16T22:14:23.3443745Z   test_load_state_dict_module_pre_hook (__main__.TestStateDictHooks) ... ok (0.002s)
2022-05-16T22:14:23.3470614Z   test_load_state_dict_post_hook (__main__.TestStateDictHooks) ... ok (0.003s)
2022-05-16T22:14:23.3501938Z   test_load_state_dict_post_hook_backward_compatibility (__main__.TestStateDictHooks) ... ok (0.003s)
2022-05-16T22:14:23.3524170Z   test_load_state_dict_pre_hook (__main__.TestStateDictHooks) ... ok (0.002s)
2022-05-16T22:14:23.3528684Z   test_no_extra_ref_to_module (__main__.TestStateDictHooks) ... ok (0.001s)
2022-05-16T22:14:23.3529317Z 
2022-05-16T22:14:23.3529660Z ======================================================================
2022-05-16T22:14:23.3537563Z FAIL [1.076s]: test_conv1d_same_padding_cuda_complex64 (__main__.TestNNDeviceTypeCUDA)
2022-05-16T22:14:23.3539914Z ----------------------------------------------------------------------
2022-05-16T22:14:23.3540851Z Traceback (most recent call last):
2022-05-16T22:14:23.3542321Z   File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py", line 1808, in wrapper
2022-05-16T22:14:23.3543301Z     method(*args, **kwargs)
2022-05-16T22:14:23.3544942Z   File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 377, in instantiated_test
2022-05-16T22:14:23.3546345Z     result = test(self, **param_kwargs)
2022-05-16T22:14:23.3547549Z   File "test_nn.py", line 13705, in test_conv1d_same_padding
2022-05-16T22:14:23.3549207Z     self.assertEqual(expect, actual)
2022-05-16T22:14:23.3551232Z   File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py", line 2258, in assertEqual
2022-05-16T22:14:23.3552200Z     msg=msg,

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

These contents are already identified in the shared build structure. Differential Revision: [D35817999](https://our.internmc.facebook.com/intern/diff/D35817999/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35817999/)! [ghstack-poisoned]

facebook-github-bot · 2022-05-17T03:41:50Z

@pytorchbot merge this

(Initiating merge automatically since Phabricator Diff has merged)

github-actions · 2022-05-17T03:43:33Z

Hey @dagitses.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Summary: Pull Request resolved: #76178 These contents are already identified in the shared build structure. ghstack-source-id: 156410054 Test Plan: This should be a no-op, rely on CI. Reviewed By: dreiss Differential Revision: D35817999 fbshipit-source-id: 554d2133ddd08825e222ca69c452819fb6c820a6

Pull Request resolved: pytorch#76178 These contents are already identified in the shared build structure. Differential Revision: [D35817999](https://our.internmc.facebook.com/intern/diff/D35817999/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35817999/)! Approved by: https://github.com/dreiss

facebook-github-bot added the cla signed label Apr 21, 2022

dagitses mentioned this pull request Apr 21, 2022

eliminate Bazel's libtorch_cpp_generated_sources #76179

Closed

Michael Andreas Dagitses added 3 commits April 21, 2022 09:37

dagitses mentioned this pull request Apr 21, 2022

move generated-autograd-headers to the shared build structure #76183

Closed

Michael Andreas Dagitses added 6 commits April 22, 2022 10:01

Michael Andreas Dagitses added 9 commits May 2, 2022 03:25

dreiss approved these changes May 5, 2022

View reviewed changes

Michael Andreas Dagitses added 12 commits May 6, 2022 05:18

pytorchmergebot added the Merged label May 17, 2022

pytorchmergebot closed this in a013d83 May 17, 2022

facebook-github-bot deleted the gh/dagitses/328/head branch May 20, 2022 14:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

eliminate Bazel's libtorch_python_generated_sources#76178

eliminate Bazel's libtorch_python_generated_sources#76178
dagitses wants to merge 42 commits into
gh/dagitses/328/basefrom
gh/dagitses/328/head

dagitses commented Apr 21, 2022 •

edited

Loading

Uh oh!

facebook-github-bot commented Apr 21, 2022 •

edited

Loading

🕵️ 1 new failure recognized by patterns

pull / linux-bionic-rocm5.1-py3.7 / test (default, 1, 2, linux.rocm.gpu) (1/1)

Uh oh!

facebook-github-bot commented May 17, 2022

Uh oh!

github-actions Bot commented May 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

dagitses commented Apr 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Apr 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

❌ 1 New Failures

🕵️ 1 new failure recognized by patterns

pull / linux-bionic-rocm5.1-py3.7 / test (default, 1, 2, linux.rocm.gpu) (1/1)

Uh oh!

facebook-github-bot commented May 17, 2022

Uh oh!

github-actions Bot commented May 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dagitses commented Apr 21, 2022 •

edited

Loading

facebook-github-bot commented Apr 21, 2022 •

edited

Loading