aten_core in xplat#76513
Closed
dagitses wants to merge 19 commits into
Closed
Conversation
Differential Revision: [D35991002](https://our.internmc.facebook.com/intern/diff/D35991002/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35991002/)! [ghstack-poisoned]
Contributor
🔗 Helpful links
❌ 1 New Failures, 1 PendingAs of commit c2f573f (more details on the Dr. CI page): Expand to see more
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
This was referenced Apr 28, 2022
Closed
dagitses
pushed a commit
that referenced
this pull request
Apr 28, 2022
Differential Revision: [D35991002](https://our.internmc.facebook.com/intern/diff/D35991002/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35991002/)! ghstack-source-id: 155029321 Pull Request resolved: #76513
Differential Revision: [D35991002](https://our.internmc.facebook.com/intern/diff/D35991002/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35991002/)! [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
Apr 30, 2022
Pull Request resolved: #76513 ghstack-source-id: 155029321 Differential Revision: [D35991002](https://our.internmc.facebook.com/intern/diff/D35991002/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35991002/)!
Differential Revision: [D35991002](https://our.internmc.facebook.com/intern/diff/D35991002/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35991002/)! [ghstack-poisoned]
Differential Revision: [D35991002](https://our.internmc.facebook.com/intern/diff/D35991002/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35991002/)! [ghstack-poisoned]
Differential Revision: [D35991002](https://our.internmc.facebook.com/intern/diff/D35991002/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35991002/)! [ghstack-poisoned]
Differential Revision: [D35991002](https://our.internmc.facebook.com/intern/diff/D35991002/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35991002/)! [ghstack-poisoned]
Differential Revision: [D35991002](https://our.internmc.facebook.com/intern/diff/D35991002/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35991002/)! [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
May 2, 2022
Pull Request resolved: #76513 ghstack-source-id: 155029321 Differential Revision: [D35991002](https://our.internmc.facebook.com/intern/diff/D35991002/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35991002/)!
Differential Revision: [D35991002](https://our.internmc.facebook.com/intern/diff/D35991002/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35991002/)! [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
May 2, 2022
Pull Request resolved: #76513 ghstack-source-id: 155029321 Differential Revision: [D35991002](https://our.internmc.facebook.com/intern/diff/D35991002/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35991002/)!
Differential Revision: [D35991002](https://our.internmc.facebook.com/intern/diff/D35991002/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35991002/)! [ghstack-poisoned]
Differential Revision: [D35991002](https://our.internmc.facebook.com/intern/diff/D35991002/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35991002/)! [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
May 3, 2022
Pull Request resolved: #76513 ghstack-source-id: 155029321 Differential Revision: [D35991002](https://our.internmc.facebook.com/intern/diff/D35991002/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35991002/)!
Differential Revision: [D35991002](https://our.internmc.facebook.com/intern/diff/D35991002/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35991002/)! [ghstack-poisoned]
Differential Revision: [D35991002](https://our.internmc.facebook.com/intern/diff/D35991002/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35991002/)! [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
May 3, 2022
Pull Request resolved: #76513 ghstack-source-id: 155029321 Differential Revision: [D35991002](https://our.internmc.facebook.com/intern/diff/D35991002/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35991002/)!
Differential Revision: [D35991002](https://our.internmc.facebook.com/intern/diff/D35991002/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35991002/)! [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
May 4, 2022
Pull Request resolved: #76513 ghstack-source-id: 155029321 Differential Revision: [D35991002](https://our.internmc.facebook.com/intern/diff/D35991002/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35991002/)!
Differential Revision: [D35991002](https://our.internmc.facebook.com/intern/diff/D35991002/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35991002/)! [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
May 6, 2022
Pull Request resolved: #76513 ghstack-source-id: 155029321 Differential Revision: [D35991002](https://our.internmc.facebook.com/intern/diff/D35991002/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35991002/)!
Differential Revision: [D35991002](https://our.internmc.facebook.com/intern/diff/D35991002/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35991002/)! [ghstack-poisoned]
Differential Revision: [D35991002](https://our.internmc.facebook.com/intern/diff/D35991002/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35991002/)! [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
May 10, 2022
Pull Request resolved: #76513 ghstack-source-id: 155029321 Differential Revision: [D35991002](https://our.internmc.facebook.com/intern/diff/D35991002/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35991002/)!
Differential Revision: [D35991002](https://our.internmc.facebook.com/intern/diff/D35991002/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35991002/)! [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
May 13, 2022
Pull Request resolved: #76513 ghstack-source-id: 155029321 Differential Revision: [D35991002](https://our.internmc.facebook.com/intern/diff/D35991002/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35991002/)!
Differential Revision: [D35991002](https://our.internmc.facebook.com/intern/diff/D35991002/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35991002/)! [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
May 13, 2022
Pull Request resolved: #76513 ghstack-source-id: 155029321 Differential Revision: [D35991002](https://our.internmc.facebook.com/intern/diff/D35991002/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35991002/)!
Differential Revision: [D35991002](https://our.internmc.facebook.com/intern/diff/D35991002/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35991002/)! [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
May 16, 2022
Pull Request resolved: #76513 ghstack-source-id: 155029321 Differential Revision: [D35991002](https://our.internmc.facebook.com/intern/diff/D35991002/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35991002/)!
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Differential Revision: D35991002
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!