move generate-code into shared build structure by dagitses · Pull Request #75699 · pytorch/pytorch

dagitses · 2022-04-12T20:30:31Z

Stack from ghstack (oldest at bottom):

Differential Revision: D35587412

NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!

Differential Revision: [D35587412](https://our.internmc.facebook.com/intern/diff/D35587412/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35587412/)! [ghstack-poisoned]

facebook-github-bot · 2022-04-12T20:30:39Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/75699
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours
↩️ [fb-only] Re-run with SSH instructions

💊 CI failures summary and remediations

As of commit 3a4fe57 (more details on the Dr. CI page):

Expand to see more

1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

pull / linux-bionic-rocm5.1-py3.7 / test (default, 2, 2, linux.rocm.gpu) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-05-03T08:31:22.7089094Z FAIL [0.012s]: test_caching_pinned_memory (__main__.TestCuda)

2022-05-03T08:31:22.7022087Z   test_scatter_cpu_dim (__main__.TestCudaComm) ... skip: only one GPU detected (0.000s)
2022-05-03T08:31:22.7026921Z   test_scatter_cpu_neg_dim (__main__.TestCudaComm) ... skip: only one GPU detected (0.000s)
2022-05-03T08:31:22.7032020Z   test_scatter_cpu_sizes (__main__.TestCudaComm) ... skip: only one GPU detected (0.000s)
2022-05-03T08:31:22.7038290Z   test_scatter_gpu (__main__.TestCudaComm) ... skip: only one GPU detected (0.001s)
2022-05-03T08:31:22.7043957Z   test_scatter_gpu_dim (__main__.TestCudaComm) ... skip: only one GPU detected (0.000s)
2022-05-03T08:31:22.7049599Z   test_scatter_gpu_neg_dim (__main__.TestCudaComm) ... skip: only one GPU detected (0.000s)
2022-05-03T08:31:22.7055467Z   test_scatter_gpu_sizes (__main__.TestCudaComm) ... skip: only one GPU detected (0.001s)
2022-05-03T08:31:22.7087506Z   test_scatter_namedtuple (__main__.TestCudaComm) ... skip: Test needs multiple GPUs (0.003s)
2022-05-03T08:31:22.7088061Z 
2022-05-03T08:31:22.7088317Z ======================================================================
2022-05-03T08:31:22.7089094Z FAIL [0.012s]: test_caching_pinned_memory (__main__.TestCuda)
2022-05-03T08:31:22.7090375Z ----------------------------------------------------------------------
2022-05-03T08:31:22.7091339Z Traceback (most recent call last):
2022-05-03T08:31:22.7092897Z   File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py", line 1800, in wrapper
2022-05-03T08:31:22.7093685Z     method(*args, **kwargs)
2022-05-03T08:31:22.7094367Z   File "test_cuda.py", line 1370, in test_caching_pinned_memory
2022-05-03T08:31:22.7095404Z     self.assertNotEqual(t.data_ptr(), ptr, msg='allocation re-used too soon')
2022-05-03T08:31:22.7096681Z   File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py", line 2223, in assertNotEqual
2022-05-03T08:31:22.7097736Z     self.assertEqual(x, y, msg, atol=atol, rtol=rtol, **kwargs)
2022-05-03T08:31:22.7098796Z AssertionError: AssertionError not raised : allocation re-used too soon
2022-05-03T08:31:22.7099308Z

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Differential Revision: [D35587412](https://our.internmc.facebook.com/intern/diff/D35587412/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35587412/)! ghstack-source-id: 153688970 Pull Request resolved: #75699

Differential Revision: [D35587412](https://our.internmc.facebook.com/intern/diff/D35587412/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35587412/)! [ghstack-poisoned]

Pull Request resolved: #75699 ghstack-source-id: 153688970 Differential Revision: [D35587412](https://our.internmc.facebook.com/intern/diff/D35587412/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35587412/)!

Differential Revision: [D35587412](https://our.internmc.facebook.com/intern/diff/D35587412/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35587412/)! [ghstack-poisoned]

Pull Request resolved: #75699 ghstack-source-id: 153688970 Differential Revision: [D35587412](https://our.internmc.facebook.com/intern/diff/D35587412/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35587412/)!

Differential Revision: [D35587412](https://our.internmc.facebook.com/intern/diff/D35587412/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35587412/)! [ghstack-poisoned]

Pull Request resolved: #75699 ghstack-source-id: 153688970 Differential Revision: [D35587412](https://our.internmc.facebook.com/intern/diff/D35587412/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35587412/)!

Differential Revision: [D35587412](https://our.internmc.facebook.com/intern/diff/D35587412/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35587412/)! [ghstack-poisoned]

Summary: Pull Request resolved: #75699 ghstack-source-id: 155255334 Test Plan: Rely on CI. Reviewed By: dreiss Differential Revision: D35587412 fbshipit-source-id: 5ab79c07029de279a1fae36519654a73bb61d430

github-actions · 2022-05-03T09:54:30Z

Hey @dagitses.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Summary: Pull Request resolved: pytorch#75699 ghstack-source-id: 155255334 Test Plan: Rely on CI. Reviewed By: dreiss Differential Revision: D35587412 fbshipit-source-id: 5ab79c07029de279a1fae36519654a73bb61d430 (cherry picked from commit 4896b72)

facebook-github-bot added the cla signed label Apr 12, 2022

dagitses mentioned this pull request Apr 21, 2022

eliminate Bazel's libtorch_cpp_generated_sources #76179

Closed

Michael Andreas Dagitses added 3 commits April 21, 2022 09:37

dagitses mentioned this pull request Apr 21, 2022

move generated-autograd-headers to the shared build structure #76183

Closed

dreiss approved these changes Apr 22, 2022

View reviewed changes

Michael Andreas Dagitses added 6 commits April 22, 2022 10:00

dagitses mentioned this pull request Apr 26, 2022

remove unnecessary ATen/core/Macros.h #76376

Closed

This was referenced Apr 27, 2022

add aten_core library #76467

Closed

aten_core in xplat #76513

Closed

Michael Andreas Dagitses added 8 commits April 29, 2022 04:15

pytorchmergebot closed this in eb27c85 May 3, 2022

facebook-github-bot deleted the gh/dagitses/318/head branch May 6, 2022 14:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move generate-code into shared build structure#75699

move generate-code into shared build structure#75699
dagitses wants to merge 62 commits into
gh/dagitses/318/basefrom
gh/dagitses/318/head

dagitses commented Apr 12, 2022 •

edited

Loading

Uh oh!

facebook-github-bot commented Apr 12, 2022 •

edited

Loading

🕵️ 1 new failure recognized by patterns

pull / linux-bionic-rocm5.1-py3.7 / test (default, 2, 2, linux.rocm.gpu) (1/1)

Uh oh!

github-actions Bot commented May 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

dagitses commented Apr 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Apr 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

🕵️ 1 new failure recognized by patterns

pull / linux-bionic-rocm5.1-py3.7 / test (default, 2, 2, linux.rocm.gpu) (1/1)

Uh oh!

github-actions Bot commented May 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dagitses commented Apr 12, 2022 •

edited

Loading

facebook-github-bot commented Apr 12, 2022 •

edited

Loading