disable the //:generate-code target in Bazel#76174
Closed
dagitses wants to merge 27 commits into
Closed
Conversation
This is about to conflict with the existing Bazel codegen outputs. Switch to it atomically. Differential Revision: [D35815288](https://our.internmc.facebook.com/intern/diff/D35815288/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815288/)! [ghstack-poisoned]
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit b8d10ac (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Apr 21, 2022
added 6 commits
April 21, 2022 07:22
This is about to conflict with the existing Bazel codegen outputs. Switch to it atomically. Differential Revision: [D35815288](https://our.internmc.facebook.com/intern/diff/D35815288/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815288/)! [ghstack-poisoned]
This is about to conflict with the existing Bazel codegen outputs. Switch to it atomically. Differential Revision: [D35815288](https://our.internmc.facebook.com/intern/diff/D35815288/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815288/)! [ghstack-poisoned]
This is about to conflict with the existing Bazel codegen outputs. Switch to it atomically. Differential Revision: [D35815288](https://our.internmc.facebook.com/intern/diff/D35815288/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815288/)! [ghstack-poisoned]
This is about to conflict with the existing Bazel codegen outputs. Switch to it atomically. Differential Revision: [D35815288](https://our.internmc.facebook.com/intern/diff/D35815288/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815288/)! [ghstack-poisoned]
This is about to conflict with the existing Bazel codegen outputs. Switch to it atomically. Differential Revision: [D35815288](https://our.internmc.facebook.com/intern/diff/D35815288/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815288/)! [ghstack-poisoned]
This is about to conflict with the existing Bazel codegen outputs. Switch to it atomically. Differential Revision: [D35815288](https://our.internmc.facebook.com/intern/diff/D35815288/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815288/)! [ghstack-poisoned]
added 2 commits
April 21, 2022 09:11
This is about to conflict with the existing Bazel codegen outputs. Switch to it atomically. Differential Revision: [D35815288](https://our.internmc.facebook.com/intern/diff/D35815288/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815288/)! [ghstack-poisoned]
This is about to conflict with the existing Bazel codegen outputs. Switch to it atomically. Differential Revision: [D35815288](https://our.internmc.facebook.com/intern/diff/D35815288/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815288/)! [ghstack-poisoned]
added 3 commits
April 21, 2022 09:37
This is about to conflict with the existing Bazel codegen outputs. Switch to it atomically. Differential Revision: [D35815288](https://our.internmc.facebook.com/intern/diff/D35815288/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815288/)! [ghstack-poisoned]
This is about to conflict with the existing Bazel codegen outputs. Switch to it atomically. Differential Revision: [D35815288](https://our.internmc.facebook.com/intern/diff/D35815288/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815288/)! [ghstack-poisoned]
This is about to conflict with the existing Bazel codegen outputs. Switch to it atomically. Differential Revision: [D35815288](https://our.internmc.facebook.com/intern/diff/D35815288/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815288/)! [ghstack-poisoned]
added 2 commits
April 22, 2022 10:00
This is about to conflict with the existing Bazel codegen outputs. Switch to it atomically. Differential Revision: [D35815288](https://our.internmc.facebook.com/intern/diff/D35815288/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815288/)! [ghstack-poisoned]
This is about to conflict with the existing Bazel codegen outputs. Switch to it atomically. Differential Revision: [D35815288](https://our.internmc.facebook.com/intern/diff/D35815288/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815288/)! [ghstack-poisoned]
dreiss
approved these changes
Apr 22, 2022
added 4 commits
April 24, 2022 19:25
This is about to conflict with the existing Bazel codegen outputs. Switch to it atomically. Differential Revision: [D35815288](https://our.internmc.facebook.com/intern/diff/D35815288/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815288/)! [ghstack-poisoned]
This is about to conflict with the existing Bazel codegen outputs. Switch to it atomically. Differential Revision: [D35815288](https://our.internmc.facebook.com/intern/diff/D35815288/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815288/)! [ghstack-poisoned]
This is about to conflict with the existing Bazel codegen outputs. Switch to it atomically. Differential Revision: [D35815288](https://our.internmc.facebook.com/intern/diff/D35815288/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815288/)! [ghstack-poisoned]
This is about to conflict with the existing Bazel codegen outputs. Switch to it atomically. Differential Revision: [D35815288](https://our.internmc.facebook.com/intern/diff/D35815288/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815288/)! [ghstack-poisoned]
This is about to conflict with the existing Bazel codegen outputs. Switch to it atomically. Differential Revision: [D35815288](https://our.internmc.facebook.com/intern/diff/D35815288/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815288/)! [ghstack-poisoned]
This was referenced Apr 27, 2022
Closed
Closed
This is about to conflict with the existing Bazel codegen outputs. Switch to it atomically. Differential Revision: [D35815288](https://our.internmc.facebook.com/intern/diff/D35815288/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815288/)! [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
Apr 29, 2022
Pull Request resolved: #76174 This is about to conflict with the existing Bazel codegen outputs. Switch to it atomically. ghstack-source-id: 155029309 Differential Revision: [D35815288](https://our.internmc.facebook.com/intern/diff/D35815288/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815288/)!
added 7 commits
May 2, 2022 03:07
This is about to conflict with the existing Bazel codegen outputs. Switch to it atomically. Differential Revision: [D35815288](https://our.internmc.facebook.com/intern/diff/D35815288/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815288/)! [ghstack-poisoned]
This is about to conflict with the existing Bazel codegen outputs. Switch to it atomically. Differential Revision: [D35815288](https://our.internmc.facebook.com/intern/diff/D35815288/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815288/)! [ghstack-poisoned]
This is about to conflict with the existing Bazel codegen outputs. Switch to it atomically. Differential Revision: [D35815288](https://our.internmc.facebook.com/intern/diff/D35815288/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815288/)! [ghstack-poisoned]
This is about to conflict with the existing Bazel codegen outputs. Switch to it atomically. Differential Revision: [D35815288](https://our.internmc.facebook.com/intern/diff/D35815288/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815288/)! [ghstack-poisoned]
This is about to conflict with the existing Bazel codegen outputs. Switch to it atomically. Differential Revision: [D35815288](https://our.internmc.facebook.com/intern/diff/D35815288/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815288/)! [ghstack-poisoned]
This is about to conflict with the existing Bazel codegen outputs. Switch to it atomically. Differential Revision: [D35815288](https://our.internmc.facebook.com/intern/diff/D35815288/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815288/)! [ghstack-poisoned]
This is about to conflict with the existing Bazel codegen outputs. Switch to it atomically. Differential Revision: [D35815288](https://our.internmc.facebook.com/intern/diff/D35815288/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35815288/)! [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
May 3, 2022
Summary: Pull Request resolved: #76174 This is about to conflict with the existing Bazel codegen outputs. Switch to it atomically. ghstack-source-id: 155029309 Test Plan: Verify manually and rely on CI. Reviewed By: dreiss Differential Revision: D35815288 fbshipit-source-id: 8b35e7baeb8572aef13c07cac689ee84dc7335d5
Contributor
|
Hey @dagitses. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
Summary: Pull Request resolved: pytorch#76174 This is about to conflict with the existing Bazel codegen outputs. Switch to it atomically. ghstack-source-id: 155029309 Test Plan: Verify manually and rely on CI. Reviewed By: dreiss Differential Revision: D35815288 fbshipit-source-id: 8b35e7baeb8572aef13c07cac689ee84dc7335d5 (cherry picked from commit 6dde983)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This is about to conflict with the existing Bazel codegen
outputs. Switch to it atomically.
Differential Revision: D35815288
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!