remove unused --ninja-global from codegen#75869
Closed
dagitses wants to merge 37 commits into
Closed
Conversation
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit e4d4146 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Apr 15, 2022
added 8 commits
April 15, 2022 06:26
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
added 8 commits
April 16, 2022 14:04
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
added 2 commits
April 19, 2022 07:25
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
This was referenced Apr 21, 2022
added 6 commits
April 21, 2022 07:22
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
added 2 commits
April 21, 2022 09:11
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
added 3 commits
April 21, 2022 09:37
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
dreiss
approved these changes
Apr 22, 2022
added 5 commits
April 22, 2022 10:00
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/) [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 26, 2022
Summary: Pull Request resolved: #75869 ghstack-source-id: 154696012 Test Plan: Verified nothing uses this and relying on CI for confirmation. Reviewed By: dreiss Differential Revision: D35674694 fbshipit-source-id: c1d602aa4d85642594160a33606093c33817988f
Contributor
|
Hey @dagitses. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
Summary: Pull Request resolved: pytorch#75869 ghstack-source-id: 154696012 Test Plan: Verified nothing uses this and relying on CI for confirmation. Reviewed By: dreiss Differential Revision: D35674694 fbshipit-source-id: c1d602aa4d85642594160a33606093c33817988f (cherry picked from commit cac15ca)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Differential Revision: D35674694