move Bazel version header generation to shared build structure#75332
Closed
dagitses wants to merge 63 commits into
Closed
move Bazel version header generation to shared build structure#75332dagitses wants to merge 63 commits into
dagitses wants to merge 63 commits into
Conversation
Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)! [ghstack-poisoned]
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 11e8eb9 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Apr 6, 2022
dagitses
pushed a commit
that referenced
this pull request
Apr 6, 2022
Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)! ghstack-source-id: 153185483 Pull Request resolved: #75332
…ture" Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)! [ghstack-poisoned]
Closed
added 6 commits
April 6, 2022 13:22
…ture" Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)! [ghstack-poisoned]
…ture" Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)! [ghstack-poisoned]
…ture" Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)! [ghstack-poisoned]
…ture" Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)! [ghstack-poisoned]
…ture" Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)! [ghstack-poisoned]
…ture" Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)! [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
Apr 8, 2022
Pull Request resolved: #75332 ghstack-source-id: 153185483 Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)!
NesrineMHB
pushed a commit
to NesrineMHB/pytorch
that referenced
this pull request
Apr 8, 2022
Pull Request resolved: pytorch/pytorch#75332 ghstack-source-id: 153185483 Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)!
…ture" Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)! [ghstack-poisoned]
…ture" Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)! [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
Apr 12, 2022
Pull Request resolved: #75332 ghstack-source-id: 153185483 Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)!
…ture" Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)! [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
Apr 12, 2022
Pull Request resolved: #75332 ghstack-source-id: 153185483 Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)!
…ture" Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)! [ghstack-poisoned]
added 4 commits
April 18, 2022 06:52
…ture" Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)! [ghstack-poisoned]
…ture" Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)! [ghstack-poisoned]
…ture" Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)! [ghstack-poisoned]
…ture" Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)! [ghstack-poisoned]
This was referenced Apr 21, 2022
added 6 commits
April 21, 2022 07:22
…ture" Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)! [ghstack-poisoned]
…ture" Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)! [ghstack-poisoned]
…ture" Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)! [ghstack-poisoned]
…ture" Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)! [ghstack-poisoned]
…ture" Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)! [ghstack-poisoned]
…ture" Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)! [ghstack-poisoned]
added 2 commits
April 21, 2022 09:11
…ture" Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)! [ghstack-poisoned]
…ture" Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)! [ghstack-poisoned]
added 3 commits
April 21, 2022 09:37
…ture" Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)! [ghstack-poisoned]
…ture" Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)! [ghstack-poisoned]
…ture" Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)! [ghstack-poisoned]
added 4 commits
April 22, 2022 10:00
…ture" Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)! [ghstack-poisoned]
…ture" Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)! [ghstack-poisoned]
…ture" Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)! [ghstack-poisoned]
…ture" Differential Revision: [D35434229](https://our.internmc.facebook.com/intern/diff/D35434229/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35434229/)! [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 25, 2022
Summary: Pull Request resolved: #75332 ghstack-source-id: 154678044 Test Plan: Rely on OSS CI. Reviewed By: malfet Differential Revision: D35434229 fbshipit-source-id: 7cdd33fa32d0c485f44477e414c24c9bc4b74963
Contributor
|
Hey @dagitses. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
…ch#75332) Summary: Pull Request resolved: pytorch#75332 ghstack-source-id: 154678044 Test Plan: Rely on OSS CI. Reviewed By: malfet Differential Revision: D35434229 fbshipit-source-id: 7cdd33fa32d0c485f44477e414c24c9bc4b74963 (cherry picked from commit 60285c6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Differential Revision: D35434229
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!