define and disable the caffe2_serialize target in Bazel by dagitses · Pull Request #75942 · pytorch/pytorch

dagitses · 2022-04-16T20:41:19Z

Stack from ghstack (oldest at bottom):

This has not yet been made compatible with Bazel. Disable it for now.

Differential Revision: D35704597

This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]

facebook-github-bot · 2022-04-16T20:41:25Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/75942
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours

💊 CI failures summary and remediations

As of commit bf5ad78 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]

Summary: Pull Request resolved: #75942 This also requires changes to the target definition and the xplat translator to get it working. ghstack-source-id: 154678046 Test Plan: Verify locally and rely on CI. Reviewed By: malfet Differential Revision: D35704597 fbshipit-source-id: 6b0d9f5a044609b24dda656f80233ba6186c097f

github-actions · 2022-04-25T16:17:25Z

Hey @dagitses.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Summary: Pull Request resolved: pytorch#75942 This also requires changes to the target definition and the xplat translator to get it working. ghstack-source-id: 154678046 Test Plan: Verify locally and rely on CI. Reviewed By: malfet Differential Revision: D35704597 fbshipit-source-id: 6b0d9f5a044609b24dda656f80233ba6186c097f (cherry picked from commit 6de43c5)

define and disable the caffe2_serialize target in Bazel

31e4bd6

This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]

facebook-github-bot added the cla signed label Apr 16, 2022

Michael Andreas Dagitses added 8 commits April 16, 2022 14:04

Update on "define and disable the caffe2_serialize target in Bazel"

65c4bc0

This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]

Update on "define and disable the caffe2_serialize target in Bazel"

a0d0afe

This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]

Update on "define and disable the caffe2_serialize target in Bazel"

7c555bf

This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]

Update on "define and disable the caffe2_serialize target in Bazel"

b6d4c5c

This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]

Update on "define and disable the caffe2_serialize target in Bazel"

fb928c0

This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]

Update on "define and disable the caffe2_serialize target in Bazel"

cf0a422

This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]

Update on "define and disable the caffe2_serialize target in Bazel"

708880a

This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]

Update on "define and disable the caffe2_serialize target in Bazel"

db6c572

This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]

dagitses mentioned this pull request Apr 18, 2022

move version_h to shared build structure in Buck #75964

Closed

Michael Andreas Dagitses added 4 commits April 18, 2022 06:52

Update on "define and disable the caffe2_serialize target in Bazel"

76a78c8

This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]

Update on "define and disable the caffe2_serialize target in Bazel"

e7845eb

This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]

Update on "define and disable the caffe2_serialize target in Bazel"

9f6c6c9

This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]

Update on "define and disable the caffe2_serialize target in Bazel"

898d7d9

This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]

This was referenced Apr 21, 2022

add support for filtering out Bazel targets from common structure #76173

Closed

disable the //:generate-code target in Bazel #76174

Closed

Michael Andreas Dagitses added 2 commits April 21, 2022 07:22

Update on "define and disable the caffe2_serialize target in Bazel"

21f9898

This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]

Update on "define and disable the caffe2_serialize target in Bazel"

a2585a6

This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]

Michael Andreas Dagitses added 4 commits April 21, 2022 08:08

Update on "define and disable the caffe2_serialize target in Bazel"

188597b

This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]

Update on "define and disable the caffe2_serialize target in Bazel"

00c2231

This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]

Update on "define and disable the caffe2_serialize target in Bazel"

d0a7fba

This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]

Update on "define and disable the caffe2_serialize target in Bazel"

430b4be

This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]

dagitses mentioned this pull request Apr 21, 2022

eliminate Bazel's libtorch_python_generated_sources #76178

Closed

Michael Andreas Dagitses added 2 commits April 21, 2022 09:11

Update on "define and disable the caffe2_serialize target in Bazel"

94ad516

This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]

Update on "define and disable the caffe2_serialize target in Bazel"

08be704

This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]

dagitses mentioned this pull request Apr 21, 2022

eliminate Bazel's libtorch_cpp_generated_sources #76179

Closed

Michael Andreas Dagitses added 3 commits April 21, 2022 09:37

Update on "define and disable the caffe2_serialize target in Bazel"

853f178

This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]

Update on "define and disable the caffe2_serialize target in Bazel"

d3f571e

This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]

Update on "define and disable the caffe2_serialize target in Bazel"

923e483

This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]

dagitses mentioned this pull request Apr 21, 2022

move generated-autograd-headers to the shared build structure #76183

Closed

malfet approved these changes Apr 21, 2022

View reviewed changes

Michael Andreas Dagitses added 4 commits April 22, 2022 10:00

Update on "define and disable the caffe2_serialize target in Bazel"

7cccf15

This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]

Update on "define and disable the caffe2_serialize target in Bazel"

75cde12

This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]

Update on "define and disable the caffe2_serialize target in Bazel"

7e8e960

This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]

Update on "define and disable the caffe2_serialize target in Bazel"

bf5ad78

This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]

pytorchmergebot closed this in d78dd82 Apr 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

define and disable the caffe2_serialize target in Bazel#75942

define and disable the caffe2_serialize target in Bazel#75942
dagitses wants to merge 28 commits into
gh/dagitses/324/basefrom
gh/dagitses/324/head

dagitses commented Apr 16, 2022 •

edited

Loading

Uh oh!

facebook-github-bot commented Apr 16, 2022 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

dagitses commented Apr 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Apr 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

Uh oh!

github-actions Bot commented Apr 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dagitses commented Apr 16, 2022 •

edited

Loading

facebook-github-bot commented Apr 16, 2022 •

edited

Loading