Skip to content

feat(linter): support ignores in overrides#22148

Merged
graphite-app[bot] merged 1 commit into
mainfrom
codex/linter-override-ignores
May 5, 2026
Merged

feat(linter): support ignores in overrides#22148
graphite-app[bot] merged 1 commit into
mainfrom
codex/linter-override-ignores

Conversation

@camc314

@camc314 camc314 commented May 5, 2026

Copy link
Copy Markdown
Contributor

Adds override-local ignores support so matching files can be excluded from a specific oxlint override without being globally ignored.

Example:

{
  "overrides": [
    {
      "files": ["**/*.js"],
      "ignores": ["**/*.generated.js"],
      "rules": {
        "no-var": "error"
      }
    }
  ]
}

closes #15997
fixes #15932

@camc314 camc314 added the A-linter Area - Linter label May 5, 2026 — with ChatGPT Codex Connector
@camc314 camc314 self-assigned this May 5, 2026
@camc314 camc314 changed the title feat(linter): support ignores in overrides feat(linter): support ignores in overrides May 5, 2026
@camc314 camc314 marked this pull request as ready for review May 5, 2026 12:32
@camc314 camc314 requested a review from overlookmotel as a code owner May 5, 2026 12:32
Copilot AI review requested due to automatic review settings May 5, 2026 12:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds per-override exclusion support (ignores) to oxlint’s configuration model so specific files can be excluded from a particular override without being globally ignored.

Changes:

  • Extend override config schema/types to include ignores: GlobSet with a clear description and examples.
  • Apply overrides only when files matches and ignores does not match.
  • Add unit tests covering parsing and the “exclude only this override” behavior.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
npm/oxlint/configuration_schema.json Adds ignores to the OxlintOverride JSON schema with documentation and default.
crates/oxc_linter/src/config/overrides.rs Adds ignores: GlobSet to OxlintOverride and a parsing test.
crates/oxc_linter/src/config/config_store.rs Implements ignore-aware override application and adds coverage ensuring ignores don’t act globally.
crates/oxc_linter/src/config/config_builder.rs Plumbs ignores through override resolution into the resolved override model.
apps/oxlint/src-js/package/config.generated.ts Updates generated TypeScript config types/docs to include ignores.

Comment thread crates/oxc_linter/src/config/config_store.rs Outdated
@camc314 camc314 force-pushed the codex/linter-override-ignores branch from 4342743 to fc30afe Compare May 5, 2026 12:40
@camc314 camc314 requested a review from Copilot May 5, 2026 12:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Comment thread tasks/website_linter/src/snapshots/schema_markdown.snap
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label May 5, 2026

camc314 commented May 5, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

Adds override-local `ignores` support so matching files can be excluded from a specific oxlint override without being globally ignored.

Example:

```json
{
  "overrides": [
    {
      "files": ["**/*.js"],
      "ignores": ["**/*.generated.js"],
      "rules": {
        "no-var": "error"
      }
    }
  ]
}
```

closes #15997
fixes #15932
@graphite-app graphite-app Bot force-pushed the codex/linter-override-ignores branch from fc30afe to fbb8f22 Compare May 5, 2026 12:48
@codspeed-hq

codspeed-hq Bot commented May 5, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 47 skipped benchmarks1


Comparing codex/linter-override-ignores (fc30afe) with main (f31fc82)

Open in CodSpeed

Footnotes

  1. 47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@graphite-app graphite-app Bot merged commit fbb8f22 into main May 5, 2026
27 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label May 5, 2026
@graphite-app graphite-app Bot deleted the codex/linter-override-ignores branch May 5, 2026 12:52
camc314 added a commit that referenced this pull request May 11, 2026
# Oxlint
### 💥 BREAKING CHANGES

- 00ce512 oxlint/lsp: [**BREAKING**] Don't fix suggestions on fixAll
code actions & command (#22195) (Sysix)

### 🚀 Features

- 0eeceaf linter/no-unused-vars: Rename parameter with initializer
(#22308) (camc314)
- fa0232b linter/no-unused-vars: Add param rename suggestion (#22285)
(Ryota Misumi)
- ae59305 linter/promise/no-promise-in-callback: Add
`exemptDeclarations` option (#22275) (Mikhail Baev)
- 60bed4a linter: Extends `no-redundant-roles` and
`prefer-tag-over-role` support roles (#22069) (mehm8128)
- 545c80f linter/eslint: Implement `prefer-regex-literals` rule (#22192)
(Mikhail Baev)
- cf86d7a linter: Bulk suppression (#19328) (Said Atrahouch)
- 23abd22 linter/jsx-a11y: Implement
no-noninteractive-element-to-interactive-role (#21264) (Pedro Tainha)
- fbb8f22 linter: Support `ignores` in overrides (#22148) (camc314)
- 5a4414d oxlint/lsp: Support `rulesCustomization` lsp option (#21858)
(Sysix)

### 🐛 Bug Fixes

- 610f4c7 linter/no-unused-vars: Avoid renaming captured vars (#22310)
(camc314)
- 6b50f23 oxlint/cli: Load root config by searching up parent
directories (#22272) (Sysix)
- 31a5de7 linter: Rename override `ignores` to `excludeFiles` (#22283)
(camc314)
- 26d5d7b linter: Add missing vitest/valid-describe-callback
functionality (#22279) (camchenry)
- 784530f linter: `valid-title`: detect `String.raw` strings (#22271)
(Sysix)
- 080d90e linter: Move `no-debugger` fix to suggestion (#22256) (Sysix)
- 25b7017 linter: Undocument override `ignores` option (#22213)
(camc314)
- 7bb00dd linter: Fix role-has-required-aria-props (#22097) (mehm8128)
- d25279e linter/disable-directives: Improve parsing of names,
descriptions (#22184) (camc314)
- a59e447 linter/disable-directives: Ignore invalid enable suffixes
(#22179) (camc314)
- aafef0f ci: Disable bulk supression test on big endian (#22175)
(camc314)
- 281daec linter/vue/define-props-destructuring: Add
`only-when-assigned` config opt (#22142) (camc314)
- 46ab679 linter/plugins: Trim leading newline for partial sources
(#20928) (bab)
- 29ff6d9 linter: Update docs for no_alias_methods rule to be
Vitest-specific and add toThrowError alias (#22129) (camchenry)

### ⚡ Performance

- 9414bee linter/role-has-required-aria-props: Avoid intermediate vec
(#22212) (camc314)
- 3883ea3 linter/no-useless-escape: Drop unnecessary Vec collect
(#22171) (connorshea)
- 42c3029 linter/check-property-names: Replace split-collect-pop-join
with rfind (#22172) (connorshea)
- 9551d53 linter: Remove unnecessary Vec collect in CFG edge traversal
(#22167) (connorshea)
- 26fa2fc linter/aria-role: Remove unnecessary string allocations in run
method (#22168) (connorshea)
- c9ce045 linter/getter-return: Remove unnecessary Vec collect in CFG
edge traversal (#22166) (connorshea)
- 72bd846 linter/no-this-in-sfc: Reorder cheap name check, avoid String
allocation (#22164) (connorshea)

### 📚 Documentation

- 4da212a linter/no-unused-vars: Add docs to
`rename_unused_function_parameter` (#22311) (camc314)
- 27c4628 linter/forbid-dom-props: Escape jsx examples in lint rule docs
(#22254) (4MBL)
- 3f81147 linter: Improve the `react/jsx-key` rule docs. (#22162)
(connorshea)
- 07f03cc linter/consistent-return: Add note about `noImplicitReturns`
coverage (#22156) (camc314)
- 7c1e049 oxlint/lsp: Improve autogenerated lsp docs (#22154) (Sysix)
- 87b3e38 linter: Update docs to be vitest-specific for
consistent-test-it (#22128) (camchenry)
# Oxfmt
### 💥 BREAKING CHANGES

- 5c6c390 oxfmt: [**BREAKING**] Respect more git ignore options, align
with Oxlint (#22210) (leaysgur)

### 🚀 Features

- 6e8e818 oxfmt: Experimental .svelte support (#21700) (leaysgur)

### 🐛 Bug Fixes

- e2a20b6 formatter: Add space after commas in import attributes
(#22274) (Leonabcd123)

### ⚡ Performance

- b756682 oxfmt: Optimize nested config prescan (#22232) (Jovi De
Croock)
- f14e81e formatter/sort_imports: Skip sort for single import runs
(#22204) (leaysgur)
- 32255b1 formatter: Process `ImportDeclaration`s in a run (#22079)
(overlookmotel)

### 📚 Documentation

- 4da6f4c formatter: Correct comment (#22217) (overlookmotel)
- ef3507d formatter/sort_imports: Refresh docs (#22203) (leaysgur)

Co-authored-by: Cameron <cameron.clark@hey.com>
@will-stone

Copy link
Copy Markdown

Hi,

Is this supposed to work with ts config files too? As I'm getting this:

❯ npx oxlint
Failed to parse oxlint configuration file.

  × Failed to parse config from /.../oxlint.config.ts
  note: unknown field `ignores`, expected one of `files`, `excludeFiles`, `env`, `globals`, `plugins`, `jsPlugins`, `rules`

@camc314

camc314 commented May 17, 2026

Copy link
Copy Markdown
Contributor Author

@will-stone this is undocumented for now as we want some more discussion internally about ti

To use (at your own risk - behaviour may change in the future):

{
  "overrides: [
    {
      "files": ["packages/services/**"],
      "excludeFiles": ["!packages/services/**/*.test.ts"],
      "rules": {
        "no-restricted-imports": "error"
      }
    }
  ]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter: Support negations in overrides

3 participants