Skip to content

feat(linter): extends no-redundant-roles and prefer-tag-over-role support roles#22069

Merged
camchenry merged 2 commits intooxc-project:mainfrom
mehm8128:feat/extends-two-a11y-rules-creating-element-role-mapping
May 7, 2026
Merged

feat(linter): extends no-redundant-roles and prefer-tag-over-role support roles#22069
camchenry merged 2 commits intooxc-project:mainfrom
mehm8128:feat/extends-two-a11y-rules-creating-element-role-mapping

Conversation

@mehm8128
Copy link
Copy Markdown
Contributor

@mehm8128 mehm8128 commented May 2, 2026

related to #21910
continued from #21933

There are still some missing roles after the previous PR and I also found no-redundant-roles rule has missing roles.
So I defined complete element-to-role mapping referencing html-aria document and use it for no-redundant-roles and prefer-tag-over-role

Co-authored-by: Copilot <copilot@github.com>
@mehm8128 mehm8128 requested a review from camc314 as a code owner May 2, 2026 08:52
@mehm8128 mehm8128 changed the title feat(linter): extends no-redundant-roles and prefer-tag-over-role feat(linter): extends no-redundant-roles and prefer-tag-over-role support roles May 2, 2026
@camc314 camc314 added the A-linter Area - Linter label May 2, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 2, 2026

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 47 skipped benchmarks1


Comparing mehm8128:feat/extends-two-a11y-rules-creating-element-role-mapping (c98edf9) with main (bc1408c)

Open in CodSpeed

Footnotes

  1. 47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Comment thread crates/oxc_linter/src/utils/react.rs Outdated
@camchenry camchenry self-assigned this May 5, 2026
Copy link
Copy Markdown
Member

@camchenry camchenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this makes sense to me. I appreciate the links to the specification, that is helpful to verify the accuracy of these changes.

@camchenry camchenry added the 0-merge Merge with Graphite Merge Queue label May 7, 2026
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app Bot commented May 7, 2026

Merge activity

  • May 7, 2:56 AM UTC: @mehm8128 we removed the merge queue label because we could not find a Graphite account associated with your GitHub profile.

You must have a Graphite account in order to use the merge queue. Create an account and try again using this link

@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label May 7, 2026
@camchenry camchenry merged commit 60bed4a into oxc-project:main May 7, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants