Skip to content

feat(linter): add ignores option to overrides#15997

Closed
xuanduc987 wants to merge 1 commit into
oxc-project:mainfrom
xuanduc987:push-owpurnllvtyy
Closed

feat(linter): add ignores option to overrides#15997
xuanduc987 wants to merge 1 commit into
oxc-project:mainfrom
xuanduc987:push-owpurnllvtyy

Conversation

@xuanduc987

@xuanduc987 xuanduc987 commented Nov 23, 2025

Copy link
Copy Markdown
Contributor

This will add a new ignores option to oxlint override config, allowing excluding some files matched by files from applying the override.

Resolves #15932

@xuanduc987 xuanduc987 requested a review from camc314 as a code owner November 23, 2025 18:14
@graphite-app

graphite-app Bot commented Nov 23, 2025

Copy link
Copy Markdown
Contributor

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions Bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Nov 23, 2025
@codspeed-hq

codspeed-hq Bot commented Nov 23, 2025 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 52 skipped benchmarks1

Comparing xuanduc987:push-owpurnllvtyy (26e632a) with main (0dc620d)

Open in CodSpeed

Footnotes

  1. 52 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@connorshea

connorshea commented Nov 24, 2025

Copy link
Copy Markdown
Member

I think it should probably be called ignorePatterns to match the root-level config option name? Although I guess it depends on how we want it to work with regards to merging with the ignore values with the root ignores

@xuanduc987

xuanduc987 commented Nov 24, 2025

Copy link
Copy Markdown
Contributor Author

I chose this name to be similar to eslint

eslint also used to have ignorePatterns config option at the root level, and in the override, it had excludedFiles options.

But now, with flat config, eslint uses ignores name in its configuration objects

@camc314 camc314 self-assigned this Dec 11, 2025
@todor-a

todor-a commented Mar 13, 2026

Copy link
Copy Markdown
Contributor

Hey, any plans to merge this? It's in the docs but apparently it's not supported 🤔 https://oxc.rs/docs/guide/usage/formatter/config-file-reference.html#overrides-n-excludefiles

@github-actions github-actions Bot added A-cli Area - CLI A-linter-plugins Area - Linter JS plugins labels Mar 18, 2026
@xuanduc987

xuanduc987 commented Mar 18, 2026

Copy link
Copy Markdown
Contributor Author

I had just rebased this PR onto current main branch

@xuanduc987
feat(linter): add ignores option to overrides
26e632a 
This will add a new `ignores` option to oxlint override config, allowing
excluding some files matched by `files` from applying the override.

Resolves oxc-project#15932
@xuanduc987

xuanduc987 commented Mar 30, 2026

Copy link
Copy Markdown
Contributor Author

@camc314 Sorry for the ping but could you take a look at this PR?

@JasonKaz

JasonKaz commented Apr 30, 2026

Copy link
Copy Markdown

Hey, any plans to merge this? It's in the docs but apparently it's not supported 🤔 https://oxc.rs/docs/guide/usage/formatter/config-file-reference.html#overrides-n-excludefiles

That is for oxfmt, not oxlint.

This is an essential feature used by our eslint configuration. Without it we cannot migrate to oxlint.

@avcharovBetsson

avcharovBetsson commented May 4, 2026

Copy link
Copy Markdown

HI @camc314, we are in need to this feature to migrate to oxlint
is there any issues with approving this PR?

@camc314 camc314 mentioned this pull request May 5, 2026
Merged
@graphite-app graphite-app Bot closed this in fbb8f22 May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camc314 camc314 Awaiting requested review from camc314 camc314 is a code owner

@overlookmotel overlookmotel Awaiting requested review from overlookmotel

Assignees

@camc314 camc314

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

linter: Support negations in overrides

6 participants

@xuanduc987 @connorshea @todor-a @JasonKaz @avcharovBetsson @camc314