Skip to content

feat(oxfmt)!: Respect more git ignore options, align with Oxlint#22210

Merged
graphite-app[bot] merged 1 commit into
mainfrom
05-07-feat_oxfmt_respect_git_ignores_align_with_oxlint
May 7, 2026
Merged

feat(oxfmt)!: Respect more git ignore options, align with Oxlint#22210
graphite-app[bot] merged 1 commit into
mainfrom
05-07-feat_oxfmt_respect_git_ignores_align_with_oxlint

Conversation

@leaysgur

@leaysgur leaysgur commented May 7, 2026

Copy link
Copy Markdown
Member

Fixes #22034.

Oxfmt now respects the same Git ignore rules as Git itself:

  • Reads .gitignore from parent directories (up to the repository boundary)
  • Reads .git/info/exclude

like Oxlint does.

leaysgur commented May 7, 2026

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added A-cli Area - CLI A-formatter Area - Formatter labels May 7, 2026
@leaysgur leaysgur force-pushed the 05-07-feat_oxfmt_respect_git_ignores_align_with_oxlint branch from 9c0552a to d694b1a Compare May 7, 2026 06:54
@leaysgur leaysgur force-pushed the 05-07-refactor_oxlint_extract_walk_vcs_helper_to_oxc_config branch 2 times, most recently from 17a5e98 to 538b1a8 Compare May 7, 2026 07:03
@leaysgur leaysgur force-pushed the 05-07-feat_oxfmt_respect_git_ignores_align_with_oxlint branch from d694b1a to 3ee8b08 Compare May 7, 2026 07:03
@graphite-app graphite-app Bot changed the base branch from 05-07-refactor_oxlint_extract_walk_vcs_helper_to_oxc_config to graphite-base/22210 May 7, 2026 07:04
@leaysgur leaysgur force-pushed the 05-07-feat_oxfmt_respect_git_ignores_align_with_oxlint branch from 3ee8b08 to ef56c9b Compare May 7, 2026 07:18
@leaysgur leaysgur force-pushed the graphite-base/22210 branch from 538b1a8 to 6b252e3 Compare May 7, 2026 07:18
@leaysgur leaysgur changed the base branch from graphite-base/22210 to 05-07-refactor_oxlint_extract_walk_vcs_helper_to_oxc_config May 7, 2026 07:18
@leaysgur leaysgur force-pushed the 05-07-feat_oxfmt_respect_git_ignores_align_with_oxlint branch from ef56c9b to cbe641f Compare May 7, 2026 07:28
@leaysgur leaysgur force-pushed the 05-07-refactor_oxlint_extract_walk_vcs_helper_to_oxc_config branch from 6b252e3 to 78e6b63 Compare May 7, 2026 07:28
@leaysgur leaysgur force-pushed the 05-07-feat_oxfmt_respect_git_ignores_align_with_oxlint branch from cbe641f to ef425a7 Compare May 7, 2026 07:36
@leaysgur leaysgur changed the title feat(oxfmt)!: Respect git ignores, align with Oxlint feat(oxfmt)!: Respect more git ignore options, align with Oxlint May 7, 2026
@leaysgur leaysgur added the 0-merge Merge with Graphite Merge Queue label May 7, 2026

leaysgur commented May 7, 2026

Copy link
Copy Markdown
Member Author

Merge activity

Base automatically changed from 05-07-refactor_oxlint_extract_walk_vcs_helper_to_oxc_config to main May 7, 2026 07:41
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label May 7, 2026
)

Fixes #22034.

Oxfmt now respects the same Git ignore rules as Git itself:

- Reads `.gitignore` from parent directories (up to the repository boundary)
- Reads `.git/info/exclude`

like Oxlint does.
@graphite-app graphite-app Bot force-pushed the 05-07-feat_oxfmt_respect_git_ignores_align_with_oxlint branch from ef425a7 to 5c6c390 Compare May 7, 2026 07:42
@camc314 camc314 self-assigned this May 7, 2026
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label May 7, 2026
@camc314

camc314 commented May 7, 2026

Copy link
Copy Markdown
Contributor

Ah this is the formatter! I've reviewed + merged out of habbit - hopefully that's ok @leaysgur !

@graphite-app graphite-app Bot merged commit 5c6c390 into main May 7, 2026
26 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label May 7, 2026
@graphite-app graphite-app Bot deleted the 05-07-feat_oxfmt_respect_git_ignores_align_with_oxlint branch May 7, 2026 07:46
@leaysgur

leaysgur commented May 7, 2026

Copy link
Copy Markdown
Member Author

I had just applied the merge label myself, so it's no problem at all~!

(I'm lucky you were able to review it. ✌🏻)

camc314 added a commit that referenced this pull request May 11, 2026
# Oxlint
### 💥 BREAKING CHANGES

- 00ce512 oxlint/lsp: [**BREAKING**] Don't fix suggestions on fixAll
code actions & command (#22195) (Sysix)

### 🚀 Features

- 0eeceaf linter/no-unused-vars: Rename parameter with initializer
(#22308) (camc314)
- fa0232b linter/no-unused-vars: Add param rename suggestion (#22285)
(Ryota Misumi)
- ae59305 linter/promise/no-promise-in-callback: Add
`exemptDeclarations` option (#22275) (Mikhail Baev)
- 60bed4a linter: Extends `no-redundant-roles` and
`prefer-tag-over-role` support roles (#22069) (mehm8128)
- 545c80f linter/eslint: Implement `prefer-regex-literals` rule (#22192)
(Mikhail Baev)
- cf86d7a linter: Bulk suppression (#19328) (Said Atrahouch)
- 23abd22 linter/jsx-a11y: Implement
no-noninteractive-element-to-interactive-role (#21264) (Pedro Tainha)
- fbb8f22 linter: Support `ignores` in overrides (#22148) (camc314)
- 5a4414d oxlint/lsp: Support `rulesCustomization` lsp option (#21858)
(Sysix)

### 🐛 Bug Fixes

- 610f4c7 linter/no-unused-vars: Avoid renaming captured vars (#22310)
(camc314)
- 6b50f23 oxlint/cli: Load root config by searching up parent
directories (#22272) (Sysix)
- 31a5de7 linter: Rename override `ignores` to `excludeFiles` (#22283)
(camc314)
- 26d5d7b linter: Add missing vitest/valid-describe-callback
functionality (#22279) (camchenry)
- 784530f linter: `valid-title`: detect `String.raw` strings (#22271)
(Sysix)
- 080d90e linter: Move `no-debugger` fix to suggestion (#22256) (Sysix)
- 25b7017 linter: Undocument override `ignores` option (#22213)
(camc314)
- 7bb00dd linter: Fix role-has-required-aria-props (#22097) (mehm8128)
- d25279e linter/disable-directives: Improve parsing of names,
descriptions (#22184) (camc314)
- a59e447 linter/disable-directives: Ignore invalid enable suffixes
(#22179) (camc314)
- aafef0f ci: Disable bulk supression test on big endian (#22175)
(camc314)
- 281daec linter/vue/define-props-destructuring: Add
`only-when-assigned` config opt (#22142) (camc314)
- 46ab679 linter/plugins: Trim leading newline for partial sources
(#20928) (bab)
- 29ff6d9 linter: Update docs for no_alias_methods rule to be
Vitest-specific and add toThrowError alias (#22129) (camchenry)

### ⚡ Performance

- 9414bee linter/role-has-required-aria-props: Avoid intermediate vec
(#22212) (camc314)
- 3883ea3 linter/no-useless-escape: Drop unnecessary Vec collect
(#22171) (connorshea)
- 42c3029 linter/check-property-names: Replace split-collect-pop-join
with rfind (#22172) (connorshea)
- 9551d53 linter: Remove unnecessary Vec collect in CFG edge traversal
(#22167) (connorshea)
- 26fa2fc linter/aria-role: Remove unnecessary string allocations in run
method (#22168) (connorshea)
- c9ce045 linter/getter-return: Remove unnecessary Vec collect in CFG
edge traversal (#22166) (connorshea)
- 72bd846 linter/no-this-in-sfc: Reorder cheap name check, avoid String
allocation (#22164) (connorshea)

### 📚 Documentation

- 4da212a linter/no-unused-vars: Add docs to
`rename_unused_function_parameter` (#22311) (camc314)
- 27c4628 linter/forbid-dom-props: Escape jsx examples in lint rule docs
(#22254) (4MBL)
- 3f81147 linter: Improve the `react/jsx-key` rule docs. (#22162)
(connorshea)
- 07f03cc linter/consistent-return: Add note about `noImplicitReturns`
coverage (#22156) (camc314)
- 7c1e049 oxlint/lsp: Improve autogenerated lsp docs (#22154) (Sysix)
- 87b3e38 linter: Update docs to be vitest-specific for
consistent-test-it (#22128) (camchenry)
# Oxfmt
### 💥 BREAKING CHANGES

- 5c6c390 oxfmt: [**BREAKING**] Respect more git ignore options, align
with Oxlint (#22210) (leaysgur)

### 🚀 Features

- 6e8e818 oxfmt: Experimental .svelte support (#21700) (leaysgur)

### 🐛 Bug Fixes

- e2a20b6 formatter: Add space after commas in import attributes
(#22274) (Leonabcd123)

### ⚡ Performance

- b756682 oxfmt: Optimize nested config prescan (#22232) (Jovi De
Croock)
- f14e81e formatter/sort_imports: Skip sort for single import runs
(#22204) (leaysgur)
- 32255b1 formatter: Process `ImportDeclaration`s in a run (#22079)
(overlookmotel)

### 📚 Documentation

- 4da6f4c formatter: Correct comment (#22217) (overlookmotel)
- ef3507d formatter/sort_imports: Refresh docs (#22203) (leaysgur)

Co-authored-by: Cameron <cameron.clark@hey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-formatter Area - Formatter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

formatter: .gitignore not respected when executing oxfmt in a sub directory

2 participants